From patchwork Tue Feb 14 18:46:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 57177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3143276wrn; Tue, 14 Feb 2023 10:50:24 -0800 (PST) X-Google-Smtp-Source: AK7set/LkkO1+XH6ocm2gsJDXHKYvOOI+f0AtGQC8+7sAos9wOZpJtMql/CXbV1KjvtJneHWOdfV X-Received: by 2002:aa7:9470:0:b0:5a8:ad0e:5bf1 with SMTP id t16-20020aa79470000000b005a8ad0e5bf1mr2506021pfq.12.1676400623865; Tue, 14 Feb 2023 10:50:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676400623; cv=none; d=google.com; s=arc-20160816; b=cIhBYmJ06xlrqKUXwR8afaP0DdR9w2m9puqf6oRMmWohJfqr1breLblXhKiz1zLi4V 6nIB15QyzbXHsBoHXWi2vv7NERQHaj4ok79KqzoDISM0AqUdlfo9hoxFVaW51Mf7v00g YXqHTkOJoLWcfOOngFdlqMXzVf7nQMbSUqIORLj7aCvJfcsi0VSgE+ZwCL31tAiwfoT3 Qy4AQwsxOpoc95/jR7dO2sO8eoe5/xn2EUA13i0xi9tnjs+NtrJdwePFX/n9VSj6OV7S M9LhNN0Z7Qw8YpMbsQuU6HqVm/oQ/UhAYtmYWOWEqoN5N+y/Dje8RxWjq32Djau0c2UZ pP6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=6RZ7TspMKDDk7tmMAFyvIRoGpdz/k0McGOaNtuOXScs=; b=tDDSc9pQSkMUoqmp/4F6zeAVpVgF6hoUXe1eKpfTCJdt3cIW46efPRkfkzZddL6EIk 7YaUtX2G4FCAvbUhN6eJD2MbOtUHcBp5fyarvpvhVBDbXAHFobdy7SW55upnKxiSLmGx Spxg1SstDAR8C4zSe7eNcA5k8alDJ1Qo0eiqxIKDiKUq2dUOaA7HCWLyyqsczn2dtkne Geghu5ewJL9V5nh6qZwsLhhM4i3jQt/+VMIiNMKZIvtwJTHvwO6YTYilt/YuUtMD8VHt R/gqlLh/Gb1J1grWJJtE0cgSQyJQ6RZ7SuYrZJQRcm250BJtCY6HZappkKEVfPphn4bv lZWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=mHLMbcVV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020aa79569000000b0058d6a27d641si695146pfq.234.2023.02.14.10.50.11; Tue, 14 Feb 2023 10:50:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=mHLMbcVV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbjBNSqo (ORCPT + 99 others); Tue, 14 Feb 2023 13:46:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233438AbjBNSqd (ORCPT ); Tue, 14 Feb 2023 13:46:33 -0500 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CAFC2FCF7 for ; Tue, 14 Feb 2023 10:46:30 -0800 (PST) Received: by mail-pl1-x64a.google.com with SMTP id y15-20020a1709029b8f00b00198e0564d73so9635684plp.22 for ; Tue, 14 Feb 2023 10:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=6RZ7TspMKDDk7tmMAFyvIRoGpdz/k0McGOaNtuOXScs=; b=mHLMbcVVgMDEwYayJ9YUqi2Dw/jj0GYAjAZKWXI4WKsLDy/gyCPJJ0nf7Qy2PNmSyp k6KjMqwph6digoMqvido6AvIDuV+z+trxmm7HluclADFe1vYGJfovo80iN7x5D3Ni8aj RncvhqsMaqT+sRK+wYRVHs8u94Y6vhKS4jWU3AHQmyXPGprS0/tuVqk08DitnA0wlGWg VSfm0DI1b1QvgzpNC7HkBN6EaboH9RGMY5tCaCfxK3sq0IOjGdLvYMfEtrW7q0L9ADrb rNGLC+ah7weJiVsJSeqmbOjqWuXkrRTroxPUja7wHZgIxhi2NRChj/KcnUDNyRnb9GNe aQhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6RZ7TspMKDDk7tmMAFyvIRoGpdz/k0McGOaNtuOXScs=; b=MwhyrRJ64pvfXhCRnv3NF/I/LfozYXXWPWY2nTLkH/q/epF04/kjV5OwUqy48eqkUj ZK9mLahKDqhUHGP3mKfaLlZDuxODxElWD18L1Pnkcxyfic9GLMYcbnr18IDWPq4tLzr7 iq70lXRwtb72XyluynCgW7BQgdZFTkADxjlRoxaM7IoW/A90NEpjC+8sDjGB62Y52CVI PKc1LG/tMHQzdy7G2so0CJD4rXqMvgtWUeRLIAq6rb0kg8y7QnRDLI8lb3r6TsyNSFuV agmPZDllxQGWDe+TjNPGnDIMDzmEiHgcgin1jDQDqpPeRIQkaAI9QmetuQiENVUdBu39 7LuA== X-Gm-Message-State: AO0yUKW7ITQsEOMj/0eVW+kqgbAyLUi9y4INbXe5DSPkKOPKeOcBplti p+bbPueAkjl/RPIaNEPAGt+bi/4ADIhb X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a63:3855:0:b0:4fb:d300:c637 with SMTP id h21-20020a633855000000b004fbd300c637mr63299pgn.6.1676400389768; Tue, 14 Feb 2023 10:46:29 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 14 Feb 2023 18:46:05 +0000 In-Reply-To: <20230214184606.510551-1-mizhang@google.com> Mime-Version: 1.0 References: <20230214184606.510551-1-mizhang@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230214184606.510551-7-mizhang@google.com> Subject: [PATCH v2 6/7] KVM: selftests: x86: Enable checking on xcomp_bv in amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757833460315769516?= X-GMAIL-MSGID: =?utf-8?q?1757833460315769516?= After tilerelease instruction, AMX tiles are in INIT state. According to Intel SDM vol 1. 13.10: "If RFBM[i] = 1, XSTATE_BV[i] is set to the value of XINUSE[i].", XSTATE_BV[18] should be cleared after xsavec. On the other hand, according to Intel SDM vol 1. 13.4.3: "If XCOMP_BV[i] = 1, state component i is located at a byte offset locationI from the base address of the XSAVE area". Since at the time of xsavec, XCR0[18] is set indicating AMX tile data component is still enabled, xcomp_bv[18] should be set. Complete the checks by adding the assert to xcomp_bv[18] after xsavec. Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index bd8bd9936f8e..0e4c65f9e2f2 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -197,6 +197,7 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, xstate->header.xstate_bv = XFEATURE_MASK_XTILEDATA; __xsavec(xstate, XFEATURE_MASK_XTILEDATA); GUEST_ASSERT(!(xstate->header.xstate_bv & XFEATURE_MASK_XTILEDATA)); + GUEST_ASSERT((xstate->header.xcomp_bv & XFEATURE_MASK_XTILEDATA)); /* xfd=0x40000, disable amx tiledata */ wrmsr(MSR_IA32_XFD, XFEATURE_MASK_XTILEDATA);