From patchwork Tue Feb 14 18:46:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 57178 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3143319wrn; Tue, 14 Feb 2023 10:50:29 -0800 (PST) X-Google-Smtp-Source: AK7set/aXKQNneiTiaXR2uFxfbvkG4OBwC46TuBrjyigbZ4zEcajtGMa4I1ejGBs+fZTLnj+hlk+ X-Received: by 2002:a17:903:2806:b0:19a:8565:4797 with SMTP id kp6-20020a170903280600b0019a85654797mr3082088plb.61.1676400629356; Tue, 14 Feb 2023 10:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676400629; cv=none; d=google.com; s=arc-20160816; b=MhE0GRjnDACKokI3a6FfCZ65GapqIjEfS7+Cs8rM80cIj643fmljrzWWCRMqujhTdy ixJvL731DGsoB8AKf53RqMCQCqBKwoKqP8Lvxj36B8bfxLi4M1sZ9hO6C/ppRrprLN25 9/1vPIwl87z04tNik4aYLw+CRTNRv3sMajDgX/vY2UYiWoy7Fyp/JhOnisQppvLbyNAq UFjFT33EHtav6kPcSaccIrXVSwhh3213jM+T9KYlkeaCdqWvPlEhjieFbX3Af17IyHe7 W6fTQfx1Yy3Z4GeziviQOnOyWT7896IbWest2eJMkVmwwRA8/a9eS+B2k+qz4PrRuuai E/HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=yFTrZ49NPc/OCN422DTCBQnAUieTNXYf1AUTcxKKvJo=; b=ygXOboPA2jystS2ezLgTzeYMRG1sciXJjLhoI3CsAdI0Evxm7dmOT8EAhQdBr2nMM4 LyGMhhqqg5wCgeM+SLHlO8wyHHU5pTATfxPHOgaDTO41MnHMl4DE1ZTtCiC7TYovtSdg I9anGeSAGUlyegDF314Jvqc+npaukJwdTk+SAbV48kZ5maD48q1+OCRYQTQ5v/6T/Vgq aJKA3HPjF+sLf4YldHhfKKB0N4F4WewhKqGpH4yVWmXQ4lqO2SJ3Y1Zi445VmULO1V8h VpVrnceA19EPMe+m0KyRk0ebqd3Vw7UHf0TJWK8VFlGzlckTnTMQqchqoYpbpn2qzWhT WAMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=HkiNOU0O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020a170902b71600b00188f3bd383csi14490913pls.266.2023.02.14.10.50.16; Tue, 14 Feb 2023 10:50:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=HkiNOU0O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233142AbjBNSqb (ORCPT + 99 others); Tue, 14 Feb 2023 13:46:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233094AbjBNSq1 (ORCPT ); Tue, 14 Feb 2023 13:46:27 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 332602FCE0 for ; Tue, 14 Feb 2023 10:46:25 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id h14-20020a258a8e000000b00827819f87e5so16635721ybl.0 for ; Tue, 14 Feb 2023 10:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=yFTrZ49NPc/OCN422DTCBQnAUieTNXYf1AUTcxKKvJo=; b=HkiNOU0OtF0CfkY42/ahYT9mmm4slpuv+KGwhyzZGBxJ7S+wC9r1M0X7JT9YhltQca VKbAk2ZR15AQcB6XBfCFC5nNuXzWQcCApf8nWUiAAuIq1Oym4XMmrfaWRHJljB8ceTkh W7ci1QAam82T757rvrhOmt6xe08JQcIQS5lImc48pPMqdSVDQwnZQ4WlxGBZ2BJU5CMP Sh2yCuKp9LYj106cTZoHjb6wRLvUHqInuWShbiLlngs+0OVkIwzDTCFW1mw0QMhSYI6o IITMqyO6TEyQFx4rLl9qwosAhabd2sb6poZ8UZchfe0jMzMDHNMus26SuAFvmp1IpJNJ LhSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yFTrZ49NPc/OCN422DTCBQnAUieTNXYf1AUTcxKKvJo=; b=O/BNuexmiEKNdzsUkSrdgg4xcUx93CKjYZT9u35iv6EJI4aUCTE0JrqHCkosK+cM1i F2O4Cwh9I0URFuey/uO1kKBh4Dl7kVU99A/mMoG/ZA4/Dc/3c59j2KEYv40EukQwsVQi MQJrVra9ExEBKq9Uz4XHLdBsrv1tgppvwGJ+TNx+GrjlglwOywzBPpj2tUNB8tX9Y+om zeg/vBSkJ0eC1gcN1rO5DlMbBMZkjao+JTOU7T90AyfrCNyCbt234cgGK3qzAtd0LC7F zXm942whCGVkEgMEXCOcRs+Kd2iWevN5NX9I1XJsEdyNNJTrZ4TExnnAI65GR7DrUUfg ZhUg== X-Gm-Message-State: AO0yUKVQTtQXWGVhF6uXSq2sv0ePGNriiGm8T7BBMOrL9QeWBwBATQIT YlzocCWg83bCr3doFG5EyBB+X9y7l3cJ X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a05:6902:110f:b0:8da:f656:8da6 with SMTP id o15-20020a056902110f00b008daf6568da6mr30ybu.7.1676400383934; Tue, 14 Feb 2023 10:46:23 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 14 Feb 2023 18:46:02 +0000 In-Reply-To: <20230214184606.510551-1-mizhang@google.com> Mime-Version: 1.0 References: <20230214184606.510551-1-mizhang@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230214184606.510551-4-mizhang@google.com> Subject: [PATCH v2 3/7] KVM: selftests: x86: Add check of CR0.TS in the #NM handler in amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757833466576981069?= X-GMAIL-MSGID: =?utf-8?q?1757833466576981069?= Add check of CR0.TS[bit 3] before the check of IA32_XFD_ERR in the #NM handler in amx_test. This is because XFD may not be the only reason of the IA32_XFD MSR and the bitmap corresponding to the state components required by the faulting instruction." (Intel SDM vol 1. Section 13.14) Add the missing check of CR0.TS. Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index aac727ff7cf8..847752998660 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -215,6 +215,7 @@ void guest_nm_handler(struct ex_regs *regs) { /* Check if #NM is triggered by XFEATURE_MASK_XTILEDATA */ GUEST_SYNC(7); + GUEST_ASSERT((get_cr0() & X86_CR0_TS) == 0); GUEST_ASSERT(rdmsr(MSR_IA32_XFD_ERR) == XFEATURE_MASK_XTILEDATA); GUEST_SYNC(8); GUEST_ASSERT(rdmsr(MSR_IA32_XFD_ERR) == XFEATURE_MASK_XTILEDATA);