From patchwork Tue Feb 14 18:46:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingwei Zhang X-Patchwork-Id: 57174 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3142528wrn; Tue, 14 Feb 2023 10:48:34 -0800 (PST) X-Google-Smtp-Source: AK7set+MR0Dji7enxvDkvW/oPcCFzW0A8OMqEHBQZECLILq9dXkozYzPWl5M0QZsFdMBoSyHXJlf X-Received: by 2002:a50:a6d9:0:b0:4ac:c44e:a493 with SMTP id f25-20020a50a6d9000000b004acc44ea493mr4015280edc.2.1676400513848; Tue, 14 Feb 2023 10:48:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676400513; cv=none; d=google.com; s=arc-20160816; b=VBTUhxi31S1kwEfbGIHJeKyg/W7Wf31aP6945FChlW98PC0UnrYU9Igx97gPL6odaP 4L27EaIYFF9j+BLS0ucwrRNriHBj8h/dEjo6uwAsytun2IF2ccnvcHyFMXCTmwY3/7oo UDkfj1xEUD+76mRlAkFGTykPOeBrbZaskMVJ/11JghMQy8nMYYzdUuKmpChXXf3adj1P rXeDnRLNSz4xMJ88e/6hxAJlGeSSh29/rpWp6nXdkzkoaNeyrpp5/T22NinjTSDMqZhh XiTHVBaQvZ1brM7EWOJjO7O43Uhp577CQOFAwQEFROxvMsRaZ2OZQId2n89aiB4Bnfru yaSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=5nUSaAHTCtcISA3mdIgge3B10pS6vcmVmT5MYhffil4=; b=pqgazdcOgwT8GNsWnI6b4dHmOzJ/P0RS61ATBzk5Iiz6N94s62THuV12AOU6tptKl5 vcMuFK36fPMER4mOVvt7WNqKho0itzNY4tWNbJGy3XID407QV8NQ1OIp4fow5Nez+9Rf xjEkrACXjsweb57/B99x0Auvmrc9CsVcBkm6Y68QpmmWQ+8+iBlHGcXZMEGmKj7LZucz rZRZKVfQAwq20OGurvzTp87nTo2eLwDatvq/IpeXxo5iSRr2Ei8U1LylFu/EYeWHgY0Q WFgjAz+VpSqkryrSsEsnr+YUOcvjYI5suhibsPyNuQsQXEAcQpeRdLhG+piypA186X+l PXZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZTtGmMon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d7-20020aa7c1c7000000b004ab4ab4c512si14635867edp.140.2023.02.14.10.48.10; Tue, 14 Feb 2023 10:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZTtGmMon; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233132AbjBNSq2 (ORCPT + 99 others); Tue, 14 Feb 2023 13:46:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233014AbjBNSqX (ORCPT ); Tue, 14 Feb 2023 13:46:23 -0500 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 964E92F78C for ; Tue, 14 Feb 2023 10:46:22 -0800 (PST) Received: by mail-pj1-x1049.google.com with SMTP id bg13-20020a17090b0d8d00b00233ee678ea6so2708892pjb.2 for ; Tue, 14 Feb 2023 10:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=5nUSaAHTCtcISA3mdIgge3B10pS6vcmVmT5MYhffil4=; b=ZTtGmMonLp63QLXd3+qi7ZNjcLN08BBqVEFbE3+QZzT8r/Pvq6CIEIGkJohT90B8R6 Bjpx1TI25787jVCqUdpEHMgeHJvFIM+nIpyq8XN3inXL4spBTFSwqXwQZnhoZiBQzJO6 TN+GES4KnuSQWeoAnQ4EAPgfIVhNAudXijByl3hE8hl2j4fi1LWLZYCYu9CdvXUxaZ+u whraXb0fPSbe/bqB67ELNCxCUtB7C5sm77ANXkef5sRLCRoQqMBaN9IQ5ZVI5yJYOoTD LYXZbCC5CA9silAM3ISnSO2mnYZASaUQMaJVmym+J7JMADsXMw8yOX1wcizMa5EDG6+W muJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5nUSaAHTCtcISA3mdIgge3B10pS6vcmVmT5MYhffil4=; b=gT8/xrO/yuIYbCzvX5zbUbYGZoDN5hlGZdAe2VjAZJezUEMo9P4NN2WHkEb4J9YbK5 VU6jfXAXeXp4ypi7O9jyf/FzwwQ/FIz3n8hnJSt0yL3sifBwHAOTX3muaFDF491GOqkd nTXojGxpOdq71PeOGGnTM5oOczakv/VXeFFU8q1EsJTeLd5SAm4e0f1uK4lNWFGkp4N5 qXLHDYcQ2tuvr21CGT7bleFj6MgYgVZuqcJ/56pkYZUc9fZS6lzK/YKI8dcnCxGt9ZX9 oBE7hNvFPzYpS/6MF9+3erAoO3Bz6lZ9UMmTzSAZONh2k2ekCb25D44GQePcr6DDBYpv ecAg== X-Gm-Message-State: AO0yUKV5AD0cSMK3OXBn3d01iSZj7+rjk2YHM5wzVBuJp0h3P8fDO6lh X2q+QOCy/sFAJt34doqyHenXu1TtK7Yb X-Received: from mizhang-super.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1071]) (user=mizhang job=sendgmr) by 2002:a63:6dc7:0:b0:4fb:ba81:7143 with SMTP id i190-20020a636dc7000000b004fbba817143mr63323pgc.0.1676400382093; Tue, 14 Feb 2023 10:46:22 -0800 (PST) Reply-To: Mingwei Zhang Date: Tue, 14 Feb 2023 18:46:01 +0000 In-Reply-To: <20230214184606.510551-1-mizhang@google.com> Mime-Version: 1.0 References: <20230214184606.510551-1-mizhang@google.com> X-Mailer: git-send-email 2.39.1.581.gbfd45094c4-goog Message-ID: <20230214184606.510551-3-mizhang@google.com> Subject: [PATCH v2 2/7] KVM: selftests: x86: Fix an error in comment of amx_test From: Mingwei Zhang To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757833345086675511?= X-GMAIL-MSGID: =?utf-8?q?1757833345086675511?= After the execution of __tilerelease(), AMX component will be in INIT state. Therefore, execution of XSAVEC saving the AMX state into memory will cause the xstate_bv[18] cleared in xheader. However, the xcomp_bv[18] will remain set. Fix the error in comment. Also, update xsavec() to XSAVEC because xcomp_bv[18] is set due to the instruction, not the function. Finally, use XTILEDATA instead 'bit 18' in comments. Cc: Jim Mattson Cc: Venkatesh Srinivas Cc: Aaron Lewis Signed-off-by: Mingwei Zhang --- tools/testing/selftests/kvm/x86_64/amx_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c index d506821a5a26..aac727ff7cf8 100644 --- a/tools/testing/selftests/kvm/x86_64/amx_test.c +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c @@ -190,7 +190,10 @@ static void __attribute__((__flatten__)) guest_code(struct tile_config *amx_cfg, GUEST_SYNC(4); __tilerelease(); GUEST_SYNC(5); - /* bit 18 not in the XCOMP_BV after xsavec() */ + /* + * After XSAVEC, XTILEDATA is cleared in the xstate_bv but is set in + * the xcomp_bv. + */ xstate->header.xstate_bv = XFEATURE_MASK_XTILEDATA; __xsavec(xstate, XFEATURE_MASK_XTILEDATA); GUEST_ASSERT(!(xstate->header.xstate_bv & XFEATURE_MASK_XTILEDATA));