From patchwork Tue Feb 14 17:31:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 57169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3121884wrn; Tue, 14 Feb 2023 10:04:25 -0800 (PST) X-Google-Smtp-Source: AK7set+AJAsSv+L2llcyWHk3J7qK1QIQHjMc4Xluo761v34vjnWH+4fIAfLoHjkD7PXeRYJI0P96 X-Received: by 2002:a05:6a20:8401:b0:be:c217:9580 with SMTP id c1-20020a056a20840100b000bec2179580mr3639321pzd.49.1676397865462; Tue, 14 Feb 2023 10:04:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676397865; cv=none; d=google.com; s=arc-20160816; b=BkN0iDbKnnvK9PQbJnQrHrvmZStAwv9CvZjosd7KlGoTwwn/8aWH2/AKw0u1Ilpkf5 u+w00ZGCcFzwMej44q0IHhtaVazFOTxhu64KbksSjTb9tXfJzd2PQmuvfloiGXjc5GzB 4dIxgstfzIv//vRWNyo6YRDdyRZ8j4jVfftjGZwodTjDdg9o2znRxquxbfjvukAXk9IE YHBWyB2M0yaMPLjD7ziUINyzheVWEvkzqno8gN6mbGNZteqaQiICWvYbWdMqdZSo7ehT OEeusdMtcMe0H6Px7Em+H7IWVPVuadyjLCGXrFRA+lYLQo/8/H30ys5x86sGq4lTje8i 9uTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DYv8a/6OJy8MXb4KukAGuO4KrVafYfuTHns/Kb02ayY=; b=dMtY9Tj94QMOx25kGDoCkMIrQCajofZQakBDzg+v9bpun9ZKc7jRLoNRAmlG4JjqGX wEwefjL5kC2YiYJsRbSsPbsKboxPxKdgu1T+Ttmpz6MC74+y0HOtJvPHaTswyPXB1xdC 9LMmo5DLA54O0yxtZpcUykW1AD+o34uuUNbomwLSeaH4g8Dz9KpRPTD6emqrrJzG9SE9 D/HQo5xeufPCoQUoB7aU0BDznAgk/NTEj344nyBOM64SACmvLzczVm0n9Cyag4cfwVeA NdzN5gcak6QlGIBxtsG0ooMsEyhjzU9f/lJ8T/6JrxLC3qR+lygzZu5nTOeva5dwJJew Ss3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="DmTOd/wj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s16-20020aa78bd0000000b005a8aba4acdfsi4360988pfd.79.2023.02.14.10.04.12; Tue, 14 Feb 2023 10:04:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="DmTOd/wj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbjBNRdQ (ORCPT + 99 others); Tue, 14 Feb 2023 12:33:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233099AbjBNRc7 (ORCPT ); Tue, 14 Feb 2023 12:32:59 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7EE02FCDB for ; Tue, 14 Feb 2023 09:32:30 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id w3so11490525edc.2 for ; Tue, 14 Feb 2023 09:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DYv8a/6OJy8MXb4KukAGuO4KrVafYfuTHns/Kb02ayY=; b=DmTOd/wjk7KS04TN9/EsVziPdXoeM86DwwoO0M6up/iMBT9+UbMYH9B1i1n03++RnF 78wjQCqUU3/LbnAKkws9hcZnmG24rdLdQTRWqzrp/S9iT2tTH0sI663FrVRpPdnX6ZsD F5eUwtJ5/cCoKPF2K+KllxHTPtZY8NhSIB/xBIa9E8tpOrKvYe9pPrOGbOa+A71LT7W0 hy07eF810ArwqBMjxqpAQN3nbZUi09mMJ2CS2kR+3V1Zr0x7g/KufmKlFk4rrg8cXySd boesWPGSXS9we+H7a9jvFC4wEFgWWgvX3UU7OZBKR3HnwVoiutPUg+Nt1lw1pcQ79JSJ YSdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DYv8a/6OJy8MXb4KukAGuO4KrVafYfuTHns/Kb02ayY=; b=A+pbGSj2QxcGO9zJMK8QqqPBe86QIlDnp7VbF3AX2nLka5Y5YbnTDXzpqt9KMZ/r49 ccTsl7QvLxgSBj3AwrLQ3wS0+1RxeljITgN0sKkgm0SWx39lD8y2MGXkr38wFsWOjoVm 3FR2OooHoBb+jhiJmQEST9xBmfIsfNJn6zD4L6QNkKiM4xYBZJhJ9AYdQJWSWXJbgTlD OUI6H7budn8rDGWtzcqbL/XceAySE7+TiYlhki3YQyo9USfJPZlUNoEkmEmFW2dz9sex 0lF8MQZw4xJz8+1DbIZsMDwVxGvINdFQuLwGVOQBb2HuhnWgYYhQ+O8x304DKS8c5XXE j2fg== X-Gm-Message-State: AO0yUKXnULRbeS+43CotMB2MJ+sT0lyfX3xdTIOecPudKIACkiwLBq1J rHvuzXazk2zEHHLQpuM5MZ8sQQ== X-Received: by 2002:a50:871a:0:b0:4ac:b4f2:ce44 with SMTP id i26-20020a50871a000000b004acb4f2ce44mr3371125edb.38.1676395949068; Tue, 14 Feb 2023 09:32:29 -0800 (PST) Received: from localhost.localdomain (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id w8-20020a50c448000000b0049668426aa6sm8325787edf.24.2023.02.14.09.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:32:28 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Akhil P Oommen , Chia-I Wu , Douglas Anderson , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 12/14] drm/msm/a6xx: Use "else if" in GPU speedbin rev matching Date: Tue, 14 Feb 2023 18:31:43 +0100 Message-Id: <20230214173145.2482651-13-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214173145.2482651-1-konrad.dybcio@linaro.org> References: <20230214173145.2482651-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757830568069155050?= X-GMAIL-MSGID: =?utf-8?q?1757830568069155050?= The GPU can only be one at a time. Turn a series of ifs into if + elseifs to save some CPU cycles. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index b08ed127f8c4..ffe0fd431a76 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2153,16 +2153,16 @@ static u32 fuse_to_supp_hw(struct device *dev, struct adreno_rev rev, u32 fuse) if (adreno_cmp_rev(ADRENO_REV(6, 1, 8, ANY_ID), rev)) val = a618_get_speed_bin(fuse); - if (adreno_cmp_rev(ADRENO_REV(6, 1, 9, ANY_ID), rev)) + else if (adreno_cmp_rev(ADRENO_REV(6, 1, 9, ANY_ID), rev)) val = a619_get_speed_bin(fuse); - if (adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), rev)) + else if (adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), rev)) val = adreno_7c3_get_speed_bin(fuse); - if (adreno_cmp_rev(ADRENO_REV(6, 4, 0, ANY_ID), rev)) + else if (adreno_cmp_rev(ADRENO_REV(6, 4, 0, ANY_ID), rev)) val = a640_get_speed_bin(fuse); - if (adreno_cmp_rev(ADRENO_REV(6, 5, 0, ANY_ID), rev)) + else if (adreno_cmp_rev(ADRENO_REV(6, 5, 0, ANY_ID), rev)) val = a650_get_speed_bin(fuse); if (val == UINT_MAX) {