From patchwork Tue Feb 14 17:31:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 57168 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3121863wrn; Tue, 14 Feb 2023 10:04:23 -0800 (PST) X-Google-Smtp-Source: AK7set85bxGku95Oc9nXN2zTPEGMPrEK0oMCfotc7dtZg1HRurbH0YGmdK4kRCrA+O7qr3DsVfRK X-Received: by 2002:a17:903:2448:b0:196:2bf1:b690 with SMTP id l8-20020a170903244800b001962bf1b690mr3802548pls.13.1676397863065; Tue, 14 Feb 2023 10:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676397863; cv=none; d=google.com; s=arc-20160816; b=s1vt5GYPurno5VRrko1NQhzcTlp1fGG8HpBDzDdfa452GQPNC39wy9HFyF3drRNWZW NyC5pwzAHB85BuQeQvLg1ylnm/CFQr2K/60cgh1FF0TalcwlRNCg43vP8VWKuMbJt4JX Dr6lmdBsK+K0F0oQf1YNUdeIsmWrV8IRuPNqrRwuuDKIzNAoq3akMuyyEyiDMg2Pegmy TglaHc+EEMBZE38DXw6YvITA84fuxqNb2e9C7SjL+/8aQmSrYa/88M6CTCXUla/WeIwf MS1nHCAiwA6xZroYYLip0oGJhr6AxEnUje1KPhsIqpATIJwoTffYwWBKvy9OrpQgnBcB C4Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=75tuzeWbOHge8haUYR8VqjYvI04B0j5B+fIBRQ7seb4=; b=Fy+TdB6d3+k/5MlptXznsXOI2ardIDlZ9ydyRCcZjJUJ8FQ3gEJqEgFllOQsTpUmi1 ZfJR1OyHwnNjo2b2nVYUbY18Hsm50rFQzkVLt7Tek2ULZxp98Rig7J28JZRrvhkYdbd1 mIyMWuN6p121v0ig4Mp+YBmp8p1EtwGUqVC+JTX3vRmey/q9+qoAjE9kXqhjvleRpaJA NG8D26fF/KtFbENCCyzWsHW6/dQ5antq9G1z4Ebpr23mzSdpO6aB8VPzKDuEYYpyJwQR +lgG0Tjl7iaX2IW/Srfy/B2ld4zfJnA18uUEaIcWgWXmQtGfm51TmXqTzF3bHw9jVXz8 SoKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dAcCPrk/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i133-20020a639d8b000000b004f1e98f79aesi15350237pgd.868.2023.02.14.10.04.09; Tue, 14 Feb 2023 10:04:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="dAcCPrk/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231876AbjBNRdF (ORCPT + 99 others); Tue, 14 Feb 2023 12:33:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231557AbjBNRct (ORCPT ); Tue, 14 Feb 2023 12:32:49 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 087932DE71 for ; Tue, 14 Feb 2023 09:32:27 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id d40so17251018eda.8 for ; Tue, 14 Feb 2023 09:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=75tuzeWbOHge8haUYR8VqjYvI04B0j5B+fIBRQ7seb4=; b=dAcCPrk/5VN/ClxEQr1TVvSb/2mo/TA+rgX9sxkv6f+KXSvy4R1iQXsx0231GcB+V0 QOLx5lBOHEQ8hvs83FoiRKhPFLzJ6SQzY76lgQR5cd43St9NTG2RSiaj1DckHoCi3hLz lFsG0VuBW1ny48WR4JXTzZ6JtfEQLTY0nyHBQQy1Wc7xlOlXhNuRCGfR0CLMJX0MdRn9 i5K/pRPH1NmekmUqOBeVHcgCA5BJtnvtd0ZHhqxZWckykRn9NUpB0Rgc01iCkSk/VaBO zqUZBD1bewZd/l9DLSDMzUv60BHMQ7YorigdRgm9ozGtsGeinss72sAgge78ie5IPZl/ 96tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=75tuzeWbOHge8haUYR8VqjYvI04B0j5B+fIBRQ7seb4=; b=r5xLKBQW5FZ5T38v86Mw52WCosBt3R1hOW8HP4cN/zww7MsT8zzIeNm7+ruaWUp3d1 jvJqiEixiqmOq4NopsOxfffrvB2mI0b9A64pd55IArdCFlwfRlOID9oSU4w2qaKMwB4B uKCuqR0Wi38ykLZtTh7Z6GDrFWA6N7kB6aCQmfMn8L8fmpS7H8Gy6GDNcAodnBJvF74H HZDQ0k2PFnicQ2yC5LPSHyZHwgrcdi0930WHWy/Ak0Z+f4e+fmToP2wW0ul7MpHJVylY K/YCDiOmA4ko5wu1wIppWDBvOw6jsl9n0uh4dv/j1LPB1BVPE5rZFwpBXDnZD2ZHPHEQ UYvQ== X-Gm-Message-State: AO0yUKXv7VEAjY9Udpao5Opcvu4k6Kid2kiDHlzLERSVBrDH44qdOxIt tRhg+MxKJXzyxeGbSyhxlyMRWA== X-Received: by 2002:a50:ce4e:0:b0:4aa:a4e9:fa28 with SMTP id k14-20020a50ce4e000000b004aaa4e9fa28mr3000868edj.34.1676395946610; Tue, 14 Feb 2023 09:32:26 -0800 (PST) Received: from localhost.localdomain (abxh117.neoplus.adsl.tpnet.pl. [83.9.1.117]) by smtp.gmail.com with ESMTPSA id w8-20020a50c448000000b0049668426aa6sm8325787edf.24.2023.02.14.09.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:32:26 -0800 (PST) From: Konrad Dybcio To: linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Konrad Dybcio , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Akhil P Oommen , Chia-I Wu , Douglas Anderson , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/14] drm/msm/a6xx: Enable optional icc voting from OPP tables Date: Tue, 14 Feb 2023 18:31:42 +0100 Message-Id: <20230214173145.2482651-12-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214173145.2482651-1-konrad.dybcio@linaro.org> References: <20230214173145.2482651-1-konrad.dybcio@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757830565734400891?= X-GMAIL-MSGID: =?utf-8?q?1757830565734400891?= On GMU-equipped GPUs, the GMU requests appropriate bandwidth votes for us. This is however not the case for the other GPUs. Add the dev_pm_opp_of_find_icc_paths() call to let the OPP framework handle bus voting as part of power level setting. Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index d6b38bfdb3b4..b08ed127f8c4 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2338,5 +2338,9 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev) msm_mmu_set_fault_handler(gpu->aspace->mmu, gpu, a6xx_fault_handler); + ret = dev_pm_opp_of_find_icc_paths(&pdev->dev, NULL); + if (ret) + return ERR_PTR(ret); + return gpu; }