From patchwork Tue Feb 14 17:13:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 57150 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3102627wrn; Tue, 14 Feb 2023 09:22:00 -0800 (PST) X-Google-Smtp-Source: AK7set8qVsRVAWwCWvCR1QifNLnNwGTa9acVexqNCdUJOLkqwaYqrja7cmnV7ze0Lc8cMpvJ/RBg X-Received: by 2002:a17:902:d4c3:b0:19a:732c:5aa4 with SMTP id o3-20020a170902d4c300b0019a732c5aa4mr374845plg.10.1676395320446; Tue, 14 Feb 2023 09:22:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676395320; cv=none; d=google.com; s=arc-20160816; b=VUOjJ1st2xhMVlAzrdlG63qUrMAVwmjWftF99CEYAqisfkCpyaWdqRGSxbweq9ujat L+gOVxxEV2fPlRiu+E+Deiy41jyR36Wy1b2tKKoLMNKoHiAedHZqnbwrV35kXY+YPB3A 6/UDmWJ9rZVnllRjP5R9wMwWkVsvBo60XdHJlM1N4nW+Vu0/DyH1qkFK1gCFM3opYH/3 +ThAWVDNmcSJpxwWg42Qijwkhr+SDhaEnBsTyL9vVI9R+1xtU4SGwNqJyIMoK2pxDnXF A29tZu3A7skoXvQxJ9WtSb7QIxHRU2b13FInKfiGLxcWcmruSfgKcNHaY0YkacVkB2u9 WhYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=P1ME/zT3CRkmnM3Con/86VC1CQUr6vWo2bXKpYvMlx0LfA3MREpHNct7thIaXp8UHG aPpCewJRmyvBvNWbgQ+jSMf6Ej4VH+ntD45x4jReJA836hY1AcByBougiM2yW2EiCQ4d zDXHzxnmb7ZgGBnqoX4fMQ7L0CzjRfV5OGU+Z1Mjeinsa+blsbgOfASdFZ7YUGSEoEJA kFolS9+welFKib65RC7lSA54jmGtp85lKJzKBgbdV4jMcHcnSASxfJLuIZCu3oCoyRMI uouxGB7MvRij+L6aDqOhsOsMSFVontWA9VwjWBZhiSuqkQFlNnA35d/G4reG/96zTd0S mZ4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BCSrFSm9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x4-20020a170902ec8400b001947e1a94d5si16532163plg.575.2023.02.14.09.21.47; Tue, 14 Feb 2023 09:22:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BCSrFSm9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233023AbjBNRQP (ORCPT + 99 others); Tue, 14 Feb 2023 12:16:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232221AbjBNRPR (ORCPT ); Tue, 14 Feb 2023 12:15:17 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADEA12BF23 for ; Tue, 14 Feb 2023 09:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=BCSrFSm9m4vCFf6Z47aB/J5gIS1hhLR9Jora5YI3jbQWFJxTF6Dk9i7xJS2VU7WmjNZILq HHtLpHmi6534FdaMK1rjGeqt2Yd+EDp+u5sbZehD45CDaUGyULi/wh6owDjNebyE37s8a4 WeQMySuKgnsoqnNVSu4XO97LQGV267A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-DQOy9zFmOZSICpQlPKxSDw-1; Tue, 14 Feb 2023 12:14:20 -0500 X-MC-Unique: DQOy9zFmOZSICpQlPKxSDw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE7998027EB; Tue, 14 Feb 2023 17:14:18 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 179BC2026D4B; Tue, 14 Feb 2023 17:14:16 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard Subject: [PATCH v14 12/17] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Tue, 14 Feb 2023 17:13:25 +0000 Message-Id: <20230214171330.2722188-13-dhowells@redhat.com> In-Reply-To: <20230214171330.2722188-1-dhowells@redhat.com> References: <20230214171330.2722188-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757827899769844424?= X-GMAIL-MSGID: =?utf-8?q?1757827899769844424?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard cc: Al Viro cc: David Hildenbrand cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }