Message ID | 20230214141428.301121-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3004754wrn; Tue, 14 Feb 2023 06:27:48 -0800 (PST) X-Google-Smtp-Source: AK7set8k8FqctdDg3LIxPQVVoJnoClyZ17XpxN2lC0ZFxhH7uFZ7m9nLmvEWvISnR2e3GC8q7Q17 X-Received: by 2002:a50:d498:0:b0:4aa:a39f:65af with SMTP id s24-20020a50d498000000b004aaa39f65afmr2876288edi.42.1676384868671; Tue, 14 Feb 2023 06:27:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676384868; cv=none; d=google.com; s=arc-20160816; b=aKqzQ6tjwxJcHevUoZoZxPO7TQF1ps8vpaJN5xiBKAIykbaseYJe680uYnC6V228Ir pxAI2ABcmvElPYJ3quGC9287sqxqXJF5s1zbPvj+64ODnKFzO7fBSH6KDo8YwY3YT7QQ 9K5lNaxxKtvllgSPwkpnXVXquBLdEC72/xd4TQo5ibomF/iCpIvfCHgPmFIUOmNLSk59 3TAsyzuVxKvX6ih4izhulYtLpoWmvw3JAfx4u2KCqayW+PzRHc97L3fopCJjdrXwj8Ug S/mFL5pWBoSZ35vYlhyMdvoeWBhBD0ZLGsD9WuFq3Raa66w6t+DDpJ2s4lR6YrzpSjaZ jMug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fN0HsQBeTzPwMed5PupJcQefwKI7QfP4v9v/v9W2LxI=; b=dk6zE/j93mH2gBH5rt0raBawWOBiWZnvZOsgYokxGMFLOGWfWyP5LBdgHfpN2OSfJZ e/HpBdWZ9RwsiHq6yzU4MXYD+3cwa9DRWVBWn3BJgm0zy7XRO2bbOQJHeZXirnR1qd9B XO3CUnGs4Hai0y9F9xtwaoaqE9owMukYIJsSToi9o83jZ50JeusDFvZ6TPq8bTXPIo8Q 6DreB/4+5EUT1/SeayJFEpPOMYLIwLZaV7C5MNpjf+j3tLCJHpTDYLqB6NX4iIJFlpMZ xMa9vnOIhyjy1IcukKcFitByN07EaCJ9aFx9+d3OdexKg6hnSOoQlnEuyWDhkaG7QIxx Mrmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UFaRySGi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f26-20020a056402151a00b004acd22dcc07si4126043edw.212.2023.02.14.06.27.25; Tue, 14 Feb 2023 06:27:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UFaRySGi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbjBNOPs (ORCPT <rfc822;tebrre53rla2o@gmail.com> + 99 others); Tue, 14 Feb 2023 09:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232609AbjBNOPl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 14 Feb 2023 09:15:41 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31E41526B; Tue, 14 Feb 2023 06:15:13 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id hg24-20020a05600c539800b003e1f5f2a29cso1322522wmb.4; Tue, 14 Feb 2023 06:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fN0HsQBeTzPwMed5PupJcQefwKI7QfP4v9v/v9W2LxI=; b=UFaRySGiv/0XDhI+9JMU/apFJCQZZUwpHqeYYYfKT6uFj0y4cNTT2ahKjCtWHWnknt 8SlXyNDZRVpNjivo8F7Z3BI7mdJ7IKfhvNtYuElpfa+zvH75OyD6uXWa7da2pvmcCJkx Mojc94U7XVWwqjzaSFOmGcoZ8bNXB4gNWCXC6Xj+SGE5dS7RTkAvJljvIbIDXunVkHWT QLsXNOozZgq+r+T3nhGg/pPKX1kmtr5KTmpqBusl6RdefCYc00Gw2sKUng+tMxTzmolk eEo6b3i87GEq6jDtbYDyIj2XohOLo0kT2//narlDGgT3jDNlzM5abkHlEJ1qOqKf52wa F1rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fN0HsQBeTzPwMed5PupJcQefwKI7QfP4v9v/v9W2LxI=; b=PnJmLejpwpFMQwlheCa1nkjlgmNgYo1/Sz2GYYOwGwehtMCstNcu0RWzUjJWTpVFT1 OTj3draNm58PMRRX/z3y6N9ICCubbJ1/uFalcwk2ESI1cIekL5qrPGHh5RWY57MWRzw3 53fFSrYbbHPjEktuyh3rPXyi7WPuH6oveVz+k2KdbjJNdBJtPlh4vxp9o02PAN0Qgh1A SDvVE4Or0bRVnilIvy6krqI41EFsgGE5RZD/vh0/BtgLfJfr1Z9GAojmQ7BNHWATWsED /m8pIWPA3MrGQKl4hjAXOaa+m19W+MsgMz1PT5ewp/kls6h0D9b52sfQjJQAl/XoFVx3 WZRw== X-Gm-Message-State: AO0yUKUfXVkUZti57rF7AAvXfVnhspbTatLS4Bjfb1Y9cEYlX3xtKTuy jICWnvdSG3JnxEO3Wv19uWU04cFoEWsF4XP2 X-Received: by 2002:a05:600c:4927:b0:3df:f2a5:49fb with SMTP id f39-20020a05600c492700b003dff2a549fbmr2148871wmp.7.1676384069688; Tue, 14 Feb 2023 06:14:29 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id t13-20020adfe44d000000b002c557f82e27sm5881010wrm.99.2023.02.14.06.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 06:14:29 -0800 (PST) From: Colin Ian King <colin.i.king@gmail.com> To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] nfsd: remove redundant assignment to pointer dentry Date: Tue, 14 Feb 2023 14:14:28 +0000 Message-Id: <20230214141428.301121-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757816939902185896?= X-GMAIL-MSGID: =?utf-8?q?1757816939902185896?= |
Series |
[next] nfsd: remove redundant assignment to pointer dentry
|
|
Commit Message
Colin Ian King
Feb. 14, 2023, 2:14 p.m. UTC
The pointer dentry is assigned a value that is never read, the
assignment is redundant and can be removed.
Cleans up clang-scan warning:
fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is
never read [deadcode.DeadStores]
dentry = ERR_PTR(ret);
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/nfsd/nfsctl.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Tue, Feb 14, 2023 at 02:14:28PM +0000, Colin Ian King wrote: > The pointer dentry is assigned a value that is never read, the > assignment is redundant and can be removed. > > Cleans up clang-scan warning: > fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is > never read [deadcode.DeadStores] > dentry = ERR_PTR(ret); > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> No need to initalized "int ret = -ENOMEM;" either. regards, dan carpenter
> On Feb 14, 2023, at 9:55 AM, Dan Carpenter <error27@gmail.com> wrote: > > On Tue, Feb 14, 2023 at 02:14:28PM +0000, Colin Ian King wrote: >> The pointer dentry is assigned a value that is never read, the >> assignment is redundant and can be removed. >> >> Cleans up clang-scan warning: >> fs/nfsd/nfsctl.c:1231:2: warning: Value stored to 'dentry' is >> never read [deadcode.DeadStores] >> dentry = ERR_PTR(ret); >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > No need to initalized "int ret = -ENOMEM;" either. Thanks for the report. Both came in when I copied nfsd_mkdir. I'll clean them up. -- Chuck Lever
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 04474b8ccf0a..5946064cd794 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -1228,7 +1228,6 @@ static void nfsd_symlink(struct dentry *parent, const char *name, return; out_err: dput(dentry); - dentry = ERR_PTR(ret); goto out; } #else