diff mbox series

[v2,39/47] clk: mediatek: Allow MT7622 clocks to be built as modules

Message ID 20230214134127.59273-40-angelogioacchino.delregno@collabora.com
State New
Headers
Series MediaTek clocks: full module build and cleanups |

Commit Message

AngeloGioacchino Del Regno Feb. 14, 2023, 1:41 p.m. UTC 
  Now that all drivers are using the simple probe mechanism change the
MT7622 clock drivers to tristate in Kconfig to allow module build.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/clk/mediatek/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Chen-Yu Tsai Feb. 17, 2023, 4:32 a.m. UTC | #1 
On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Now that all drivers are using the simple probe mechanism change the
> MT7622 clock drivers to tristate in Kconfig to allow module build.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  drivers/clk/mediatek/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
> index b5636b3225e8..55727889ebf5 100644
> --- a/drivers/clk/mediatek/Kconfig
> +++ b/drivers/clk/mediatek/Kconfig
> @@ -336,7 +336,7 @@ config COMMON_CLK_MT6797_VENCSYS
>           This driver supports MediaTek MT6797 vencsys clocks.
>
>  config COMMON_CLK_MT7622
> -       bool "Clock driver for MediaTek MT7622"
> +       tristate "Clock driver for MediaTek MT7622"

Same as MT2712, mt7622-apmixedsys is builtin_platform_driver.

ChenYu
Chen-Yu Tsai Feb. 17, 2023, 5:02 a.m. UTC | #2 
On Fri, Feb 17, 2023 at 12:32 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
> >
> > Now that all drivers are using the simple probe mechanism change the
> > MT7622 clock drivers to tristate in Kconfig to allow module build.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  drivers/clk/mediatek/Kconfig | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
> > index b5636b3225e8..55727889ebf5 100644
> > --- a/drivers/clk/mediatek/Kconfig
> > +++ b/drivers/clk/mediatek/Kconfig
> > @@ -336,7 +336,7 @@ config COMMON_CLK_MT6797_VENCSYS
> >           This driver supports MediaTek MT6797 vencsys clocks.
> >
> >  config COMMON_CLK_MT7622
> > -       bool "Clock driver for MediaTek MT7622"
> > +       tristate "Clock driver for MediaTek MT7622"
>
> Same as MT2712, mt7622-apmixedsys is builtin_platform_driver.

I figured it out, so

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
AngeloGioacchino Del Regno Feb. 17, 2023, 11:31 a.m. UTC | #3 
Il 17/02/23 05:32, Chen-Yu Tsai ha scritto:
> On Tue, Feb 14, 2023 at 9:42 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Now that all drivers are using the simple probe mechanism change the
>> MT7622 clock drivers to tristate in Kconfig to allow module build.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   drivers/clk/mediatek/Kconfig | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
>> index b5636b3225e8..55727889ebf5 100644
>> --- a/drivers/clk/mediatek/Kconfig
>> +++ b/drivers/clk/mediatek/Kconfig
>> @@ -336,7 +336,7 @@ config COMMON_CLK_MT6797_VENCSYS
>>            This driver supports MediaTek MT6797 vencsys clocks.
>>
>>   config COMMON_CLK_MT7622
>> -       bool "Clock driver for MediaTek MT7622"
>> +       tristate "Clock driver for MediaTek MT7622"
> 
> Same as MT2712, mt7622-apmixedsys is builtin_platform_driver.
> 
> ChenYu

Same as MT2712 - added remove callback, converted to module_platform_driver()
for v3!

Thanks again!
Angelo
diff mbox series

Patch

diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
index b5636b3225e8..55727889ebf5 100644
--- a/drivers/clk/mediatek/Kconfig
+++ b/drivers/clk/mediatek/Kconfig
@@ -336,7 +336,7 @@  config COMMON_CLK_MT6797_VENCSYS
 	  This driver supports MediaTek MT6797 vencsys clocks.
 
 config COMMON_CLK_MT7622
-	bool "Clock driver for MediaTek MT7622"
+	tristate "Clock driver for MediaTek MT7622"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
 	select COMMON_CLK_MEDIATEK
 	default ARCH_MEDIATEK
@@ -345,21 +345,21 @@  config COMMON_CLK_MT7622
 	  required for various periperals found on MediaTek.
 
 config COMMON_CLK_MT7622_ETHSYS
-	bool "Clock driver for MediaTek MT7622 ETHSYS"
+	tristate "Clock driver for MediaTek MT7622 ETHSYS"
 	depends on COMMON_CLK_MT7622
 	help
 	  This driver add support for clocks for Ethernet and SGMII
 	  required on MediaTek MT7622 SoC.
 
 config COMMON_CLK_MT7622_HIFSYS
-	bool "Clock driver for MediaTek MT7622 HIFSYS"
+	tristate "Clock driver for MediaTek MT7622 HIFSYS"
 	depends on COMMON_CLK_MT7622
 	help
 	  This driver supports MediaTek MT7622 HIFSYS clocks providing
 	  to PCI-E and USB.
 
 config COMMON_CLK_MT7622_AUDSYS
-	bool "Clock driver for MediaTek MT7622 AUDSYS"
+	tristate "Clock driver for MediaTek MT7622 AUDSYS"
 	depends on COMMON_CLK_MT7622
 	help
 	  This driver supports MediaTek MT7622 AUDSYS clocks providing