From patchwork Tue Feb 14 09:03:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 56782 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2854360wrn; Tue, 14 Feb 2023 01:07:05 -0800 (PST) X-Google-Smtp-Source: AK7set/yZ0E005F/mwU5hSwfkMm2jNTNlW6wnAtNDHebdVya1o+DKovlr+3XZmVs/vm60lGk4lj1 X-Received: by 2002:a17:906:d9dd:b0:878:72f7:bd99 with SMTP id qk29-20020a170906d9dd00b0087872f7bd99mr1958795ejb.6.1676365625695; Tue, 14 Feb 2023 01:07:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676365625; cv=none; d=google.com; s=arc-20160816; b=i/YiewQu9MLjCoK2IPMHXvYrgyAYJ0HEMvpj4yG32vWfKc2c39iyHEeEMU6xrmaiXM qUGyF+c4tVHFQ8bRejxOqMj5XXTjuk09+JCSoIkh2s/mkbFJ4+shVNaov3ycel2tugh2 lUGdmJcek/mrzoGygVOWoyXCjFDWnCTdwhhen5plrcKzztui1oenStc89WxCWJqTuYKA /085kBZx0BjXt/CfZNZY8Do57QGiQk7ZnCncD9bXkwNiuv2DMgRnFpsR1BlANH59gnXu Z8T6Z745HQ6otIkbeXIldWQ40F8sE+0jaOJ3ax+B0RXjEJN62qnvLKqvvxLUnF4GQBnk PWgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rbmh5yUNjpZV6g1TXnEwaMyJAXwP5cdXeNM56svkGzc=; b=Ca3O+sSVw+9ivANO6kCRvbl3qJmuSy4f7ZL3Mm2Pc6yY5JzMRkMMlJL6siNiqmw4vI ubT0sG7B45dYLPe/IkKPTxmJpoxyYcL9gOynJeeE7H2s2RXCKUtkVlRhTVu5jlRLDHl8 90d7Cqq5fUbCmgKaz+k+lebEDq7xN9zaArgg0IT/E8CSJAfjAPd/n8PpSW/iCmJPRWuv BaRhi+/UyAL7IEQnnC07qiqrS+m1LIWY992zTG2sPcmKOXtbphlplLynQ5orQjOAKm7b +fVEp0+8FBG9eyIRLMkxQpJuyBNEwp3rQ5P9+FBKxcPIk5SLWPO5rDF86I/Tmqqz5mhl 6MPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 22-20020a170906025600b008777ae12842si10110936ejl.53.2023.02.14.01.06.42; Tue, 14 Feb 2023 01:07:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231899AbjBNJEB (ORCPT + 99 others); Tue, 14 Feb 2023 04:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbjBNJD3 (ORCPT ); Tue, 14 Feb 2023 04:03:29 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4576BD505 for ; Tue, 14 Feb 2023 01:03:26 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRrDa-0004UG-JN; Tue, 14 Feb 2023 10:03:18 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pRrDY-004qDm-G1; Tue, 14 Feb 2023 10:03:17 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pRrDX-008V6W-Js; Tue, 14 Feb 2023 10:03:15 +0100 From: Oleksij Rempel To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Shenwei Wang , Clark Wang , NXP Linux Team Subject: [PATCH net-next v1 7/7] net: fec: add support for PHYs with SmartEEE support Date: Tue, 14 Feb 2023 10:03:14 +0100 Message-Id: <20230214090314.2026067-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230214090314.2026067-1-o.rempel@pengutronix.de> References: <20230214090314.2026067-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757796762002274078?= X-GMAIL-MSGID: =?utf-8?q?1757796762002274078?= Ethernet controller in i.MX6*/i.MX7* series do not provide EEE support. But this chips are used sometimes in combinations with SmartEEE capable PHYs. So, instead of aborting get/set_eee access on MACs without EEE support, ask PHY if it is able to do the EEE job by using SmartEEE. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/freescale/fec_main.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index c73e25f8995e..00f3703db69d 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3102,8 +3102,15 @@ fec_enet_get_eee(struct net_device *ndev, struct ethtool_eee *edata) struct fec_enet_private *fep = netdev_priv(ndev); struct ethtool_eee *p = &fep->eee; - if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) - return -EOPNOTSUPP; + if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) { + if (!netif_running(ndev)) + return -ENETDOWN; + + if (!phy_has_smarteee(ndev->phydev)) + return -EOPNOTSUPP; + + return phy_ethtool_get_eee(ndev->phydev, edata); + } if (!netif_running(ndev)) return -ENETDOWN; @@ -3123,8 +3130,15 @@ fec_enet_set_eee(struct net_device *ndev, struct ethtool_eee *edata) struct ethtool_eee *p = &fep->eee; int ret = 0; - if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) - return -EOPNOTSUPP; + if (!(fep->quirks & FEC_QUIRK_HAS_EEE)) { + if (!netif_running(ndev)) + return -ENETDOWN; + + if (!phy_has_smarteee(ndev->phydev)) + return -EOPNOTSUPP; + + return phy_ethtool_set_eee(ndev->phydev, edata); + } if (!netif_running(ndev)) return -ENETDOWN;