| Message ID | 20230214084206.1412423-1-horatiu.vultur@microchip.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2847242wrn;
Tue, 14 Feb 2023 00:48:16 -0800 (PST)
X-Google-Smtp-Source:
AK7set999yLWENURVLaxIysiLS0VJ4Dtbn7dfYOgiFTB7q5hF+YGbeyHbmW1B/xZhJM/4qbz8RyL
X-Received: by 2002:a50:9518:0:b0:4ac:b4f3:b8a7 with SMTP id
u24-20020a509518000000b004acb4f3b8a7mr1564692eda.7.1676364496677;
Tue, 14 Feb 2023 00:48:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676364496; cv=none;
d=google.com; s=arc-20160816;
b=nFf6ymWLpqnmPXr37am5gvN70MYIGTSTq7i66SyQl6dz0P8ZqocPcttsr4YYslA8Oq
TEidwllIaSu3TmwmaAbDG2zpJdugDtFu/hV5Zfk7ym8IOa5zCZKfMGUwRwA7QyGw66OI
AFAOdvHDzocqJvFlF0re5igTBnK/MZquep//hyffojYvGckIgG/RV+vXa6qpzM674G6w
jAifI34t+Jm7+oBAR3zokYslWrgssDSxV9YFuhIOhnImNU2lDn9h4SrfErzpM5oMGkGc
9TDOSj90X9Tci29rMCJqfnMGwWuFibxduydmFG72TQbsf8Xl/vctQE5fu0zqdvE8q8uv
tWoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=sxe12cKY+i1yTpV1t8pVUXpckCkK4RCrm7cZ4U4IgDM=;
b=pw8CWu+2/d0kmX4G5HTRTDBYTjh1ArPHyQWQaIoELBn9K9RfeBA2CpyR/SG03tZq4p
Unfv1OaGiJ5ug5OgLoJXpjBTHjM+5gA6mSH3skZPuhv1tKuI7KmN2YQZEgHMWqRn8lqK
VwGGtF/60TXnydvwcON9ZpoxdJGcnluSWQxiR7qh56Upt/MolWkh9a9z9ocudv0/+csl
t2+ievO3ELULYEyO2mgaEDgy59wYemfWP70NaJn3D48ZhG/RkhhOc9tT9nspPVil4TB4
NmbSJriwHpYPbJVWw/V4eCMHCPq1W4XUiauZgRk2NtR+KHkZJuKDhSJLNe2DhN3TQsaj
Ivbw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@microchip.com header.s=mchp header.b=y6BkbzCo;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=microchip.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e12-20020aa7d7cc000000b004accb738c55si4897846eds.443.2023.02.14.00.47.53;
Tue, 14 Feb 2023 00:48:16 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@microchip.com header.s=mchp header.b=y6BkbzCo;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=microchip.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230263AbjBNIn2 (ORCPT <rfc822;henrikjoshmiranda3@gmail.com>
+ 99 others); Tue, 14 Feb 2023 03:43:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47748 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229609AbjBNIn1 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 14 Feb 2023 03:43:27 -0500
Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com
[68.232.154.123])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1FC6CDD6;
Tue, 14 Feb 2023 00:43:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp;
t=1676364207; x=1707900207;
h=from:to:cc:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=BXIr4+VIWq9cUCsuzL+i/vlpdZv710csS/iIfxVyaMQ=;
b=y6BkbzCorruBLp4rdSyTOFz7wNVQ27MrL4QDDBDTjW3ypa8oau3/uQrW
4qPSoEh6JMzSv4oxQjAeOSgMjx9wx/tIZ/LISVNOo/YLvSLBIHIRospDL
yAHwol6hD8x3tK/43Rdx5YHpVLYWEaJun0nkeoNpJuCUHpafdAjyh43W7
bHikOUZiQVJ3nytYgZtc78wlLhQ+aN5EvJnCH8ArQAIancjoGy1n2tdVL
xP8P4UPrV05hZ/Cq/aM2l1yswIIT4EkQYxXq/Lk2zVXIlzwZFCDo4n7M/
36CAcp+/Md7iU9YRy0yROE5vPtXS1yy674zcksKXXbSZSn3vzTNeYwKcq
Q==;
X-IronPort-AV: E=Sophos;i="5.97,296,1669100400";
d="scan'208";a="196806006"
Received: from unknown (HELO email.microchip.com) ([170.129.1.10])
by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256;
14 Feb 2023 01:43:26 -0700
Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by
chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.16; Tue, 14 Feb 2023 01:43:24 -0700
Received: from soft-dev3-1.microsemi.net (10.10.115.15) by
chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id
15.1.2507.16 via Frontend Transport; Tue, 14 Feb 2023 01:43:22 -0700
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <UNGLinuxDriver@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: [PATCH net-next] net: lan966x: Use automatic selection of VCAP rule
actionset
Date: Tue, 14 Feb 2023 09:42:06 +0100
Message-ID: <20230214084206.1412423-1-horatiu.vultur@microchip.com>
X-Mailer: git-send-email 2.38.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757795578239050233?=
X-GMAIL-MSGID: =?utf-8?q?1757795578239050233?=
|
| Series |
[net-next] net: lan966x: Use automatic selection of VCAP rule actionset
|
|
Commit Message
Horatiu Vultur
Feb. 14, 2023, 8:42 a.m. UTC
Now the VCAP API automatically selects the action set, therefore is
not needed to be hardcoded anymore to hardcode the action in the
lan966x. Therefore remove this.
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c | 2 --
1 file changed, 2 deletions(-)
Comments
On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote: > Now the VCAP API automatically selects the action set, therefore is > not needed to be hardcoded anymore to hardcode the action in the > lan966x. Therefore remove this. The commit message needs some attention here. While at it - instead of saying "now" could you provide the commit reference? E.g. "Since commit $hash ("$title") the VCAP API...".
The 02/15/2023 21:30, Jakub Kicinski wrote: Hi Jakub, > > On Tue, 14 Feb 2023 09:42:06 +0100 Horatiu Vultur wrote: > > Now the VCAP API automatically selects the action set, therefore is > > not needed to be hardcoded anymore to hardcode the action in the > > lan966x. Therefore remove this. > > The commit message needs some attention here. > While at it - instead of saying "now" could you provide the commit > reference? E.g. "Since commit $hash ("$title") the VCAP API...". I will update this in the next version. Thanks for the feedback!
diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c index bd10a71897418..f960727ecaeec 100644 --- a/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_tc_flower.c @@ -261,8 +261,6 @@ static int lan966x_tc_flower_add(struct lan966x_port *port, 0); err |= vcap_rule_add_action_u32(vrule, VCAP_AF_MASK_MODE, LAN966X_PMM_REPLACE); - err |= vcap_set_rule_set_actionset(vrule, - VCAP_AFS_BASE_TYPE); if (err) goto out;