[2/3] dt-bindings: power: supply: pm8941-coincell: Don't require charging properties
| Message ID | 20230213204950.2100538-2-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2568704wrn;
Mon, 13 Feb 2023 12:52:58 -0800 (PST)
X-Google-Smtp-Source:
AK7set+NWGgvm/sylAEx73hzb6Kkv4EJPNuoYANP+dWmfeWahANfsKtjRVtlFUHOCAoLDnsOr5Ml
X-Received: by 2002:a17:906:9495:b0:87c:c2eb:6dfb with SMTP id
t21-20020a170906949500b0087cc2eb6dfbmr281831ejx.29.1676321578198;
Mon, 13 Feb 2023 12:52:58 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676321578; cv=none;
d=google.com; s=arc-20160816;
b=Z7h4YTJCs07D2hoZodHuHHTDR0XXYrSZYSy3dXxCg4yD4BXi3xXXOaBbXjYXP5pmKz
Na94RAD5ZTPKLonmGALxlEdrVxNBIlefTu9MemzfH3+TDG3IvZUaoYUyMxeDEgH+ZBwW
mvhW55sZhV2ABt5hwVV3Rc6QZWtLQFHz1H7HUzeUjtf3T44QzBuMZ8UtkfazDrbSAZVQ
F2NfcfWT/Neue0AgkVmKhorLI6vowRC18dPhlXPw905lb29PtqLqx+h8Dkme8RAvKJaB
EzqarCe/waqYdtl0KrM3hm8915N+ZhTGUm6doiK1fMzCREaD2PDkFkUhYSsiysVIrgC5
hm+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=imnGfa1cPwcrAF1LbWbmEFRL7Cg9qGkZV/LdJAwktJE=;
b=I0ZoRHJMdd5f9ZPMdAxPPl5tCGqZT3QC0Znxs7Oc6kKUeatLUOTTp+K9mSM8QUsmwN
szKGauhiIegcJ4E6PSTxrp11xYYTWRJdSTZKiVpYzDhQVlPYzczx3CVZfH51EAvQqs4+
iUrAcw2HrDInLpIf8x37UsNF1ifHLgFgOwacm2fCute4loNe4V+Jm3nTB2k+GCQ1a3O/
dsoM88CSVrnsNZA7wHs4ZQ983ExNizeRqOXWiFlh2t/kK9E6AEDXzF/1C7USr6TOg6de
fzqVjWhi5eBc/4h2nGr7unLVbgR+SMwP8lXev+QzJcHbR+qk6SNA5pT8A860kDBo6Lyv
LLBg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=lY7kjkDD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ew9-20020a170907950900b008911a148550si12265628ejc.284.2023.02.13.12.52.34;
Mon, 13 Feb 2023 12:52:58 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=lY7kjkDD;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229932AbjBMUuH (ORCPT <rfc822;tebrre53rla2o@gmail.com>
+ 99 others); Mon, 13 Feb 2023 15:50:07 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42896 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229787AbjBMUuE (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 13 Feb 2023 15:50:04 -0500
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com
[IPv6:2a00:1450:4864:20::62c])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A98A1F905
for <linux-kernel@vger.kernel.org>;
Mon, 13 Feb 2023 12:50:02 -0800 (PST)
Received: by mail-ej1-x62c.google.com with SMTP id sa10so34928344ejc.9
for <linux-kernel@vger.kernel.org>;
Mon, 13 Feb 2023 12:50:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=imnGfa1cPwcrAF1LbWbmEFRL7Cg9qGkZV/LdJAwktJE=;
b=lY7kjkDDVPHYQJm2Cg3M+TbXaZTBvmZyCRyvU1aMuvl7cg6zcGWrBJwgATRMB3bhnq
MbHNF7S0L2ZehFpkPYVZPc8F2x685CECLmPaq1sz1o41HFCyV2uxcitOcCPKUyu/gi9+
K2IG9dGcuIC2535IDzys6DYswvi4z/YuoMj/bvqpESvkIH0j9Lfw6QRgikUbyvroiqQK
vQ8uTsRu/j3hmez1CRGEdj5rk2ctQWDkdKMtJoZhav5daLJHouq50HDgC/JrL+QQgwVR
4XztIoCD1Pl43/4tBeRg943lpPga6x+b13w+Gl2Za2SYle8cN9/VKkE/hvm/XsSsvEfx
oW1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=imnGfa1cPwcrAF1LbWbmEFRL7Cg9qGkZV/LdJAwktJE=;
b=GBk11lTqw727RHBOgUD6CU1kPqff282KW0Uzg/pzvA6btHWJVtjcEgDoy3pb66mS37
RXU4a9YXfD9D5arbMdxzsQ0vqvDMd3EQE/Zavdi4Fk/3W0IBxa1enWvbQo8hZjeCEhC+
gtxA54O/P+i39+WOh5NIPwpyPUqQWh99u9Lpz6woYt0tSIZA78KY4YJdEdhrT5IYPNzh
RcCAS7gMR1U1GOKDeyJedmiqwqmOeVOcWbsgbzvI79hZ8cwteNjaeqM0OIWc2pUxOeb9
7QkPKER6xR6o2Go9idVrKFrGugM8/78JEk/RlD2PLJ830kKUKePjVNsqorUlB23Ri3xg
UzgQ==
X-Gm-Message-State: AO0yUKVIDAh7RhiMaHClB7lrwD5Ez5HY9TWhzN0yOgIgSfgnH4NMqQ+S
bgOo3CdioW3Ap/KR/s1wGiy9JQ==
X-Received: by 2002:a17:906:53d4:b0:878:5d46:9ed2 with SMTP id
p20-20020a17090653d400b008785d469ed2mr251326ejo.39.1676321401102;
Mon, 13 Feb 2023 12:50:01 -0800 (PST)
Received: from localhost.localdomain (abxh117.neoplus.adsl.tpnet.pl.
[83.9.1.117])
by smtp.gmail.com with ESMTPSA id
f21-20020a170906739500b008a94f69a1e7sm7303123ejl.163.2023.02.13.12.49.59
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 13 Feb 2023 12:50:00 -0800 (PST)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, krzysztof.kozlowski@linaro.org
Cc: marijn.suijten@somainline.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] dt-bindings: power: supply: pm8941-coincell: Don't
require charging properties
Date: Mon, 13 Feb 2023 21:49:49 +0100
Message-Id: <20230213204950.2100538-2-konrad.dybcio@linaro.org>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230213204950.2100538-1-konrad.dybcio@linaro.org>
References: <20230213204950.2100538-1-konrad.dybcio@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757750575021426089?=
X-GMAIL-MSGID: =?utf-8?q?1757750575021426089?=
|
| Series |
[1/3] dt-bindings: power: supply: pm8941-coincell: Add PM8998 compatible
|
|
Commit Message
Konrad Dybcio
Feb. 13, 2023, 8:49 p.m. UTC
It's fine for these properties to be absent, as the driver doesn't fail
without them and functions with settings inherited from the reset/previous
stage bootloader state.
Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 --
1 file changed, 2 deletions(-)
Comments
Hi, On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote: > It's fine for these properties to be absent, as the driver doesn't fail > without them and functions with settings inherited from the reset/previous > stage bootloader state. > > Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Please update the description of these properties to describe the default behaviour. -- Sebastian > .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml > index b7b58aed3f3c..d62e3af55560 100644 > --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml > +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml > @@ -43,8 +43,6 @@ properties: > required: > - compatible > - reg > - - qcom,rset-ohms > - - qcom,vset-millivolts > > additionalProperties: false > > -- > 2.39.1 >
On 13.02.2023 22:27, Sebastian Reichel wrote: > Hi, > > On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote: >> It's fine for these properties to be absent, as the driver doesn't fail >> without them and functions with settings inherited from the reset/previous >> stage bootloader state. >> >> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- > > Please update the description of these properties to describe the > default behaviour. Not sure if there's any default behavior other than "go with whatever was there previously, no matter how it got there". Is it okay if I just add: "If unspecified, inherit the bootloader configuration" ? Konrad > > -- Sebastian > >> .../devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml >> index b7b58aed3f3c..d62e3af55560 100644 >> --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml >> +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml >> @@ -43,8 +43,6 @@ properties: >> required: >> - compatible >> - reg >> - - qcom,rset-ohms >> - - qcom,vset-millivolts >> >> additionalProperties: false >> >> -- >> 2.39.1 >>
Hi, On Mon, Feb 13, 2023 at 10:41:10PM +0100, Konrad Dybcio wrote: > On 13.02.2023 22:27, Sebastian Reichel wrote: > > On Mon, Feb 13, 2023 at 09:49:49PM +0100, Konrad Dybcio wrote: > >> It's fine for these properties to be absent, as the driver doesn't fail > >> without them and functions with settings inherited from the reset/previous > >> stage bootloader state. > >> > >> Fixes: 6c463222a21d ("dt-bindings: power: supply: pm8941-coincell: Convert to DT schema format") > >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > >> --- > > Please update the description of these properties to describe the > > default behaviour. > Not sure if there's any default behavior other than "go with > whatever was there previously, no matter how it got there". I got that from the patch description, but that behaviour should be described in the binding. > Is it okay if I just add: > > "If unspecified, inherit the bootloader configuration" Technically the bindings are also for bootloaders. I suggest: If unspecified, inherit the previous configuration (e.g. from bootloader or hardware default value). -- Sebastian
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml index b7b58aed3f3c..d62e3af55560 100644 --- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml +++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-coincell.yaml @@ -43,8 +43,6 @@ properties: required: - compatible - reg - - qcom,rset-ohms - - qcom,vset-millivolts additionalProperties: false