From patchwork Mon Feb 13 15:58:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frieder Schrempf X-Patchwork-Id: 56359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2423740wrn; Mon, 13 Feb 2023 08:01:19 -0800 (PST) X-Google-Smtp-Source: AK7set+rmYq74arjgDC/TT8afm+vroF7HoUFP1MXN8W+vvK47FoY7HTZrSZFyAauzDpvllUsLw/5 X-Received: by 2002:a05:6a20:3d90:b0:be:da0c:fc62 with SMTP id s16-20020a056a203d9000b000beda0cfc62mr34580178pzi.38.1676304079626; Mon, 13 Feb 2023 08:01:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676304079; cv=none; d=google.com; s=arc-20160816; b=RwIODV+J8ALua1EXwMvmj3EoBtfrzKTo5DjnI0EJ3Wj+uo+Aozm/Km4tKiEEZB4hQv 5NFL8A6W4eEskcPVXz6GYHEkCCNP7Ek2h1GyrrAu2Kk0KlzNa8gZ1gxNUwXehz4Z8FjD UPW16JndnIODrBqcAI8IGO/M0VNdCcqRyY9mNkwQMIm6ddnWIWjzCoVTwMmuJDSMXkyW vX3xzMLiOMowo3UOe2tDQAZXSVkjvh5DR20m7SEy/ehpWVcDr8WONP8CdLCMHBCBcXti YxbTLrbYQQRzmd5g76AOLeLrS+lemR9feIlGnpS3ovTlpHmdt/4MacMMa4nWVrbG6O7Y pshw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ewI3/QSFAFiKru2ko/nlJ095/aScxxTskV5+d8BLT6c=; b=yv5KfpSo/ogzNQZ1mRNxZ64rDhnjwcf9MJcxvYWt4s6jaRgBGcWCLeMYbEXSy0vJlu tsAe1TWgUlpROd8wcrb9FcgA1tpSNmM2dJwmBIpVFPPkk/rE5r/vGT0JyHB7rxuIuAb0 noKh88i1ugGkDw+wwdAJVkViCkGM3SLj0GJwJigg2u4C5K0ZHb72OyolZ8radL9+JTNu 1ELK0kebz564HYCulhsttF1NRVZXbV+GNS14vHcJhIPbNDeWVOCQ3yYhQqhwnVuouIab /MmVvQplBZm/9RXI+pqnOeuNmKkvkWjzUerD+YWHJQIf/m+HrIYqrHB35KPFPEYuJCzB LxRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=MkxlcLA5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t64-20020a637843000000b004fb33c7c866si11590313pgc.225.2023.02.13.08.01.06; Mon, 13 Feb 2023 08:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=MkxlcLA5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231340AbjBMQAC (ORCPT + 99 others); Mon, 13 Feb 2023 11:00:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231377AbjBMP7y (ORCPT ); Mon, 13 Feb 2023 10:59:54 -0500 Received: from mail.fris.de (mail.fris.de [116.203.77.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3061B170B for ; Mon, 13 Feb 2023 07:59:53 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 62C89C02BC; Mon, 13 Feb 2023 16:59:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1676303991; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=ewI3/QSFAFiKru2ko/nlJ095/aScxxTskV5+d8BLT6c=; b=MkxlcLA52COrYKwd2SoBvgutpxQZJImOoLVAkw9FeZ0nceRbak4lumMdpIsJWoWID4tQRy hXWpOQsrdLwCpl6poVxqDhir0lWNz+xjFxc+tiVvZIKLci6ydHnApMYS2+PvXWL076oQoF 9PXOo4LXv3qKFGSpwp00Up0AGN+l52Gj0j9BeCYNS3261Ixeeh9F5jUZMICnG+6nm8EXrN F9HcpKZYsherzW3CZcwXkhAZQGwsEa6F72qeP4N+qIhTQFAK5SUDmjsgoqqQBE3WQdvrWF onBq0yzO+ykz3kQC+lggNTL5DTqfHpbx72fqzWH3cLOsXV7ttWhy49Bdv2VTqQ== From: Frieder Schrempf To: Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown Cc: Marek Vasut , Frieder Schrempf , Per-Daniel Olsson , Rickard x Andersson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Subject: [PATCH 3/6] Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5" Date: Mon, 13 Feb 2023 16:58:21 +0100 Message-Id: <20230213155833.1644366-4-frieder@fris.de> In-Reply-To: <20230213155833.1644366-1-frieder@fris.de> References: <20230213155833.1644366-1-frieder@fris.de> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757732226578607463?= X-GMAIL-MSGID: =?utf-8?q?1757732226578607463?= From: Frieder Schrempf This reverts commit 8c67a11bae889f51fe5054364c3c789dfae3ad73. It turns out that all boards using the PCA9450 actually have the SD_VSEL input conencted to the VSELECT signal of the SoCs SD/MMC interface. Therefore we don't need manual control for this signal via GPIO and threre aren't any users. Signed-off-by: Frieder Schrempf --- drivers/regulator/pca9450-regulator.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c index a815666566b5..804a22c0e376 100644 --- a/drivers/regulator/pca9450-regulator.c +++ b/drivers/regulator/pca9450-regulator.c @@ -5,7 +5,6 @@ */ #include -#include #include #include #include @@ -33,7 +32,6 @@ struct pca9450_regulator_desc { struct pca9450 { struct device *dev; struct regmap *regmap; - struct gpio_desc *sd_vsel_gpio; enum pca9450_chip_type type; unsigned int rcnt; int irq; @@ -834,18 +832,6 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) } } - /* - * The driver uses the LDO5CTRL_H register to control the LDO5 regulator. - * This is only valid if the SD_VSEL input of the PMIC is high. Let's - * check if the pin is available as GPIO and set it to high. - */ - pca9450->sd_vsel_gpio = gpiod_get_optional(pca9450->dev, "sd-vsel", GPIOD_OUT_HIGH); - - if (IS_ERR(pca9450->sd_vsel_gpio)) { - dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n"); - return PTR_ERR(pca9450->sd_vsel_gpio); - } - dev_info(&i2c->dev, "%s probed.\n", type == PCA9450_TYPE_PCA9450A ? "pca9450a" : "pca9450bc");