From patchwork Mon Feb 13 06:24:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaopeng Tan X-Patchwork-Id: 56054 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2202348wrn; Sun, 12 Feb 2023 22:37:42 -0800 (PST) X-Google-Smtp-Source: AK7set84au8eFseFtIYt31MXC1LWdl/wOkt4BnBCytvmZ4YnfACmSiF0hMc0+SeCyEk5WmM2RtDe X-Received: by 2002:a05:6a20:3cab:b0:bc:47a0:f5a9 with SMTP id b43-20020a056a203cab00b000bc47a0f5a9mr28204363pzj.16.1676270261939; Sun, 12 Feb 2023 22:37:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676270261; cv=none; d=google.com; s=arc-20160816; b=DRrKbj6GL8CRPZsxra9zApfDaiBNXDVnmvPEuNSQjJiDCg0mV3iJkIyCRChkstcfFY Wb6IfiPwc6nzwscdOngY0GSXCGHrLQLYoQJVw8Xbcjd+X9/c7PkPGKv+DCCC6Uikkf5Q koogRb91o6eD5pXE+Z2i+l2v4Hri3cCHpbPUD/5W/HbKPKob/RjYouWbjsSTYz3es23p K3wYNrhOPNW6y2KYexXJngFMBRVUQjMKHcdY0pogfWWoU2JBGGiagd80+SKPlW815yJf ePCcNnxNAgk/hupDLSSeg5iG+l+xfn+DAEjKfTqUvrS1SspnQc4Ttw5RZds4wyoXMH+j 5tJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8vB7wSoHkVQdDBEgWvv4iIcFC9Fe76TYmbSGIUh7/DA=; b=d7Zq1vjvl9nzPfdyRhHfiAmUaGHsd8x8hj1wwEAT4mkxQJNWJDo6OtasiwzUn07AZC kMWI2S1c+0cqtorlqnY2IginDeDjsb/xz77lxQegYCAP3gVuRsU8T7nORk1VyNw9rKgd vqgO49NaQwCoOmeyIR0qGiTXN147ajukqFFvTluu2byAWs0Bo6uV/qYNJXfxpGfivk6F 8cZ8wcFELS9P0BdoUcMVdN6E5AYyul8isg7+wdA5hoYVkUSU5t0j6gxswwYC/AvqMfNh rQ1oFf7IpRogRUMdiWUZUIRxPWfgc2yRYLtYzRaJImkpkU0WPsbimUqTRGXjp6OjdoHU ZJNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a29-20020aa795bd000000b0059d1764718dsi10790804pfk.133.2023.02.12.22.37.28; Sun, 12 Feb 2023 22:37:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229841AbjBMG2t (ORCPT + 99 others); Mon, 13 Feb 2023 01:28:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjBMG2n (ORCPT ); Mon, 13 Feb 2023 01:28:43 -0500 Received: from esa8.hc1455-7.c3s2.iphmx.com (esa8.hc1455-7.c3s2.iphmx.com [139.138.61.253]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EE62EB5B; Sun, 12 Feb 2023 22:28:32 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="94505871" X-IronPort-AV: E=Sophos;i="5.97,293,1669042800"; d="scan'208";a="94505871" Received: from unknown (HELO yto-r4.gw.nic.fujitsu.com) ([218.44.52.220]) by esa8.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 15:28:29 +0900 Received: from yto-m1.gw.nic.fujitsu.com (yto-nat-yto-m1.gw.nic.fujitsu.com [192.168.83.64]) by yto-r4.gw.nic.fujitsu.com (Postfix) with ESMTP id D4A85D3EA3; Mon, 13 Feb 2023 15:28:27 +0900 (JST) Received: from yto-om1.fujitsu.com (yto-om1.o.css.fujitsu.com [10.128.89.162]) by yto-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id 366ADCFBAF; Mon, 13 Feb 2023 15:28:27 +0900 (JST) Received: from cn-r05-10.example.com (n3235113.np.ts.nmh.cs.fujitsu.co.jp [10.123.235.113]) by yto-om1.fujitsu.com (Postfix) with ESMTP id 074E440418617; Mon, 13 Feb 2023 15:28:27 +0900 (JST) From: Shaopeng Tan To: Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tan.shaopeng@jp.fujitsu.com, Shuah Khan Subject: [PATCH v7 2/6] selftests/resctrl: Return MBA check result and make it to output message Date: Mon, 13 Feb 2023 15:24:24 +0900 Message-Id: <20230213062428.1721572-3-tan.shaopeng@jp.fujitsu.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com> References: <20230213062428.1721572-1-tan.shaopeng@jp.fujitsu.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757696766025504396?= X-GMAIL-MSGID: =?utf-8?q?1757696766025504396?= Since MBA check result is not returned, the MBA test result message is always output as "ok" regardless of whether the MBA check result is true or false. Make output message to be "not ok" if MBA check result is failed. Reviewed-by: Shuah Khan Reviewed-by: Reinette Chatre Signed-off-by: Shaopeng Tan --- tools/testing/selftests/resctrl/mba_test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 1a1bdb6180cf..e3a473976d74 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -51,10 +51,10 @@ static int mba_setup(int num, ...) return 0; } -static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) +static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) { int allocation, runs; - bool failed = false; + bool ret = false; ksft_print_msg("Results are displayed in (MB)\n"); /* Memory bandwidth from 100% down to 10% */ @@ -90,13 +90,15 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc); ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc); if (avg_diff_per > MAX_DIFF_PERCENT) - failed = true; + ret = true; } ksft_print_msg("%s Check schemata change using MBA\n", - failed ? "Fail:" : "Pass:"); - if (failed) + ret ? "Fail:" : "Pass:"); + if (ret) ksft_print_msg("At least one test failed\n"); + + return ret; } static int check_results(void) @@ -132,9 +134,7 @@ static int check_results(void) fclose(fp); - show_mba_info(bw_imc, bw_resc); - - return 0; + return show_mba_info(bw_imc, bw_resc); } void mba_test_cleanup(void)