From patchwork Mon Feb 13 04:15:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 56019 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2166298wrn; Sun, 12 Feb 2023 20:16:58 -0800 (PST) X-Google-Smtp-Source: AK7set8YIXl+SMP7hNa3HBqJeP+20c5fWkBRT/e9JWS7qLykdblSmrZZRwzxqess3EXwUMW2fEqc X-Received: by 2002:a17:907:a64b:b0:8af:3382:e578 with SMTP id vu11-20020a170907a64b00b008af3382e578mr15699951ejc.4.1676261818490; Sun, 12 Feb 2023 20:16:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676261818; cv=none; d=google.com; s=arc-20160816; b=sU66BlK2JpX0hQmC3fbXEZG7xtUqPlfKD396ivx/u5Q4sbe71Q46XAMMKW9vfXHymZ QA0etgHys9X8xdrftM0EytwBCGDaMbthdcwgKKr2JWFI1D95tYkZFGJrVcljWuqe9CHv 74U/Pr6bkc+fYe3diGCXpOW1dg0BEZQNAlWlE8VWfU8RIzIJRCn1c6pa+kwE8no0qHFn LEnVZlsMMUSV/9Fd2wHWirDKK6X43gBNYXHw/y+KacK7iWUpe0Kjc39UMcirSlxbP6Ox FAmxeXvv1sox7nkgtqvXsTD27ZX3fn9Vkc0vlu2V6GxmA2NSJJLq7bxd+kPGtkaEo4Jw iPJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7EM0k4yf3TlWpm0n08kPMpGLehSGSAexr0X/ND2utsk=; b=m2mgfEBtQwYRPaAwbqWwvXaJyA4/DZM9/6cZxPyj6ywsJ3ce+XDXCFK3KDx/HVEjok dWt0I3yM5uf0IersBT0NexnkPLnyrpOrv0+fqn1/s3SeB7z6yv3dBfcp8SprHUJteCdT 3mCAUiRabsF36C2iNB3FkB4AX/qkz0hZHMQnvU+Wy/2yTxodiTLcvbzJluH9pTssxOTw 9jmzAKRZTI4BhQPJMzWdmpRicXclJ14a/lXSPRvE3fBuX39sZB3H4QbEN6eGBi/0cZAy YwqwgWG8eBs6z28YDoQno5JVbmKdsJrJKN1+EWSZCQG45PX7GZY5VLsY31bDcidqyqOC n5zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=en4qp0vW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a17090602d300b008795db50bdcsi14069201ejk.934.2023.02.12.20.16.35; Sun, 12 Feb 2023 20:16:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=en4qp0vW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjBMEPx (ORCPT + 99 others); Sun, 12 Feb 2023 23:15:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7C8BE396 for ; Sun, 12 Feb 2023 20:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7EM0k4yf3TlWpm0n08kPMpGLehSGSAexr0X/ND2utsk=; b=en4qp0vWpgwjNqCR4CxWOb5O7G m5x0DwxA7IbG+ddJ/QOh/85G88XNLlR9Cb/RtIK1YxZuCRRBmnrQtvsGD9vc+fWi7xBC573DGBt6I BiUwLHQ/Dx/Y0wFBwOo+FQH5HD+q51PFy71EgWqddTqm7zHfY8Pk4biBDm4LVuHq+pxZSYE0jUpvB L1Rhfk3Z4v8YQ2q5qH7p/gbRn4ws3BV56G5mGd9eH8phgTi0rioI9hNAnDKvsr7NmgGlQyZ1i2dRf hoPwjpt3KJ+iO+13Ij6VUwtORq4vLxgfLOSAvWs0TXtznk65QDW4Gv7+P0vzURUqELBs7Dnt5VdZd nmqgFyDw==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFg-00D56G-7N; Mon, 13 Feb 2023 04:15:40 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Geert Uytterhoeven , Rob Herring , Marc Zyngier , Arnd Bergmann , Philipp Zabel , Peter Rosin Subject: [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:34 -0800 Message-Id: <20230213041535.12083-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757687912935185449?= X-GMAIL-MSGID: =?utf-8?q?1757687912935185449?= IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change OF_IRQ's use of "depends on" to "select". This patch reduces one Kconfig circular dependency in drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP, which that driver needs (but does not completely resolve that issue). [1] [1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/ Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN") Signed-off-by: Randy Dunlap Cc: Geert Uytterhoeven Cc: Rob Herring Cc: Marc Zyngier Cc: Arnd Bergmann Cc: Philipp Zabel Cc: Peter Rosin --- I have a similar patch (should be a series) for REGMAP. drivers/of/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -68,7 +68,8 @@ config OF_ADDRESS config OF_IRQ def_bool y - depends on !SPARC && IRQ_DOMAIN + depends on !SPARC + select IRQ_DOMAIN config OF_RESERVED_MEM def_bool OF_EARLY_FLATTREE