diff mbox series

[2/2] dt-bindings: arm: sti: add sti boards and remove stih415/stih416

Message ID 20230211210500.9919-2-avolmat@me.com
State New
Headers
Series [1/2] dt-bindings: arm: sti: addition of STi platform syscon |

Commit Message

Alain Volmat Feb. 11, 2023, 9:04 p.m. UTC 
  Add bindings for STi platform boards and remove stih415/stih416 items.
This commit also moves the sti.yaml binding file within the arm/sti/
folder instead of arm/

Signed-off-by: Alain Volmat <avolmat@me.com>
---
 .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
 .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 26 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml

Comments

Krzysztof Kozlowski Feb. 12, 2023, 4:02 p.m. UTC | #1 
On 11/02/2023 22:04, Alain Volmat wrote:
> Add bindings for STi platform boards and remove stih415/stih416 items.
> This commit also moves the sti.yaml binding file within the arm/sti/
> folder instead of arm/
> 
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
>  .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
>  .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
>  2 files changed, 33 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
> deleted file mode 100644
> index 3ca054c64377..000000000000
> --- a/Documentation/devicetree/bindings/arm/sti.yaml
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/arm/sti.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: ST STi Platforms
> -
> -maintainers:
> -  - Patrice Chotard <patrice.chotard@foss.st.com>
> -
> -properties:
> -  $nodename:
> -    const: '/'
> -  compatible:
> -    items:
> -      - enum:
> -          - st,stih415
> -          - st,stih416
> -          - st,stih407
> -          - st,stih410
> -          - st,stih418
> -
> -additionalProperties: true
> -
> -...
> diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> new file mode 100644
> index 000000000000..aefa1919207c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual-license. I don't think there is anything from old binding being
copied here (you can as well start from scratch from other binding and
result will be the same).

Best regards,
Krzysztof
Alain Volmat Feb. 12, 2023, 8:16 p.m. UTC | #2 
Thanks for the review

On Sun, Feb 12, 2023 at 05:02:17PM +0100, Krzysztof Kozlowski wrote:
> On 11/02/2023 22:04, Alain Volmat wrote:
> > Add bindings for STi platform boards and remove stih415/stih416 items.
> > This commit also moves the sti.yaml binding file within the arm/sti/
> > folder instead of arm/
> > 
> > Signed-off-by: Alain Volmat <avolmat@me.com>
> > ---
> >  .../devicetree/bindings/arm/sti.yaml          | 26 ---------------
> >  .../devicetree/bindings/arm/sti/sti.yaml      | 33 +++++++++++++++++++
> >  2 files changed, 33 insertions(+), 26 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
> >  create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
> > deleted file mode 100644
> > index 3ca054c64377..000000000000
> > --- a/Documentation/devicetree/bindings/arm/sti.yaml
> > +++ /dev/null
> > @@ -1,26 +0,0 @@
> > -# SPDX-License-Identifier: GPL-2.0
> > -%YAML 1.2
> > ----
> > -$id: http://devicetree.org/schemas/arm/sti.yaml#
> > -$schema: http://devicetree.org/meta-schemas/core.yaml#
> > -
> > -title: ST STi Platforms
> > -
> > -maintainers:
> > -  - Patrice Chotard <patrice.chotard@foss.st.com>
> > -
> > -properties:
> > -  $nodename:
> > -    const: '/'
> > -  compatible:
> > -    items:
> > -      - enum:
> > -          - st,stih415
> > -          - st,stih416
> > -          - st,stih407
> > -          - st,stih410
> > -          - st,stih418
> > -
> > -additionalProperties: true
> > -
> > -...
> > diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > new file mode 100644
> > index 000000000000..aefa1919207c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > @@ -0,0 +1,33 @@
> > +# SPDX-License-Identifier: GPL-2.0
> 
> Dual-license. I don't think there is anything from old binding being
> copied here (you can as well start from scratch from other binding and
> result will be the same).

Ok

I understand, based on your review of the other patch in the serie that
I should put this sti.yaml within bindings/soc/sti right ?

Moreover, I made a mistake and removed st,stih415 and st,stih416 in
this patch while I already posted the patch in the STiH415/STiH416
removal serie (https://lore.kernel.org/all/20230209091659.1409-6-avolmat@me.com/).
I propose to get rid of the patch in the other serie and do the removal
within this patch since it also moves the file.

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
deleted file mode 100644
index 3ca054c64377..000000000000
--- a/Documentation/devicetree/bindings/arm/sti.yaml
+++ /dev/null
@@ -1,26 +0,0 @@ 
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/sti.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ST STi Platforms
-
-maintainers:
-  - Patrice Chotard <patrice.chotard@foss.st.com>
-
-properties:
-  $nodename:
-    const: '/'
-  compatible:
-    items:
-      - enum:
-          - st,stih415
-          - st,stih416
-          - st,stih407
-          - st,stih410
-          - st,stih418
-
-additionalProperties: true
-
-...
diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
new file mode 100644
index 000000000000..aefa1919207c
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
@@ -0,0 +1,33 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/sti.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST STi Platforms
+
+maintainers:
+  - Patrice Chotard <patrice.chotard@foss.st.com>
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - items:
+          - const: st,stih407-b2120
+          - const: st,stih407
+      - items:
+          - enum:
+              - st,stih410-b2120
+              - st,stih410-b2260
+          - const: st,stih410
+      - items:
+          - enum:
+              - st,stih418-b2199
+              - st,stih418-b2264
+          - const: st,stih418
+
+additionalProperties: true
+
+...