From patchwork Sat Feb 11 07:41:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 55731 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1381912wrn; Fri, 10 Feb 2023 23:43:29 -0800 (PST) X-Google-Smtp-Source: AK7set/LfUn42u21Hcv8cL6e0TAY5eIKZ56kIR01Z2v0UntgHAQLP7affJwFx6At2PHT5M9n5Elu X-Received: by 2002:a17:906:dace:b0:8a9:f870:d259 with SMTP id xi14-20020a170906dace00b008a9f870d259mr23858011ejb.48.1676101409735; Fri, 10 Feb 2023 23:43:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676101409; cv=none; d=google.com; s=arc-20160816; b=DL12hlVS1SIBFMCaBKIyPO3bq2W/PQFoMfKsfgkE5NZ/A+sToNuzi4UA+c4DBds/1D 2ZLqPmZAhtsSLs5tdSVUQZKJYHpwI2oAqScOiDlhWuzA37o9pVbU+VePPyKV60IQh68v Q3WJkOBS+9Gy0AxNg0YViO28x1PQAbhFrkPK+3oaxQjBay0Jmpcfa5hITey1GtynvUbY ZHadzL8dV6TiWxGwGzajMzWbjGd3YsltDwrn/oncFfW/eyvUaGNCZRgcMOd+/Iknu2vy FKLOZBO3j3OhKRWK1yB7dKjz8qfVKryoUgE9xiV0shwkYZJYJMe5Ub3WPS9IRvNhs8E5 0Qzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=l4gBYZ4FFyfwNExA4b1jAGo0toCNg5dUVVJvW9PERjs=; b=OATjOyNXSQHVBHdvD95ZVmGM0RLoXb0zKCa0v1Y8Z9GlJt6BJpXO99vDbKWiHuzSaG rGjzaWhg09iqYOO6szHpVgAMHE/9y5O3t3eD4a9VdFQiSDJ7HNNVNf2mip6XP1IHod53 bpSOu2j+wUk8zE3JypL2GXdSoBSvRZRlZKHoGcNgloxNp84x+zsnt3e1mlriwlYDrzGO txoa1MYiEJHY+jRp34CIW1y2R6MUDJVOUFbtmMiieP9XWcJQtvDoQWZekp7SNFdsSMp/ a7tfjMPTFoeiYcJ5zyX8rJGjWDo2tErDm45EBHHvTSmWUPVgU6R6rXN3mDk8GZ7iIXik tYsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 15-20020a170906208f00b0086f0864592dsi7922782ejq.321.2023.02.10.23.43.06; Fri, 10 Feb 2023 23:43:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbjBKHlp (ORCPT + 99 others); Sat, 11 Feb 2023 02:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjBKHle (ORCPT ); Sat, 11 Feb 2023 02:41:34 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DB6B6CC53 for ; Fri, 10 Feb 2023 23:41:32 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQkVc-0003zX-Rt; Sat, 11 Feb 2023 08:41:21 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pQkVX-004ALc-6G; Sat, 11 Feb 2023 08:41:16 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pQkVX-00Bft4-4N; Sat, 11 Feb 2023 08:41:15 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, intel-wired-lan@lists.osuosl.org Subject: [PATCH net-next v8 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() Date: Sat, 11 Feb 2023 08:41:10 +0100 Message-Id: <20230211074113.2782508-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230211074113.2782508-1-o.rempel@pengutronix.de> References: <20230211074113.2782508-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757519711808327881?= X-GMAIL-MSGID: =?utf-8?q?1757519711808327881?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 66a4e62009bb..8d927c5e3bf8 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);