diff mbox series

[2/6] ARM: dts: imx6dl-yapp4: Change LED channel names according to dt-binding

Message ID 20230210154855.3086900-3-michal.vokac@ysoft.com
State New
Headers
Series Add support for new boards in the imx6dl-yapp4 family |

Commit Message

Michal Vokáč Feb. 10, 2023, 3:48 p.m. UTC 
  The lp55xx LED controller binding was converted to schema and dtbs_check
now complains:

  led-controller@30: 'chan@0', 'chan@1', 'chan@2' do not match any of the regexes

Use correct names to fix that.

Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
 arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Shawn Guo March 13, 2023, 8:28 a.m. UTC | #1 
On Fri, Feb 10, 2023 at 04:48:51PM +0100, Michal Vokáč wrote:
> The lp55xx LED controller binding was converted to schema and dtbs_check
> now complains:
> 
>   led-controller@30: 'chan@0', 'chan@1', 'chan@2' do not match any of the regexes
> 
> Use correct names to fix that.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>

It's been address as part of this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b0d1f2738899dbcc7a026d826373530019aa31b

Shawn

> ---
>  arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index 52162e8c7274..aacbf317feea 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -274,7 +274,7 @@ leds: led-controller@30 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		chan@0 {
> +		led@0 {
>  			chan-name = "R";
>  			led-cur = /bits/ 8 <0x20>;
>  			max-cur = /bits/ 8 <0x60>;
> @@ -282,7 +282,7 @@ chan@0 {
>  			color = <LED_COLOR_ID_RED>;
>  		};
>  
> -		chan@1 {
> +		led@1 {
>  			chan-name = "G";
>  			led-cur = /bits/ 8 <0x20>;
>  			max-cur = /bits/ 8 <0x60>;
> @@ -290,7 +290,7 @@ chan@1 {
>  			color = <LED_COLOR_ID_GREEN>;
>  		};
>  
> -		chan@2 {
> +		led@2 {
>  			chan-name = "B";
>  			led-cur = /bits/ 8 <0x20>;
>  			max-cur = /bits/ 8 <0x60>;
> -- 
> 2.25.1
>
Krzysztof Kozlowski March 13, 2023, 8:48 a.m. UTC | #2 
On 13/03/2023 09:28, Shawn Guo wrote:
> On Fri, Feb 10, 2023 at 04:48:51PM +0100, Michal Vokáč wrote:
>> The lp55xx LED controller binding was converted to schema and dtbs_check
>> now complains:
>>
>>   led-controller@30: 'chan@0', 'chan@1', 'chan@2' do not match any of the regexes
>>
>> Use correct names to fix that.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> 
> It's been address as part of this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b0d1f2738899dbcc7a026d826373530019aa31b
> 

Which is mainline, so it raises the question on what old tree this was
based on...

Best regards,
Krzysztof
Michal Vokáč March 13, 2023, 10:57 a.m. UTC | #3 
On 13. 03. 23 9:48, Krzysztof Kozlowski wrote:
> On 13/03/2023 09:28, Shawn Guo wrote:
>> On Fri, Feb 10, 2023 at 04:48:51PM +0100, Michal Vokáč wrote:
>>> The lp55xx LED controller binding was converted to schema and dtbs_check
>>> now complains:
>>>
>>>    led-controller@30: 'chan@0', 'chan@1', 'chan@2' do not match any of the regexes
>>>
>>> Use correct names to fix that.
>>>
>>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>>
>> It's been address as part of this commit:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b0d1f2738899dbcc7a026d826373530019aa31b
>>
> 
> Which is mainline, so it raises the question on what old tree this was
> based on...

The whole series is based on v6.2-rc7-11-g05ecb680708a which was
linux-stable tree master branch from February 6th. I was not aware
of the referenced commit as it was merged later into v6.3-rc.

Good that it is fixed already, this patch can be skipped.
It is just unfortunate that I was not Cc'd back then.

Thanks,
Michal
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index 52162e8c7274..aacbf317feea 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -274,7 +274,7 @@  leds: led-controller@30 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		chan@0 {
+		led@0 {
 			chan-name = "R";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
@@ -282,7 +282,7 @@  chan@0 {
 			color = <LED_COLOR_ID_RED>;
 		};
 
-		chan@1 {
+		led@1 {
 			chan-name = "G";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;
@@ -290,7 +290,7 @@  chan@1 {
 			color = <LED_COLOR_ID_GREEN>;
 		};
 
-		chan@2 {
+		led@2 {
 			chan-name = "B";
 			led-cur = /bits/ 8 <0x20>;
 			max-cur = /bits/ 8 <0x60>;