diff mbox series

[1/1] thermal/drivers/hisi: Drop second sensor hi3660

Message ID 20230210141507.71014-1-yongqin.liu@linaro.org
State New
Headers
Series [1/1] thermal/drivers/hisi: Drop second sensor hi3660 |

Commit Message

Yongqin Liu Feb. 10, 2023, 2:15 p.m. UTC 
  The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm
allocators") exposes a panic "BRK handler: Fatal exception" on the
hi3660_thermal_probe funciton.
This is because the function allocates memory for only one
sensors array entry, but tries to fill up a second one.

Fix this by removing the unneeded second access.

Fixes: 7d3a2a2bbadb ("thermal/drivers/hisi: Fix number of sensors on hi3660")
Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
Link: https://lore.kernel.org/linux-mm/20221101223321.1326815-5-keescook@chromium.org/
---
 drivers/thermal/hisi_thermal.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Daniel Lezcano Feb. 10, 2023, 2:28 p.m. UTC | #1 
On 10/02/2023 15:15, Yongqin Liu wrote:
> The commit 74c8e6bffbe1 ("driver core: Add __alloc_size hint to devm
> allocators") exposes a panic "BRK handler: Fatal exception" on the
> hi3660_thermal_probe funciton.
> This is because the function allocates memory for only one
> sensors array entry, but tries to fill up a second one.
> 
> Fix this by removing the unneeded second access.
> 
> Fixes: 7d3a2a2bbadb ("thermal/drivers/hisi: Fix number of sensors on hi3660")
> Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
> Link: https://lore.kernel.org/linux-mm/20221101223321.1326815-5-keescook@chromium.org/
> ---

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index d6974db7aaf7..15af90f5c7d9 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -427,10 +427,6 @@  static int hi3660_thermal_probe(struct hisi_thermal_data *data)
 	data->sensor[0].irq_name = "tsensor_a73";
 	data->sensor[0].data = data;
 
-	data->sensor[1].id = HI3660_LITTLE_SENSOR;
-	data->sensor[1].irq_name = "tsensor_a53";
-	data->sensor[1].data = data;
-
 	return 0;
 }