| Message ID | 20230210111632.1985205-3-s.hauer@pengutronix.de |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp893592wrn;
Fri, 10 Feb 2023 03:20:09 -0800 (PST)
X-Google-Smtp-Source:
AK7set/4nx0KaqGtu3KEkuTGkIORtl4UdQDfOziBJfanr6nST1y4QbtEmvKJ2HgY0/6Kw2nM05MV
X-Received: by 2002:a05:6a20:4288:b0:be:a55a:8910 with SMTP id
o8-20020a056a20428800b000bea55a8910mr19592289pzj.4.1676028008863;
Fri, 10 Feb 2023 03:20:08 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676028008; cv=none;
d=google.com; s=arc-20160816;
b=BMl+EunxBnchakdOQ0Z0Pgp+sGugS+dqK9EQ2Xv3VRFs+ox3EItqFNtRhnWIUlEDIP
Cr/Nq8XuERn+AjUr+VqDAr9ogJgdUiv13XdjIzTw7p3LzPoxM3FxMozwojf/qv3C99zH
QZHcygdlLdoafgtbarfx15ALC4Gu+VNn6C1PbBbHN3LmsIRFi2rY219c9DuKzyMildLc
sqCDG1+zKCFbmKKjnksleC5iqsFB5zw06JpuMq5U78XmEqGrhKB8ZrpBkQNmaFatOW6x
k8v+pNxXNjKKzTg9EHC08YyEkK5/94atFBs1xyYkX9gqOAmZrxhdq/VO8pc55BsXmWIG
e6Lw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=LwThbMDmhnG8hLYXfbrhjAOpOHItTwnaz3KVLzMX2CQ=;
b=wDbXKZvAMZ+vJLC3pBElnYTJEoiv1gpeNtbpw9svxzvPpSNP4BzJ0dNpysdf1AnsCy
VArx5E2fuzA1T/dE+g+uU5VBhkJT1RtGDBLNUCaEVTzYW8fH2/n2qSX53cfzSe9UUyZN
KGa5b/8FLIwgMVwtKpzDAqjVbYhcfKmcrgD8ILFMdKLpFjPGJ2dGQO1sfFqKP9/G+btv
EsCqavDNYuexwj0gZsVAvI4+yTGhGOc6yIXvhWt7Vmd4Ok+okPzWAr2vzizadNSeDTTz
Eno6Tdod7tqk6DqpeGYxWg8VKXBrZyuoGViRFLuABLXfxm3Za7y0A14+al+NTdzxPt4F
SvWA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
z9-20020a637e09000000b004fb12ee7cb9si4392138pgc.354.2023.02.10.03.19.56;
Fri, 10 Feb 2023 03:20:08 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232283AbjBJLRG (ORCPT <rfc822;ybw1215001957@gmail.com>
+ 99 others); Fri, 10 Feb 2023 06:17:06 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57468 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232138AbjBJLQx (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 10 Feb 2023 06:16:53 -0500
Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de
[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187705275
for <linux-kernel@vger.kernel.org>;
Fri, 10 Feb 2023 03:16:45 -0800 (PST)
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
by metis.ext.pengutronix.de with esmtps
(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from <sha@pengutronix.de>)
id 1pQROO-0003KU-Os; Fri, 10 Feb 2023 12:16:36 +0100
Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de)
by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
(envelope-from <sha@pengutronix.de>)
id 1pQROM-003xEU-Aa; Fri, 10 Feb 2023 12:16:35 +0100
Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2)
(envelope-from <sha@pengutronix.de>)
id 1pQROM-008k9c-OR; Fri, 10 Feb 2023 12:16:34 +0100
From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-wireless@vger.kernel.org
Cc: Neo Jou <neojou@gmail.com>, Hans Ulli Kroll <linux@ulli-kroll.de>,
Ping-Ke Shih <pkshih@realtek.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Kalle Valo <kvalo@kernel.org>, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
kernel@pengutronix.de, Alexander Hochbaum <alex@appudo.com>,
Da Xue <da@libre.computer>, Po-Hao Huang <phhuang@realtek.com>,
Andreas Henriksson <andreas@fatal.se>,
Viktor Petrenko <g0000ga@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if
necessary
Date: Fri, 10 Feb 2023 12:16:31 +0100
Message-Id: <20230210111632.1985205-3-s.hauer@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230210111632.1985205-1-s.hauer@pengutronix.de>
References: <20230210111632.1985205-1-s.hauer@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2
X-SA-Exim-Mail-From: sha@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de);
SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757442745131718905?=
X-GMAIL-MSGID: =?utf-8?q?1757442745131718905?=
|
| Series |
wifi: rtw88: USB fixes
|
|
Commit Message
Sascha Hauer
Feb. 10, 2023, 11:16 a.m. UTC
Zero length packets are necessary when sending URBs with size
multiple of bulkout_size, otherwise the hardware just stalls.
Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/net/wireless/realtek/rtw88/usb.c | 1 +
1 file changed, 1 insertion(+)
Comments
> -----Original Message----- > From: Sascha Hauer <s.hauer@pengutronix.de> > Sent: Friday, February 10, 2023 7:17 PM > To: linux-wireless@vger.kernel.org > Cc: Neo Jou <neojou@gmail.com>; Hans Ulli Kroll <linux@ulli-kroll.de>; Ping-Ke Shih <pkshih@realtek.com>; > Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Martin Blumenstingl <martin.blumenstingl@googlemail.com>; > kernel@pengutronix.de; Alexander Hochbaum <alex@appudo.com>; Da Xue <da@libre.computer>; Bernie Huang > <phhuang@realtek.com>; Andreas Henriksson <andreas@fatal.se>; Viktor Petrenko <g0000ga@gmail.com>; Sascha > Hauer <s.hauer@pengutronix.de> > Subject: [PATCH v2 2/3] wifi: rtw88: usb: send Zero length packets if necessary > > Zero length packets are necessary when sending URBs with size > multiple of bulkout_size, otherwise the hardware just stalls. > > Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support") > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com> > --- > drivers/net/wireless/realtek/rtw88/usb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c > index d9e995544e405..1a09c9288198a 100644 > --- a/drivers/net/wireless/realtek/rtw88/usb.c > +++ b/drivers/net/wireless/realtek/rtw88/usb.c > @@ -271,6 +271,7 @@ static int rtw_usb_write_port(struct rtw_dev *rtwdev, u8 qsel, struct sk_buff *s > return -ENOMEM; > > usb_fill_bulk_urb(urb, usbd, pipe, skb->data, skb->len, cb, context); > + urb->transfer_flags |= URB_ZERO_PACKET; > ret = usb_submit_urb(urb, GFP_ATOMIC); > > usb_free_urb(urb); > -- > 2.30.2
diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c index d9e995544e405..1a09c9288198a 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -271,6 +271,7 @@ static int rtw_usb_write_port(struct rtw_dev *rtwdev, u8 qsel, struct sk_buff *s return -ENOMEM; usb_fill_bulk_urb(urb, usbd, pipe, skb->data, skb->len, cb, context); + urb->transfer_flags |= URB_ZERO_PACKET; ret = usb_submit_urb(urb, GFP_ATOMIC); usb_free_urb(urb);