From patchwork Fri Feb 10 11:16:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 55396 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp893286wrn; Fri, 10 Feb 2023 03:19:30 -0800 (PST) X-Google-Smtp-Source: AK7set8brbMnX/00qbv7O6nDotjv67tGE3q3cSVJaSCDzduleIlWyTmPjLtmUZO2AG5voIL7DSSV X-Received: by 2002:a50:ccc2:0:b0:4ab:2500:63b6 with SMTP id b2-20020a50ccc2000000b004ab250063b6mr4364695edj.14.1676027969912; Fri, 10 Feb 2023 03:19:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676027969; cv=none; d=google.com; s=arc-20160816; b=o22qigqumxbyVrAsdeYF1iKJri/NBaCS+jzqfKBiCYRd/cYqqd8chdAvoEhylS3x7+ o0Ih00TtO9F9kJiqGtSXKVpEj0+PYJCFQMS7VaY+IkoI1k6Z4CoJ4cwVdpQaxyPAAnvY pwiju8oJWSBBLV2DMDbAW+HQ0LrGorfpOW5uQI61FGQCRrFgcwprLvtqBwScmdFbw2/U 2lbF5YRx9BpCkGYs/wGymo0PKUUZ0Q8c2jUetotoC1DUMLt0/xh7T10H8FVwSJpQJQkO Bcd/s17mawPDJsC5aFofA/vMrM/ecEMgBrAKLLmKf8KUwvglmUnnUhzyistTvD2CdN9e exZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4zgAlTa7hHFgvtA4Ao84WVtr26ugCpvZeEXjBFgMGIA=; b=AjpWhnhhJjiVkBb4vnznWncpNqV4fjp1BfRbFbKg/KvdEynaw8dPSrTrIt+IAVsZ+M XL4E0e7P4QA5LNgYaVbcnjH8i1vTDGO0zTryiYhfBLBZh/vYEvZ/iRthfIajTAIPbq6I hbzAF8CqBG2VbR06R4lFmap3U00y+6xcpELNrbddxO7wtpsa0AisKt7WSO7T6a85cZZB 8Cti0T5j6Y+1uuqUNsGdofqCmz2IFEYlOvxDRtZ0d7yxpcLa1Au7fL1P+uBLvJgUoVuS 6z8zQe+PZsH/lo6aMBk2t9OrZJWked0Wi3o+54YErbHokzTTQC5iT2zZ/5RmStH/bInx O+Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a056402110d00b004aab2fed3e7si5223841edv.275.2023.02.10.03.19.07; Fri, 10 Feb 2023 03:19:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232382AbjBJLRJ (ORCPT + 99 others); Fri, 10 Feb 2023 06:17:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232075AbjBJLQx (ORCPT ); Fri, 10 Feb 2023 06:16:53 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3869B72DF7 for ; Fri, 10 Feb 2023 03:16:45 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQROO-0003KW-Oy; Fri, 10 Feb 2023 12:16:36 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pQROM-003xEZ-EI; Fri, 10 Feb 2023 12:16:35 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pQROM-008k9Z-Nh; Fri, 10 Feb 2023 12:16:34 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Alexander Hochbaum , Da Xue , Po-Hao Huang , Andreas Henriksson , Viktor Petrenko , Sascha Hauer Subject: [PATCH v2 1/3] wifi: rtw88: usb: Set qsel correctly Date: Fri, 10 Feb 2023 12:16:30 +0100 Message-Id: <20230210111632.1985205-2-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230210111632.1985205-1-s.hauer@pengutronix.de> References: <20230210111632.1985205-1-s.hauer@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757442704525257032?= X-GMAIL-MSGID: =?utf-8?q?1757442704525257032?= We have to extract qsel from the skb before doing skb_push() on it, otherwise qsel will always be 0. Fixes: a82dfd33d1237 ("wifi: rtw88: Add common USB chip support") Signed-off-by: Sascha Hauer Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c index 4ef38279b64c9..d9e995544e405 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -471,9 +471,9 @@ static int rtw_usb_tx_write(struct rtw_dev *rtwdev, u8 *pkt_desc; int ep; + pkt_info->qsel = rtw_usb_tx_queue_mapping_to_qsel(skb); pkt_desc = skb_push(skb, chip->tx_pkt_desc_sz); memset(pkt_desc, 0, chip->tx_pkt_desc_sz); - pkt_info->qsel = rtw_usb_tx_queue_mapping_to_qsel(skb); ep = qsel_to_ep(rtwusb, pkt_info->qsel); rtw_tx_fill_tx_desc(pkt_info, skb); rtw_tx_fill_txdesc_checksum(rtwdev, pkt_info, skb->data);