Message ID | 20230209201116.579809-4-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp298387wrn; Thu, 9 Feb 2023 04:14:14 -0800 (PST) X-Google-Smtp-Source: AK7set+fEFo3B75pEMwErBhX+dLUD1LM/67GxvXi5TllZ8crCtUep7kSEALl4j+Uxu+ufrzuO3lE X-Received: by 2002:a17:90a:313:b0:230:c87e:2b2d with SMTP id 19-20020a17090a031300b00230c87e2b2dmr11990093pje.40.1675944854393; Thu, 09 Feb 2023 04:14:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675944854; cv=none; d=google.com; s=arc-20160816; b=r8eVcQWhneWyZWiabP2mHwexu4x/vVtD/qHMn2wdNj18MBhnW0Rmkl9XX4iVYUVk3s K3Scn24Qpcp76rASPsSSB8z4TKGsM4UnWoNQyk3TZJCUZI1/59hiuSmYGRlFC0NhsReY XTHgRcNj11ZAW0erYh+r6idaPltXRBiUTTX/PP6NkfTaiZSbXcCRw6sIQzZ7mlp752rr KJnv7YyaP/JUlxX0NQsMXEu2LqhpEJrv/pamBzRiewLpqpUD1fqYK0r5ebWfLpeifYXs 9weObCjDT+AJ1rFKZDs5fwwn1w3lNoqSv1cxhVbdTPgXsLtn6+Ug0YcTssoUQsY9zxfE MY9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VSOIdyBAcmjsoWx9sPpzfUfNq5O84Fi3I7YV8TRm4YQ=; b=sPW3gw3BFrqL9K2SLk3BVQPTaNWDors2+jCVnI+7QrPRJ8cSgqtv7N5JZfE3wTGUAz WgEQtihT7udcDFzyVDv9n6R4t8YYidKFsp/Pa3x6ilpBm3VPF3bklD/YchqWW6AEs4iz r7uIHBN6BwZ6gJmB6xwtEvyEHykNhj0DiZ8A3X75IlF5VlOaa6rLzKxGsCVjbhFi9iOR 7amPwwlFSJlFbY97zbG6e0hh3Qa3NZGmwvUR8qrgPuCY/ORMTRFCHvVb60PKXMAv3O2p vgR04aMlM+Z5Zo1CVPu8jpjV2reGp4Xdjr5jMsiu/t1xgmNjD5PihY2HsvRPFmZmOAwZ jRXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p3-20020a637403000000b004df0d68adf2si1698512pgc.629.2023.02.09.04.13.59; Thu, 09 Feb 2023 04:14:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229586AbjBIMLy (ORCPT <rfc822;ybw1215001957@gmail.com> + 99 others); Thu, 9 Feb 2023 07:11:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbjBIMLN (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Feb 2023 07:11:13 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9091086A8; Thu, 9 Feb 2023 04:09:21 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PCFz02C9Lz4f3m6j; Thu, 9 Feb 2023 20:09:16 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAHvrFr4uRj4rAuDQ--.53349S5; Thu, 09 Feb 2023 20:09:18 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: axboe@kernel.dk, hch@lst.de, jack@suse.cz Cc: andriy.shevchenko@linux.intel.com, qiulaibin@huawei.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] blk-mq: remove wake_batch recalculation for reserved tags Date: Fri, 10 Feb 2023 04:11:12 +0800 Message-Id: <20230209201116.579809-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230209201116.579809-1-shikemeng@huaweicloud.com> References: <20230209201116.579809-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgAHvrFr4uRj4rAuDQ--.53349S5 X-Coremail-Antispam: 1UD129KBjvdXoW7XF4rWF45tr4xur13tF18Zrb_yoWkKFb_Wr 9rCa1ktFZ7ZFn3u3WjvF13trsYk3ykJry8Gan0qrZIkrn7JF95G390ka1FqFZxGFW8ur9x KF1kXw4jkrn7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfkYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r1rM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjxUIq2MUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757355551290536252?= X-GMAIL-MSGID: =?utf-8?q?1757355551290536252?= |
Series |
A few bugfix and cleanup patches to blk-mq
|
|
Commit Message
Kemeng Shi
Feb. 9, 2023, 8:11 p.m. UTC
Commit 180dccb0dba4f ("blk-mq: fix tag_get wait task can't be
awakened") added wake_batch recalculation when user number of shared
tags changes to avoid hung as user number increases, then hctx_max_depth
limit for a single user decreases and may trigger hung if wake_batch >
hctx_max_depth is met.
Commit 285008501c65a ("blk-mq: always allow reserved allocation in
hctx_may_queue") removed hctx_max_depth limit to alloc reserved
tags, so hctx_max_depth limit for reserved tags is not exisiting anymore
so we can remove recalculation for reserved tags.
Fixes: 285008501c65 ("blk-mq: always allow reserved allocation in hctx_may_queue")
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
block/blk-mq-tag.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index e566fd96dc26..7f1777dc11e5 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -27,8 +27,6 @@ static void blk_mq_update_wake_batch(struct blk_mq_tags *tags, sbitmap_queue_recalculate_wake_batch(&tags->bitmap_tags, users); - sbitmap_queue_recalculate_wake_batch(&tags->breserved_tags, - users); } /*