From patchwork Thu Feb 9 19:48:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 54881 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp289037wrn; Thu, 9 Feb 2023 03:58:18 -0800 (PST) X-Google-Smtp-Source: AK7set93qOvPjKnii/wiAyClVzNBINc4IQZBM8XTVzDzRfgPGKU0v0/+aRB6DEUhR0e4NWquhoFL X-Received: by 2002:aa7:943b:0:b0:5a7:6568:2a09 with SMTP id y27-20020aa7943b000000b005a765682a09mr8886164pfo.2.1675943897981; Thu, 09 Feb 2023 03:58:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675943897; cv=none; d=google.com; s=arc-20160816; b=gDj7uSeD3Hp6eyBgLjdLDzZ+pTgisiWba6j6W8NtE5+i+fbN0HYpBCrEGfl4sUV8+h RXH+Hd5yWNwlmb9ZtdNUAST8Hw9Ny3Tl9SV9C2LUT/zquje9A523DaS5afm2XupTSCwU /n1rvFECuO6MwSOIupCkF4O5TC1WHVI6YZ+5BUgmYD5Fad2Ld4TPNdJPqBmUACAZ6sna jU9F7x7Cfr6aBeDBvJoksLhxOojatuZWPvrPNjCeOM1p48TO5tTJPkdtdLQ2rTxknpZx dLwWTT9WQ9s+vEp6zjWyUaDQ5ew3IWilR7PyqV9cv5CC+CC+UZ1gOr7XWtfQ7YHcUWXO YgCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=liMdx/FMFfoSyQWU5VuakLmBqRVOitUTW28BlDJeu7A=; b=MS+TwGOB3teKrW+YhL/i/3WpnwJcjChTLVHk2VclaYESQFtdu3q5imWJZxDol6ZcSh A2ZSfXcgpWzV04AmwFha3tbN0WGMSiFtvBNAksI4iuFA/XhcZO4Y0MdgtUUvWS6rX9J3 ghMAjYFESFtp27x2cA7ldw5DZMITkbG5gSBC28EBdZdMiP14G09EqPvDByTlbcp63RAm fiHWoEse7z3mseS3SC3BnQYWjWH2uFp0iE/yqyAyTcHD8a3H0/uhZRsOg4YeRZ+jYB5g 2e3kqCnJFK1rRzoTpfvcCbpOcMdTGctRXuxW2Re6vkuO20jQ02C9ai7NQ7XrOt8TDKJu mFqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020aa79f88000000b00592a19cde96si1556227pfr.369.2023.02.09.03.58.05; Thu, 09 Feb 2023 03:58:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjBIL44 (ORCPT + 99 others); Thu, 9 Feb 2023 06:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229705AbjBIL4K (ORCPT ); Thu, 9 Feb 2023 06:56:10 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C7515BA70; Thu, 9 Feb 2023 03:46:28 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PCFSb6dxmz4f3jZY; Thu, 9 Feb 2023 19:46:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAn3rEQ3eRjgb0tDQ--.53508S3; Thu, 09 Feb 2023 19:46:26 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/21] ext4: set goal start correctly in ext4_mb_normalize_request Date: Fri, 10 Feb 2023 03:48:05 +0800 Message-Id: <20230209194825.511043-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230209194825.511043-1-shikemeng@huaweicloud.com> References: <20230209194825.511043-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAn3rEQ3eRjgb0tDQ--.53508S3 X-Coremail-Antispam: 1UD129KBjvdXoWrtFyrAF13KFWrJr17AF43KFg_yoWkWwc_Ga 45ury8GFW5Jr1fCa1Syw1rtrs7KF48Xr17JrZrJ3WUX3WUuw4Ikwn0vr4xZa48Way7tay3 KrsIkr1xGa1S9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbf8YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r18M28IrcIa0xkI8VCY1x0267AKxVWUXVWUCwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU0a0PDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757354548480019684?= X-GMAIL-MSGID: =?utf-8?q?1757354548480019684?= We need to set ac_g_ex to notify the goal start used in ext4_mb_find_by_goal. Set ac_g_ex instead of ac_f_ex in ext4_mb_normalize_request. Signed-off-by: Kemeng Shi Reviewed-by: Ojaswin Mujoo --- fs/ext4/mballoc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 5b2ae37a8b80..0650a1dc870e 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -4191,15 +4191,15 @@ ext4_mb_normalize_request(struct ext4_allocation_context *ac, if (ar->pright && (ar->lright == (start + size))) { /* merge to the right */ ext4_get_group_no_and_offset(ac->ac_sb, ar->pright - size, - &ac->ac_f_ex.fe_group, - &ac->ac_f_ex.fe_start); + &ac->ac_g_ex.fe_group, + &ac->ac_g_ex.fe_start); ac->ac_flags |= EXT4_MB_HINT_TRY_GOAL; } if (ar->pleft && (ar->lleft + 1 == start)) { /* merge to the left */ ext4_get_group_no_and_offset(ac->ac_sb, ar->pleft + 1, - &ac->ac_f_ex.fe_group, - &ac->ac_f_ex.fe_start); + &ac->ac_g_ex.fe_group, + &ac->ac_g_ex.fe_start); ac->ac_flags |= EXT4_MB_HINT_TRY_GOAL; }