From patchwork Thu Feb 9 19:48:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 54893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp289884wrn; Thu, 9 Feb 2023 04:00:05 -0800 (PST) X-Google-Smtp-Source: AK7set81XdUEblQjBMETAsd5G657Gib1VXBswmP4ARUeLIcZ4pjhH4tsibZDUJ92WW0BSDYhkJHE X-Received: by 2002:a17:903:2448:b0:198:f027:5925 with SMTP id l8-20020a170903244800b00198f0275925mr12480625pls.64.1675944005565; Thu, 09 Feb 2023 04:00:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675944005; cv=none; d=google.com; s=arc-20160816; b=pIl2h/7Z4sZPXtKmqnJsF7/caoBvPSDN+PbXsQIHkPXwPmE7h2SkDBcZQXWrl1iON6 diRJ3rirBt1z+leMfhSPnRvbwASgG9lxhqsRcpdxvRVD5LOPrAFCM+oqOVv6IdK4tOVI jJaA1MMsN1wvtmZ3a6hanXdCXeG3fp2y86WRGKEuldK5cEYybP96omGhVp8KC4QKnJCX E0RwpN3/7KRZQU53SPmZIRfn8kiG3frKO/Uq3/D7aFpKf95AcYXrUu1YTrLvHFDQjayJ hBysSGpt/th9RGJ33m801S/CyS6xluvlGEIWW994j5ylUgrKdK9Mk1E9DNXzys00c8D3 3Ueg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uRbeH3zHs7eJ5a2tjAze7Sxj2qSEgXvXuTG7g8Yjccs=; b=iVCMJm5IZogE7OieyiHoC1dZ4SejRjd9OXSMsh7WDj04JsWCnBFfatX6/5X+Jj4nJW g6U05atiQW4OcEkabQilM2OtN8J1BDkuTDK1iU4ASdVZaxfjtG00hRWrPXGlMoUUeOdZ miVaQMQ7vuzc0ZU9usYxc8uHbcR0oPoOc+YXkKgnIkLPtzPI74sh/DVTqJqSI+l3Xs7G GsB3qaxJdv9Dqp7AScaL6UEDij/n04BROEFmNb25HOF/+EXU8SPWICoFcEoNEUlhflqX RAhq4J5YoLth4RQ/tL47hj/BAhmBOU7olTuhXhf6fv8XP6aUrxEYWo9+Ww5fTnA/Xn3M 0Cyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u69-20020a638548000000b004fb456c442bsi1732999pgd.840.2023.02.09.03.59.33; Thu, 09 Feb 2023 04:00:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbjBIL5v (ORCPT + 99 others); Thu, 9 Feb 2023 06:57:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjBIL4O (ORCPT ); Thu, 9 Feb 2023 06:56:14 -0500 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3925C497; Thu, 9 Feb 2023 03:46:32 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.169]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4PCFSg4RwNz4f3jqV; Thu, 9 Feb 2023 19:46:27 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAn3rEQ3eRjgb0tDQ--.53508S15; Thu, 09 Feb 2023 19:46:29 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 13/21] ext4: remove dead check in mb_buddy_mark_free Date: Fri, 10 Feb 2023 03:48:17 +0800 Message-Id: <20230209194825.511043-14-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230209194825.511043-1-shikemeng@huaweicloud.com> References: <20230209194825.511043-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAn3rEQ3eRjgb0tDQ--.53508S15 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr4rJr4xZF45Gr18Gw43trb_yoW3Cwc_Ka 43A3ykJrWrtr4Fka4kAr4vgr48K3Z5Cr47X345tr4xWFyUW393Aw1Dtrn3AF1xu3y2yrWD GF95Ga47uF4FgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbSxYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r126s0DM28IrcIa0xkI8VCY1x0267AKxVW5JVCq3wA2ocxC 64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM2 8EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq 3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUIL05UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757354661179733532?= X-GMAIL-MSGID: =?utf-8?q?1757354661179733532?= We always adjust first to even number and adjust last to odd number, so first == last will never happen. Remove this dead check. Signed-off-by: Kemeng Shi --- fs/ext4/mballoc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index bdabe0d81d4a..0fdbf16ac180 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -1718,7 +1718,8 @@ static void mb_buddy_mark_free(struct ext4_buddy *e4b, int first, int last) break; order++; - if (first == last || !(buddy2 = mb_find_buddy(e4b, order, &max))) { + buddy2 = mb_find_buddy(e4b, order, &max); + if (!buddy2) { mb_clear_bits(buddy, first, last - first + 1); e4b->bd_info->bb_counters[order - 1] += last - first + 1; break;