From patchwork Thu Feb 9 15:02:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 55008 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp404183wrn; Thu, 9 Feb 2023 07:36:35 -0800 (PST) X-Google-Smtp-Source: AK7set+cL1VNM5BVJ3iYer/Tg2ICI59gBnsTk/cYRAguP6yfoXqKONtO8tm3F2i3EY0EnCOlxBE5 X-Received: by 2002:a50:a44a:0:b0:4ab:178d:3d9f with SMTP id v10-20020a50a44a000000b004ab178d3d9fmr4142385edb.28.1675956995707; Thu, 09 Feb 2023 07:36:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675956995; cv=none; d=google.com; s=arc-20160816; b=jrFEuaYbfV+J6wzE9L94mr4tZJH/sA4FC9trFv41v4OyzJcy4vdUpbdfEIpszWRCWx MWCz4vVzB22l/4RH77jzd/6c6U92wevz8w1wzi/pik+tVViGZeeACG3mHyOGhvCZLS9U te46Uwd7TpdOVTRs5O86n/0Z9qh9cJHXpCmaQsbMbUa2WX5FhelxaeBiDovp1YXs/Z0e g7j9ajZHCEvXaWIjDMwZgz3DhDPWFAJ+4YWWMrKL/09zBOP7OKkskOKqpV6pCP4LK/x7 pLpnFN93CxNUjK6eOGg3CLGZKH5rMAslnzL20FECEDBTfdJ+RXABN7yg96UIoSnhnCnj meyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id:dkim-signature; bh=Djq1nafk+T9HY7/d7T0y7Sk074zesK3iaSlQcrfIOBk=; b=Tie3W3upJm4VALKzyP+/b1VWVCQH5+iNBxzvNMFz+v3j+yEK8+l0r85DtPkwC2sOcn hJLWhQzeodIOU+5KCDXNWYbhbOgikF3wRtt71/bj+mvNttkGNL/kN6agoZZj9ZAEpm9W 1rMSLAE250XqRVkh5jLVoHMH+koF3uK0+r/ZKYz9rScsphFuqQteNBCIai8C4QLbf3N8 2TBvO2PofWEwUpvKlqn/LPtoDxRSjxI0F034fC2Q1CkPIFTUIVxhCgi/vMjS/p9KzPr/ QdiogBf6lEdfj4Nxzb+g18dMWSZYg0SMSGVDk3/rXdsNfAqf87pcWmio3r01I+nka2Ci QN1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="cV/Hwo44"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020aa7cf16000000b004a2160515a4si2514786edy.199.2023.02.09.07.36.12; Thu, 09 Feb 2023 07:36:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="cV/Hwo44"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbjBIPeR (ORCPT + 99 others); Thu, 9 Feb 2023 10:34:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230410AbjBIPeI (ORCPT ); Thu, 9 Feb 2023 10:34:08 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB9BF423A for ; Thu, 9 Feb 2023 07:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675956799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=Djq1nafk+T9HY7/d7T0y7Sk074zesK3iaSlQcrfIOBk=; b=cV/Hwo44u6YXekoUiUU2St1FfZ6Fm+ts1zorxxBdILv1sIVHqszH88+SgOJslpNbjSKP5X CO8k6NHFGbY+9y0AT2sEueV5xYFd7QCE3F+HpG452pKvcin7jJoFrvphrhb4J5Njyn7/zD Y0hYAAHYyml0CEQoPKjpMYMhjAgW6uU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-49-YtM2vNv5O6i_tviMBYIBvA-1; Thu, 09 Feb 2023 10:33:17 -0500 X-MC-Unique: YtM2vNv5O6i_tviMBYIBvA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94220858F0E; Thu, 9 Feb 2023 15:33:16 +0000 (UTC) Received: from tpad.localdomain (ovpn-112-3.gru2.redhat.com [10.97.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 668772026D4B; Thu, 9 Feb 2023 15:33:16 +0000 (UTC) Received: by tpad.localdomain (Postfix, from userid 1000) id 8B2A4403CC07D; Thu, 9 Feb 2023 12:32:51 -0300 (-03) Message-ID: <20230209153204.901518530@redhat.com> User-Agent: quilt/0.67 Date: Thu, 09 Feb 2023 12:02:00 -0300 From: Marcelo Tosatti To: Christoph Lameter Cc: Aaron Tomlin , Frederic Weisbecker , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Marcelo Tosatti Subject: [PATCH v2 10/11] mm/vmstat: switch vmstat shepherd to flush per-CPU counters remotely References: <20230209150150.380060673@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757368282756221529?= X-GMAIL-MSGID: =?utf-8?q?1757368282756221529?= Now that the counters are modified via cmpxchg both CPU locally (via the account functions), and remotely (via cpu_vm_stats_fold), its possible to switch vmstat_shepherd to perform the per-CPU vmstats folding remotely. This fixes the following two problems: 1. A customer provided some evidence which indicates that the idle tick was stopped; albeit, CPU-specific vmstat counters still remained populated. Thus one can only assume quiet_vmstat() was not invoked on return to the idle loop. If I understand correctly, I suspect this divergence might erroneously prevent a reclaim attempt by kswapd. If the number of zone specific free pages are below their per-cpu drift value then zone_page_state_snapshot() is used to compute a more accurate view of the aforementioned statistic. Thus any task blocked on the NUMA node specific pfmemalloc_wait queue will be unable to make significant progress via direct reclaim unless it is killed after being woken up by kswapd (see throttle_direct_reclaim()) 2. With a SCHED_FIFO task that busy loops on a given CPU, and kworker for that CPU at SCHED_OTHER priority, queuing work to sync per-vmstats will either cause that work to never execute, or stalld (i.e. stall daemon) boosts kworker priority which causes a latency violation Signed-off-by: Marcelo Tosatti Index: linux-2.6/mm/vmstat.c =================================================================== --- linux-2.6.orig/mm/vmstat.c +++ linux-2.6/mm/vmstat.c @@ -2007,6 +2007,23 @@ static void vmstat_shepherd(struct work_ static DECLARE_DEFERRABLE_WORK(shepherd, vmstat_shepherd); +#ifdef CONFIG_HAVE_CMPXCHG_LOCAL +/* Flush counters remotely if CPU uses cmpxchg to update its per-CPU counters */ +static void vmstat_shepherd(struct work_struct *w) +{ + int cpu; + + cpus_read_lock(); + for_each_online_cpu(cpu) { + cpu_vm_stats_fold(cpu); + cond_resched(); + } + cpus_read_unlock(); + + schedule_delayed_work(&shepherd, + round_jiffies_relative(sysctl_stat_interval)); +} +#else static void vmstat_shepherd(struct work_struct *w) { int cpu; @@ -2026,6 +2043,7 @@ static void vmstat_shepherd(struct work_ schedule_delayed_work(&shepherd, round_jiffies_relative(sysctl_stat_interval)); } +#endif static void __init start_shepherd_timer(void) {