From patchwork Thu Feb 9 13:13:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 54947 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp328703wrn; Thu, 9 Feb 2023 05:20:12 -0800 (PST) X-Google-Smtp-Source: AK7set8u1VbZ8nIEAUaydKmYqvSxAw3sueaprFV7o71m1PRg4Oiq/oy3U1bh2KeC9wunYgtdMoxc X-Received: by 2002:a17:907:741:b0:8af:3b7c:ff81 with SMTP id xc1-20020a170907074100b008af3b7cff81mr3041871ejb.50.1675948812242; Thu, 09 Feb 2023 05:20:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675948812; cv=none; d=google.com; s=arc-20160816; b=0zDMQI7T2cHXc5VenpOlzSsH2Kb7wcx0SpjFdtxuupD/9gL/HVYJcXrEI8JP+hysUW q6cKVxbBgKVrArKF9cL0qjI3p2oCwKnsm4yLNJ9yg04hG/EEbtcLNsOHKF6sqqkEaD+B 09zXXDsEhTzc++HQJKeEXlNK2ZHuwWrtjOsV43u4k0GhZXR04Z7KLuEoZf2gARso+xAB 7P6UxsrrT93vFXefGixUVps6GDLdysej0FrtyF0XvffJLqht4u2IjrqbRCnx0E/FdouJ inL9tSPMOW9dpqoqYRpHEVCiuXSc1V992EFw6ZrpFpE91FoC4aZMy2TIZoOiDsHSldtz WDzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nPXVzG5o2X54MLB3ZyDSI4pawnltFzWU5Saextq817o=; b=dOk1hPKubIsmdzk0F4/doqZaAqXKPKTY7+PCdOOD+R75NejM4RUhdSgP6ntbBGdA2n tBGvvdht8xT9ouReULNXf54Ps2f76LQ7B8V5HB0AU5e2lV0seBf15Y/SeRTlr4PZjjnH TY5omyRwDfgKnkrO0YG4WkpnJBS2m5hRq0FqEEVVQcmEsd4mmYypeohD8rVr3TNKDU+g VO65qxMdZBLggW9LHiY2q7myZjrLLUpYE+Bc27nhUzpk0+bX2IVjY4c9xsLyuOMx8cpb zQlHWkt5fVyN2kIgOPRCfBOXvOn8kkZw8kogswyS1zLBA3lrPINWZ3ehg9RwcJgB9eG8 imvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ULYJnwqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ge10-20020a170907908a00b00878742fba64si2137216ejb.68.2023.02.09.05.19.48; Thu, 09 Feb 2023 05:20:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ULYJnwqN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230047AbjBINN6 (ORCPT + 99 others); Thu, 9 Feb 2023 08:13:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbjBINNw (ORCPT ); Thu, 9 Feb 2023 08:13:52 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF27A35252 for ; Thu, 9 Feb 2023 05:13:50 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id u10so1396004wmj.3 for ; Thu, 09 Feb 2023 05:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nPXVzG5o2X54MLB3ZyDSI4pawnltFzWU5Saextq817o=; b=ULYJnwqNMeRiea9IJdFP6yvfpxaRwkju4sp2HMcBIO6UHM0rdl40OPLuvrjmSSH4OQ fpScO6nXREnk/uZlVm+PA0saUgUMEmCFnW5NCC9kCeEAOKtmcNsrx7ogiJ6TB335qgHA CldrEYHwLgk7qatZ91j1dre1BD6oBWD0L9U/KbLV3gEdL58WEI6i5db+AgDPJOe6pxVK rQQoGLiXpE/k3cYKnVBMHn4E9BWxgeSkl1ny+vpFIAqEa6Vsypkb77sMWf551sHbIURF KB0pIBFLrVjTUtsMuN76ljfwuGHip+Xb5xVwWvy+MARzu1zprHOqFyTiW2V25COrRGcI +Ugw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nPXVzG5o2X54MLB3ZyDSI4pawnltFzWU5Saextq817o=; b=evgBq5pvpwOU5xUUvt3rpJPZhlcZNMWbTAvt/9k2O2ZMgkC87quFrmkl9TKEc+8fKa gZq3vkuGJCYw7FJdhP2RAf4bE6GStCqt2rpP47V3jNe2/cp4m/dbJp52sKetI6U+za4z L8D+40QjDTDLW/fWKoTEHnUSpCKVCHvkqxa5SwuE4iVr7BiCGSFhi1ueuGuFOfJMnubC hb4V2DST8Y9xuamhd8DjLeTXLyWLu/wt02NKRoSaOZU3NCczAcc3UtvxZ0yr8Q/knh2y UK7YyHgumRlni4oa5TGNNQCB+0Bu2I0WYi7yAf3FLdWQQsEs28DUw1O68Bs3/gO5T4C8 Lw7A== X-Gm-Message-State: AO0yUKVo4ajzz6WTbYsTns7f86RKM5O2aSFbw4HvLyVUw0EET6hSrHBx 9pQecFGOMPis9OGzLx4clbfdFA== X-Received: by 2002:a05:600c:a293:b0:3dc:59e9:9285 with SMTP id hu19-20020a05600ca29300b003dc59e99285mr11100382wmb.18.1675948429591; Thu, 09 Feb 2023 05:13:49 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ja13-20020a05600c556d00b003dc4b4dea31sm1789394wmb.27.2023.02.09.05.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 05:13:48 -0800 (PST) From: Srinivas Kandagatla To: vkoul@kernel.org Cc: yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, steev@kali.org, johan+linaro@kernel.org, quic_bjorande@quicinc.com, Srinivas Kandagatla Subject: [PATCH 2/5] soundwire: qcom: enable runtime pm before controller is registered Date: Thu, 9 Feb 2023 13:13:33 +0000 Message-Id: <20230209131336.18252-3-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20230209131336.18252-1-srinivas.kandagatla@linaro.org> References: <20230209131336.18252-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757359701538563897?= X-GMAIL-MSGID: =?utf-8?q?1757359701538563897?= Registering controller even before pm runtime is enabled will result in pm runtime underflow warnings. Fix this by properly moving the runtime pm enable before registering controller. Fixes: 74e79da9fd46 ("soundwire: qcom: add runtime pm support") Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/qcom.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index 9d8ae77bad0a..b2363839624c 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -1417,6 +1417,12 @@ static int qcom_swrm_probe(struct platform_device *pdev) } } + pm_runtime_set_autosuspend_delay(dev, 3000); + pm_runtime_use_autosuspend(dev); + pm_runtime_mark_last_busy(dev); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + ret = sdw_bus_master_add(&ctrl->bus, dev, dev->fwnode); if (ret) { dev_err(dev, "Failed to register Soundwire controller (%d)\n", @@ -1435,12 +1441,6 @@ static int qcom_swrm_probe(struct platform_device *pdev) (ctrl->version >> 24) & 0xff, (ctrl->version >> 16) & 0xff, ctrl->version & 0xffff); - pm_runtime_set_autosuspend_delay(dev, 3000); - pm_runtime_use_autosuspend(dev); - pm_runtime_mark_last_busy(dev); - pm_runtime_set_active(dev); - pm_runtime_enable(dev); - /* Clk stop is not supported on WSA Soundwire masters */ if (ctrl->version <= 0x01030000) { ctrl->clock_stop_not_supported = true;