[v13,07/12] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing
Message ID | 20230209102954.528942-8-dhowells@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp256087wrn; Thu, 9 Feb 2023 02:34:57 -0800 (PST) X-Google-Smtp-Source: AK7set9gNeBYD0aROQZv6fxPwC72AWquIKv0rPBkfoSlVTirrbcoAOtpurtQL2tTRye1K1KHUyFY X-Received: by 2002:a05:6a20:7f92:b0:bc:9007:e53 with SMTP id d18-20020a056a207f9200b000bc90070e53mr15075776pzj.0.1675938897557; Thu, 09 Feb 2023 02:34:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675938897; cv=none; d=google.com; s=arc-20160816; b=yirwT6YjCAckLqSKXTf+sItVYDSIo7jv7poL8vF+vLZqmtXUcB6fz7qZYDlfP1oNil EuPpbzAkmFczxEmoeF/ysIlgSwVTSAqj/BiPNoMaKIEjfvmwOU/eiK0Ncai+fGA+NxaJ rjbTm+vRu/36f8hA0vZRGvXV/chBXcxlXHWlPziZ45E8ePRC1ZjAmUbiVwh+8LJvwYT3 3P6omRVkAILFcXjnixf1a4PtxHJrPMawFTBnGnVv87AFTmOcel4561PnACNlSgvUKJbT pFfP+UNJbDNDWADOHN95axBR3ObCumtkdkJD//+2V41wU+ltBTTSpGd5BZPQVsJ41xMP Cy2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=Cwz4KeTAp8Msty99e/Uo3sbEGnBGOwaz6Qsoo3iITTKGpWw4k7mn0wC9Fy5+izzgUp GH7P2Tob8ByNW95SftUCVxx2Cq8gH8nwwtgSkINz5MYfhRoLP5JxG3D9JrS1CKtxtLwl ofW4K6eSFJax/mfPLE4HfbW0kCVDGp87MNwrByDgMeYvRAgiho9c0WNk3TLSJrGlnnZt SdFE3FQ+RNkSy0IWT3QMmDPjvTf3Czs6JTe6z8r5wPKt+kjjniWFiZ1ofUPjbNBlOF0z pg2OZ6cKf6/nq7qd+Il6vmytjSQSaTq49PUpisBtpYAi3eAVLiSKX/CgU6FuECDg4y9G T9mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Z0mlKeO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e14-20020a63370e000000b004e06fea7d4fsi165252pga.220.2023.02.09.02.34.44; Thu, 09 Feb 2023 02:34:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Z0mlKeO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbjBIKcM (ORCPT <rfc822;ybw1215001957@gmail.com> + 99 others); Thu, 9 Feb 2023 05:32:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229973AbjBIKbg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Feb 2023 05:31:36 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9292532525 for <linux-kernel@vger.kernel.org>; Thu, 9 Feb 2023 02:30:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675938627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=Z0mlKeO/EjZSVCXGvuR3N+a7yjIuBqjPQWtZY0am8frZiUxlV2MRnYTk36uvcc8xDGKnmv rHZ+D2bMz2DD9Uh882VX7DXegSs+eTswPn142xevXn1R1vM9NN2N92dvA+yU4pxE+b4f6I lyMtK7qhNcR0Gb4HiMmAYaD0R9htn+E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-gCLZSpzUOyqIbLen8hMYnQ-1; Thu, 09 Feb 2023 05:30:23 -0500 X-MC-Unique: gCLZSpzUOyqIbLen8hMYnQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7E0DF18E005F; Thu, 9 Feb 2023 10:30:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id 986F41121314; Thu, 9 Feb 2023 10:30:15 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@infradead.org> Cc: David Howells <dhowells@redhat.com>, Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@kernel.org>, David Hildenbrand <david@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>, Logan Gunthorpe <logang@deltatee.com>, Hillf Danton <hdanton@sina.com>, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard <jhubbard@nvidia.com> Subject: [PATCH v13 07/12] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Thu, 9 Feb 2023 10:29:49 +0000 Message-Id: <20230209102954.528942-8-dhowells@redhat.com> In-Reply-To: <20230209102954.528942-1-dhowells@redhat.com> References: <20230209102954.528942-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757349305453053575?= X-GMAIL-MSGID: =?utf-8?q?1757349305453053575?= |
Series |
iov_iter: Improve page extraction (pin or just list)
|
|
Commit Message
David Howells
Feb. 9, 2023, 10:29 a.m. UTC
ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: John Hubbard <jhubbard@nvidia.com> cc: Al Viro <viro@zeniv.linux.org.uk> cc: David Hildenbrand <david@redhat.com> cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }