From patchwork Thu Feb 9 09:51:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 54832 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp240158wrn; Thu, 9 Feb 2023 01:52:51 -0800 (PST) X-Google-Smtp-Source: AK7set9cyIhxGl2JzMlg1hevFSHWR7gpiD82lDRY8fcPuF/p5CY+Nu++qswkw5RufjQoIp9z8Y50 X-Received: by 2002:a17:906:6b08:b0:887:8f6:c1d7 with SMTP id q8-20020a1709066b0800b0088708f6c1d7mr10671632ejr.38.1675936371312; Thu, 09 Feb 2023 01:52:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675936371; cv=none; d=google.com; s=arc-20160816; b=yvo2nWi/NZvAF5Tdm1YDocc6yD4p1e2jlD6GE951hxD8p7LB2WupGmUdC2lVQGl+XZ uUB891NavWv6JHVzCGOnYLfcutxb8PnQqp48GwPB9g5zzpdzyO2B85oKZpuCw0MVT6PS 4Rg1Ni/ok+wzLr2pmPhkzVsrWECdY4bYkitUrGPu4hwFW4/qYYqdd8q+9kmPd0Hdy3gF klE7AZ1ftPcLpH4YBYtwi6hFmWdnTHaBRjJ9uky8RVvFoXwoU4IFNHAgx3GS8mRdIz/H fUHC6lDVeJ9aMt23LWMY11Vkp73ka1Lok71LdBrxVK9WyCztwvyZ8Ba63dxMJX75bMWR PEGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iEqPo0Yv4Lv7obCFGHeVaKf4ZsFycgsPMXlF/hxQ1DI=; b=x+P8PBng1WIqij+mopPcQIkgQOqGvk69VMh0pVIlO8SvUJXC9/rbhb0D/chiZfgevb 40YY2+QDDsLhtC9Vg3i4L6k4FZ5k2IxAZKFO0PI+nOQlGEBQ2tVaL1Dew+VoHb9iZo3O hJNU6gSa3sSY2Ejfkj03tWbpx2izMGpA25qRKD54gFofZoRgebazNMwU52rTco5FpxPX KXg0eSCvJ6EAv/gqNmFSnM5OqEMS0aTrGyeqdQLafC1TSIkL7JJpxfhoO9h9Rf2PPMeQ JfajCm4DkO4hd54NQuJHkRaj87VaTuz8VsnITMls1NixQSZh3ZNLVqBehaF/jpVLx0Nf htWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fw31-20020a170907501f00b0084cbde35b49si1893801ejc.990.2023.02.09.01.52.28; Thu, 09 Feb 2023 01:52:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230333AbjBIJvu (ORCPT + 99 others); Thu, 9 Feb 2023 04:51:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbjBIJvb (ORCPT ); Thu, 9 Feb 2023 04:51:31 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D35611D5 for ; Thu, 9 Feb 2023 01:51:27 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ3aH-0005eW-QF; Thu, 09 Feb 2023 10:51:17 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pQ3aF-003i88-T7; Thu, 09 Feb 2023 10:51:17 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pQ3aF-001WrV-4O; Thu, 09 Feb 2023 10:51:15 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH net-next v7 7/9] net: phy: c45: migrate to genphy_c45_write_eee_adv() Date: Thu, 9 Feb 2023 10:51:11 +0100 Message-Id: <20230209095113.364524-8-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230209095113.364524-1-o.rempel@pengutronix.de> References: <20230209095113.364524-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757346656368214909?= X-GMAIL-MSGID: =?utf-8?q?1757346656368214909?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy-c45.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index b4910c4c21d7..ef36582adbeb 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -262,7 +262,11 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev) linkmode_and(phydev->advertising, phydev->advertising, phydev->supported); - changed = genphy_config_eee_advert(phydev); + ret = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (ret < 0) + return ret; + else if (ret) + changed = true; if (genphy_c45_baset1_able(phydev)) return genphy_c45_baset1_an_config_aneg(phydev); @@ -968,6 +972,11 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) } } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL_GPL(genphy_c45_pma_read_abilities);