From patchwork Thu Feb 9 09:51:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 54830 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp240005wrn; Thu, 9 Feb 2023 01:52:27 -0800 (PST) X-Google-Smtp-Source: AK7set8kvHgxVxBVsxhSXY05mDyBYa9vqyBS/tNWX4GvlBHlaoy7p1Lsxxtona/1x3A+bqKCziGy X-Received: by 2002:a17:906:2b8c:b0:87f:d17:66db with SMTP id m12-20020a1709062b8c00b0087f0d1766dbmr12619869ejg.52.1675936345952; Thu, 09 Feb 2023 01:52:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675936345; cv=none; d=google.com; s=arc-20160816; b=cbQvTX54rik7QVoOzw3qjQlYa1rCwY7Vhc/Pw5QJJdvi7d4K7nt0WbDLrYqzpL2FNF rNqtvWaAPEQSKl22RqvMMLMbxCZOwdH3S7WRsCQTyiMiPeFD/RFj0RyDWeU59fbVj6EU FWs2nAfED9HeF0s1fh9TUyebVW2c517Y2OM9IKNgChKMrTJ00comrZISxtGhFGYAbcvL NzRNELEpPgx4UtrvZQNn5bwUkfEWKKhO5TtZje1Cxm9w/7iROhzURQlq561i4cgAySHD SaOSTOg6iRhR+YfFiswfa+fhuMMdYPq8LiRV1PBD3wlvvPrP044CQGLH/nXmMpTpSuuO Tdxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=l4gBYZ4FFyfwNExA4b1jAGo0toCNg5dUVVJvW9PERjs=; b=ar+P1kp/BQQkJCfyZlkkMjqzxGl57h/2JSiTEfOG5vsK9t5jjkG0XTcr2xRt+VauuL FlRD7ruZxftf3cRgcyW2rS4ko8k6zvvgyoBF76Dx6g0YpUpNOxEBRc4iPM3S6MiPpKs3 nCNF9ILFLVdGX9YaZ5sPbRHByp4MGI+6jFOSy+8Hs1tfKQc7W3uX8d1wMQ/alH4rIMGU TnPvLplacwIbKZwstqh1HfJ6mvaN5GtnuP7fmKkRAszT6Q6FimeFnMzhff1ibEIw5Vj/ jCcej3s603KxYcc1nw/Pm+AUwk3TPM/vTbwCBaSu5OC2u/0QQI4ANtux/eNEw6AhIrYg RinA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 21-20020a170906029500b0087bdae31fd8si2614116ejf.518.2023.02.09.01.52.03; Thu, 09 Feb 2023 01:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbjBIJvl (ORCPT + 99 others); Thu, 9 Feb 2023 04:51:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230158AbjBIJva (ORCPT ); Thu, 9 Feb 2023 04:51:30 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CED9E47402 for ; Thu, 9 Feb 2023 01:51:27 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pQ3aH-0005eS-N3; Thu, 09 Feb 2023 10:51:17 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pQ3aF-003i7x-9e; Thu, 09 Feb 2023 10:51:16 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pQ3aF-001WrM-3o; Thu, 09 Feb 2023 10:51:15 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wei Fang , Heiner Kallweit Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH net-next v7 6/9] net: phy: c22: migrate to genphy_c45_write_eee_adv() Date: Thu, 9 Feb 2023 10:51:10 +0100 Message-Id: <20230209095113.364524-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230209095113.364524-1-o.rempel@pengutronix.de> References: <20230209095113.364524-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757346629932603073?= X-GMAIL-MSGID: =?utf-8?q?1757346629932603073?= Migrate from genphy_config_eee_advert() to genphy_c45_write_eee_adv(). It should work as before except write operation to the EEE adv registers will be done only if some EEE abilities was detected. If some driver will have a regression, related driver should provide own .get_features callback. See micrel.c:ksz9477_get_features() as example. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/phy/phy_device.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 66a4e62009bb..8d927c5e3bf8 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2231,7 +2231,10 @@ int __genphy_config_aneg(struct phy_device *phydev, bool changed) { int err; - if (genphy_config_eee_advert(phydev)) + err = genphy_c45_write_eee_adv(phydev, phydev->supported_eee); + if (err < 0) + return err; + else if (err) changed = true; err = genphy_setup_master_slave(phydev); @@ -2653,6 +2656,11 @@ int genphy_read_abilities(struct phy_device *phydev) phydev->supported, val & ESTATUS_1000_XFULL); } + /* This is optional functionality. If not supported, we may get an error + * which should be ignored. + */ + genphy_c45_read_eee_abilities(phydev); + return 0; } EXPORT_SYMBOL(genphy_read_abilities);