From patchwork Thu Feb 9 05:18:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingbo Xu X-Patchwork-Id: 54732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp138152wrn; Wed, 8 Feb 2023 21:22:01 -0800 (PST) X-Google-Smtp-Source: AK7set+Ge8MtkKbhMDCYjqm4oPKCSPo7USPi4PHEf7dw/8VTQMd9E0CR8859zitM9gCxqnjbAcSW X-Received: by 2002:a17:907:c12:b0:866:6b08:946b with SMTP id ga18-20020a1709070c1200b008666b08946bmr16353601ejc.39.1675920121252; Wed, 08 Feb 2023 21:22:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675920121; cv=none; d=google.com; s=arc-20160816; b=o0IH54eU858WXqSm/GuFcgPOxxn0WWq/Eb8X3qLaZMNlB+srwC6oJsmbNUdY2UbFxr K4fXXyebI4SGxlkHxRcIUS61K75abWQGx0QbzLZd6MMnjgi95xJILg0X4NjMjZrxujWl y3lUFtzYjVNIyZpPexulclMSprxpCWrYtd4Fu10pMUJC9Lpr65OzcVfOiXdsIUqRGqiF fcTuwm/GVfTgsJUWFSjPgFv4OILRk9hupzD/sSYRmKd20EnOTN7Yj71nx+O1DT6uc2kl FTsRXc02OIRZAgOS35A7FjpsZFSySXUiXqqdgw+UgrA0rsxe2sOry0XwH4t8N1dvJcAS f4ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Ojn4WbIebvtU/AuKHd8GFk+3oL+Lg8S06yrPxc+pEtA=; b=F9jhISMt45aVWXZXKIq1U9w5O6TH3RuNHn2Mmm3JxCwIdwQ2OLS6UucOHVOW+9LhnS rK8q8j8NYimzDy5XIDFLHABysENJgmbTpxbBU3+MBIZQQJwRBpzZIWnUClAmVmjB7Bs9 r6ZocF57M1sXrBz1PqefeiECl4nvWv5fZIZBnVBXQpY3Z0L57ahBQrzkUMr/b+a29K8F 6KfOZ/hDnZu2LOpouBX2gU0jH/XVmNLvAAsb00DYlLnTENmjJoKipOMNLZQxvWVEq43Y SoYUJ2bh9RfWSMOqjdtXYuLPgGIW8R1IZMF8A2x0vZiMzBU72M1S/Wn58U2ORaukAr90 gpZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m23-20020aa7d357000000b004a129012df6si1060889edr.150.2023.02.08.21.21.38; Wed, 08 Feb 2023 21:22:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229711AbjBIFTD (ORCPT + 99 others); Thu, 9 Feb 2023 00:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbjBIFSu (ORCPT ); Thu, 9 Feb 2023 00:18:50 -0500 Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D92452D15C for ; Wed, 8 Feb 2023 21:18:44 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VbEaujl_1675919920; Received: from localhost(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VbEaujl_1675919920) by smtp.aliyun-inc.com; Thu, 09 Feb 2023 13:18:41 +0800 From: Jingbo Xu To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, zhujia.zj@bytedance.com Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] erofs: relinquish volume with mutex held Date: Thu, 9 Feb 2023 13:18:37 +0800 Message-Id: <20230209051838.33297-4-jefflexu@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20230209051838.33297-1-jefflexu@linux.alibaba.com> References: <20230209051838.33297-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757329616705670651?= X-GMAIL-MSGID: =?utf-8?q?1757329616705670651?= Relinquish fscache volume with mutex held. Otherwise if a new domain is registered when the old domain with the same name gets removed from the list but not relinquished yet, fscache may complain the collision. Signed-off-by: Jingbo Xu Reviewed-by: Jia Zhu --- fs/erofs/fscache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 2f5930e177cc..a6f030966147 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -328,8 +328,8 @@ static void erofs_fscache_domain_put(struct erofs_domain *domain) kern_unmount(erofs_pseudo_mnt); erofs_pseudo_mnt = NULL; } - mutex_unlock(&erofs_domain_list_lock); fscache_relinquish_volume(domain->volume, NULL, false); + mutex_unlock(&erofs_domain_list_lock); kfree(domain->domain_id); kfree(domain); return;