diff mbox series

mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource()

Message ID 202302081734511884545@zte.com.cn
State New
Headers
Series mfd: qcom_rpm: use devm_platform_get_and_ioremap_resource() |

Commit Message

ye.xingchen@zte.com.cn Feb. 8, 2023, 9:34 a.m. UTC 
  From: Ye Xingchen <ye.xingchen@zte.com.cn>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
 drivers/mfd/qcom_rpm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Konrad Dybcio Feb. 8, 2023, 10:02 a.m. UTC | #1 
On 8.02.2023 10:34, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  drivers/mfd/qcom_rpm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 8fea0e511550..086611322874 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -530,7 +530,6 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *match;
>  	struct device_node *syscon_np;
> -	struct resource *res;
>  	struct qcom_rpm *rpm;
>  	u32 fw_version[3];
>  	int irq_wakeup;
> @@ -576,8 +575,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  	rpm->data = match->data;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	rpm->status_regs = devm_ioremap_resource(&pdev->dev, res);
> +	rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(rpm->status_regs))
>  		return PTR_ERR(rpm->status_regs);
>  	rpm->ctrl_regs = rpm->status_regs + 0x400;
Lee Jones March 3, 2023, 8:22 a.m. UTC | #2 
On Wed, 08 Feb 2023, ye.xingchen@zte.com.cn wrote:

> From: Ye Xingchen <ye.xingchen@zte.com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/mfd/qcom_rpm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks
diff mbox series

Patch

diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 8fea0e511550..086611322874 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -530,7 +530,6 @@  static int qcom_rpm_probe(struct platform_device *pdev)
 {
 	const struct of_device_id *match;
 	struct device_node *syscon_np;
-	struct resource *res;
 	struct qcom_rpm *rpm;
 	u32 fw_version[3];
 	int irq_wakeup;
@@ -576,8 +575,7 @@  static int qcom_rpm_probe(struct platform_device *pdev)
 		return -ENODEV;
 	rpm->data = match->data;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	rpm->status_regs = devm_ioremap_resource(&pdev->dev, res);
+	rpm->status_regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(rpm->status_regs))
 		return PTR_ERR(rpm->status_regs);
 	rpm->ctrl_regs = rpm->status_regs + 0x400;