diff mbox series

[v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties

Message ID 20230208171715.70862-1-conor@kernel.org
State New
Headers
Series [v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties |

Commit Message

Conor Dooley Feb. 8, 2023, 5:17 p.m. UTC 
  From: Conor Dooley <conor.dooley@microchip.com>

Commit 0c559bc8abfb ("dt-bindings: serial: restrict possible child node
names") exposed the Allwinner D1 devicetrees as users of unevaluated
properties, with a slew of similar warnings now appearing during
dtbs_check:
sun20i-d1-nezha.dtb: serial@2500400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected)

Document the missing properties.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
The commit exposing it is in Rob's tree, but I figure this can go either
way as it has no dependancy.
---
 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml      | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Krzysztof Kozlowski Feb. 9, 2023, 9:11 a.m. UTC | #1 
On 08/02/2023 18:17, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Commit 0c559bc8abfb ("dt-bindings: serial: restrict possible child node
> names") exposed the Allwinner D1 devicetrees as users of unevaluated
> properties, with a slew of similar warnings now appearing during
> dtbs_check:
> sun20i-d1-nezha.dtb: serial@2500400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected)
> 
> Document the missing properties.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index b9c2287c5d1e..2becdfab4f15 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -67,6 +67,14 @@  properties:
       - const: baudclk
       - const: apb_pclk
 
+  dmas:
+    minItems: 2
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
   snps,uart-16550-compatible:
     description: reflects the value of UART_16550_COMPATIBLE configuration
       parameter. Define this if your UART does not implement the busy functionality.