diff mbox series

[net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable

Message ID 20230208161249.329631-1-clement.leger@bootlin.com
State New
Headers
Series [net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable |

Commit Message

Clément Léger Feb. 8, 2023, 4:12 p.m. UTC 
  Remove unused bulk clocks struct from the miic state and use an already
existing miic variable in miic_config().

Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Feb. 10, 2023, 6:50 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  8 Feb 2023 17:12:49 +0100 you wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  drivers/net/pcs/pcs-rzn1-miic.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Here is the summary with links:
  - [net-next] net: pcs: rzn1-miic: remove unused struct members and use miic variable
    https://git.kernel.org/netdev/net-next/c/dc8c41320130

You are awesome, thank you!
Russell King (Oracle) Feb. 10, 2023, 11:05 a.m. UTC | #2 
On Wed, Feb 08, 2023 at 05:12:49PM +0100, Clément Léger wrote:
> Remove unused bulk clocks struct from the miic state and use an already
> existing miic variable in miic_config().
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks.
diff mbox series

Patch

diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c1424119e821..323bec5e57f8 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -121,15 +121,11 @@  static const char *index_to_string[MIIC_MODCTRL_CONF_CONV_NUM] = {
  * struct miic - MII converter structure
  * @base: base address of the MII converter
  * @dev: Device associated to the MII converter
- * @clks: Clocks used for this device
- * @nclk: Number of clocks
  * @lock: Lock used for read-modify-write access
  */
 struct miic {
 	void __iomem *base;
 	struct device *dev;
-	struct clk_bulk_data *clks;
-	int nclk;
 	spinlock_t lock;
 };
 
@@ -232,7 +228,7 @@  static int miic_config(struct phylink_pcs *pcs, unsigned int mode,
 	}
 
 	miic_reg_rmw(miic, MIIC_CONVCTRL(port), mask, val);
-	miic_converter_enable(miic_port->miic, miic_port->port, 1);
+	miic_converter_enable(miic, miic_port->port, 1);
 
 	return 0;
 }