diff mbox series

[v6,1/3] dt-bindings: cpufreq: qcom-cpufreq-nvmem: specify supported opp tables

Message ID 20230208153913.24436-1-ansuelsmth@gmail.com
State New
Headers
Series [v6,1/3] dt-bindings: cpufreq: qcom-cpufreq-nvmem: specify supported opp tables |

Commit Message

Christian Marangi Feb. 8, 2023, 3:39 p.m. UTC 
  Add additional info on what opp tables the defined devices in this schema
supports (operating-points-v2-kryo-cpu and operating-points-v2-qcom-level)
and reference them.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
Changes v6:
- No change
Changes v5:
- Swap patch 1 and patch 2 to fix dt_check_warning on single
  patch bisecting 
Changes v4:
- Add patch split from patch 1

 .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml  | 35 ++++++++++++++-----
 1 file changed, 26 insertions(+), 9 deletions(-)

Comments

Viresh Kumar Feb. 13, 2023, 5:04 a.m. UTC | #1 
On 08-02-23, 16:39, Christian Marangi wrote:
> Add additional info on what opp tables the defined devices in this schema
> supports (operating-points-v2-kryo-cpu and operating-points-v2-qcom-level)
> and reference them.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v6:
> - No change
> Changes v5:
> - Swap patch 1 and patch 2 to fix dt_check_warning on single
>   patch bisecting 
> Changes v4:
> - Add patch split from patch 1

Rob / Krzysztof,

I am looking to apply this patchset for next release if it is ready, are you
comfortable giving your Acks for the entire series yet ?
Krzysztof Kozlowski Feb. 13, 2023, 10:26 a.m. UTC | #2 
On 08/02/2023 16:39, Christian Marangi wrote:
> Add additional info on what opp tables the defined devices in this schema
> supports (operating-points-v2-kryo-cpu and operating-points-v2-qcom-level)
> and reference them.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 13, 2023, 10:27 a.m. UTC | #3 
On 13/02/2023 06:04, Viresh Kumar wrote:
> On 08-02-23, 16:39, Christian Marangi wrote:
>> Add additional info on what opp tables the defined devices in this schema
>> supports (operating-points-v2-kryo-cpu and operating-points-v2-qcom-level)
>> and reference them.
>>
>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>> ---
>> Changes v6:
>> - No change
>> Changes v5:
>> - Swap patch 1 and patch 2 to fix dt_check_warning on single
>>   patch bisecting 
>> Changes v4:
>> - Add patch split from patch 1
> 
> Rob / Krzysztof,
> 
> I am looking to apply this patchset for next release if it is ready, are you
> comfortable giving your Acks for the entire series yet ?

Look ok for me.

Best regards,
Krzysztof
Viresh Kumar Feb. 14, 2023, 5:26 a.m. UTC | #4 
On 08-02-23, 16:39, Christian Marangi wrote:
> Add additional info on what opp tables the defined devices in this schema
> supports (operating-points-v2-kryo-cpu and operating-points-v2-qcom-level)
> and reference them.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v6:
> - No change
> Changes v5:
> - Swap patch 1 and patch 2 to fix dt_check_warning on single
>   patch bisecting 
> Changes v4:
> - Add patch split from patch 1
> 
>  .../bindings/cpufreq/qcom-cpufreq-nvmem.yaml  | 35 ++++++++++++++-----
>  1 file changed, 26 insertions(+), 9 deletions(-)


Applied. Thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
index 9c086eac6ca7..7c42d9439abd 100644
--- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
@@ -55,15 +55,32 @@  properties:
 
 patternProperties:
   '^opp-table(-[a-z0-9]+)?$':
-    if:
-      properties:
-        compatible:
-          const: operating-points-v2-kryo-cpu
-    then:
-      patternProperties:
-        '^opp-?[0-9]+$':
-          required:
-            - required-opps
+    allOf:
+      - if:
+          properties:
+            compatible:
+              const: operating-points-v2-kryo-cpu
+        then:
+          $ref: /schemas/opp/opp-v2-kryo-cpu.yaml#
+
+      - if:
+          properties:
+            compatible:
+              const: operating-points-v2-kryo-cpu
+        then:
+          patternProperties:
+            '^opp-?[0-9]+$':
+              required:
+                - required-opps
+
+      - if:
+          properties:
+            compatible:
+              const: operating-points-v2-qcom-level
+        then:
+          $ref: /schemas/opp/opp-v2-qcom-level.yaml#
+
+    unevaluatedProperties: false
 
 additionalProperties: true