From patchwork Wed Feb 8 15:11:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 54457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3518751wrn; Wed, 8 Feb 2023 07:28:06 -0800 (PST) X-Google-Smtp-Source: AK7set/SRegIkQDTEefon1MfFMX+SFYfFJ41d+Kexqdj/HN0x7TgV/+pOJUpnOS6pgVZN6udUENf X-Received: by 2002:a17:906:51d7:b0:887:dbe1:25ac with SMTP id v23-20020a17090651d700b00887dbe125acmr6922435ejk.0.1675870085858; Wed, 08 Feb 2023 07:28:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675870085; cv=none; d=google.com; s=arc-20160816; b=nQAgW4hcz5u45ugoMUidNQRNbk3PzD+EWuFfnhqQYullBzr9Kio0CDUnTPCpIGKfVo +xhR2g+bVFlT21HxTzKMr/BW2tTsIgw+gWQnJJtbmzRP5Ki4bblQdTWLj6iFT0TCodJb C78uHrQMnSHPOj8nGhmTlZmRYyBGMHM/i3vcmZz2MNkwK953Ao0mFHrKv2tqf/HT3qvN Mzmo2sdtjxWOvJv2whvWAmcQo/zsHf4mwTXwBYBmzEd6+92qdMt6Q4z2NLC2O8Qz4I8z HdHw1VNIMEjZBENZjGDvUNpNFaqTXAI/DpCy0RReF/sD3cGxmVoxxwIHNPiQqYMEZL5+ wxcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A5Ne7Cb8wYkL6MGNEG/pwQGfYqlLFegp71K/0HXEMvo=; b=sZZirfrqBydQ3+JeJc4rf3uFMKbnK8/UDgHg7ToTMwGuCGtNcD7aAPEADDkp47pKxK a/r2Q7Oi0fN//NdRPGJZw1uBtmcGq3S8dn8+j2c9Y61jvpIbDp2Z3y2wA149Cxu4NvYO UxidjRkgrBwfr73zs/pTugRo7BtEI3YLLyysM0IAe36Sb0EWhx7B07NObUwgsePajt5S vh3cfYk8vpQmf78I6OJpZfMIdSktpC22rf/J44C41ziZGLIf1iSWsPZDUAlTn/9oU/zv CJo3aOaCqFtXYRHFb2kOwto3VrbRSJLEty7qlQ+rTvgVPagqvVhx87tKxro9a8MifY+P sgOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MxUWae7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay11-20020a170907900b00b0088ade20f185si17421804ejc.214.2023.02.08.07.27.42; Wed, 08 Feb 2023 07:28:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MxUWae7C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbjBHPQJ (ORCPT + 99 others); Wed, 8 Feb 2023 10:16:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231782AbjBHPQD (ORCPT ); Wed, 8 Feb 2023 10:16:03 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D83740BE5; Wed, 8 Feb 2023 07:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675869362; x=1707405362; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Ohp5bQqnI/OnKaRFcY242R1ns9uUyAH0LpsOgERaknw=; b=MxUWae7CJlDE8F3Q5vzjTs9ojCX2kTE2W0tJrxoHSNAj8gt/NdfwRk1Y Yb6Hfvro5U6s5Pccx6J0yAunKVQq6n2bVw8MeoLJAz+6gH+Sxrw89tdDs 8izQgRFj9sqrkHCM5TSt5/kN9Z1fvPjAHp0i7eiSH8PEEg4p7RdFC6+rU 84zL5+cvXluIkilxoDEKRSgvv6p2aprqnuIEh+whwZ08I1IykASrq8uc7 fxGdOY5aSBGgUB0SK3ygN/ylw7nPiWUxzoQUe6B/vtWo4ZD45D8eNQ9IF HSgH768SUVldABQIV0Tdm+JJq86AJTQNMDoPexBrmpHGCv2Kx06OtVJSs g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="317825125" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="317825125" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 07:10:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="776061115" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="776061115" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 08 Feb 2023 07:10:52 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id F3AF3252; Wed, 8 Feb 2023 17:11:30 +0200 (EET) From: Andy Shevchenko To: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mathias Nyman , Greg Kroah-Hartman , Andy Shevchenko Subject: [PATCH v2 4/7] xhci: mem: Drop useless return:s Date: Wed, 8 Feb 2023 17:11:26 +0200 Message-Id: <20230208151129.28987-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230208151129.28987-1-andriy.shevchenko@linux.intel.com> References: <20230208151129.28987-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757277151156184570?= X-GMAIL-MSGID: =?utf-8?q?1757277151156184570?= When function returns void and we have if-else-if chain, there is no need to explicitly call return. Drop them and indent lines better. While at it, make if-chain sorted from testing bigger values to smaller. Signed-off-by: Andy Shevchenko --- drivers/usb/host/xhci-mem.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 357883256a5a..fa0c4ac2ca7f 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -544,14 +544,11 @@ static void xhci_free_stream_ctx(struct xhci_hcd *xhci, size_t size = sizeof(struct xhci_stream_ctx) * num_stream_ctxs; if (size > MEDIUM_STREAM_ARRAY_SIZE) - dma_free_coherent(dev, size, - stream_ctx, dma); - else if (size <= SMALL_STREAM_ARRAY_SIZE) - return dma_pool_free(xhci->small_streams_pool, - stream_ctx, dma); + dma_free_coherent(dev, size, stream_ctx, dma); + else if (size > SMALL_STREAM_ARRAY_SIZE) + dma_pool_free(xhci->medium_streams_pool, stream_ctx, dma); else - return dma_pool_free(xhci->medium_streams_pool, - stream_ctx, dma); + dma_pool_free(xhci->small_streams_pool, stream_ctx, dma); } /*