| Message ID | 20230208112915.6543-1-jefflexu@linux.alibaba.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3403340wrn;
Wed, 8 Feb 2023 03:39:32 -0800 (PST)
X-Google-Smtp-Source:
AK7set94+GfukCG3WbBkoOwEM8J7Inh8zx1RwKFZeEITMkSheU+PSXvcgx2M8PTrjzX7x2ViLjVj
X-Received: by 2002:a17:90a:e38d:b0:22c:2483:2401 with SMTP id
b13-20020a17090ae38d00b0022c24832401mr218702pjz.2.1675856371752;
Wed, 08 Feb 2023 03:39:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675856371; cv=none;
d=google.com; s=arc-20160816;
b=ZG0PHGUobGHOINmHYAtZDFT6ZCNKDTzxIBdM6KsAluey21oytHumhVr7LICjjwVDfK
L9jxd6Lyym27m/gzVeXfgCsVpeRSJhJNX7Tj2hy/ebvM7u8fGRMd9/6g+GbJswZAoybQ
3+w9Zq6XsgiZo/MIUhUkyAv6yVd0aaCBsSikwfxLd2IxJ2T5AUC8kQPlopGmabetNsXF
wCgJ85ZyrA2bnRouqkYyQg0TjvRN1zZug35z7ZGIcX8WdWH1woPSEAuf0vItnHTIDAiz
RSJvGvfjeFXdWgDewsqwzkCvy2O4SexKFVg6tTcoIgUM5TTyUf8mwe9mmI/mYTEmsOrH
/DOw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=NTnp04I/SRh02sIOUAkY2Ai+IZMU5gzPlpelaSFhd9s=;
b=cncMeyW83XekBwkLaUUX/vw4zCPejB6Vq7PU0mddPkDfv6o3gN2dgvUZt6p0Wlzn3u
dY+ui4dokNXtzCZL2buIekNCtuzYl/f1v4R8MeOzW+tmeWcQea8HOg50YiLkwpJDVgh5
0vSm1rTitdtm8nj9gVDWPaTfEa0Q3mepmGZpIDiae7b8tb3ivkoYJ79LX67uL8LiTEf/
1jgWOMzkNq82knxP8Ua2HB2RfYYtGl5satIFenJ7ky6GRWD9CGzUnf/NwkpQH+j4Pll8
Bv7ObWxXiWo839+BI52+hbYiVgxHR/okqkzKY7DQEOaIKc8NtO53Ot2erXP3JFsdlYC+
UEwg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e10-20020a17090a804a00b00231141b9011si1478620pjw.97.2023.02.08.03.39.19;
Wed, 08 Feb 2023 03:39:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230515AbjBHL3V (ORCPT <rfc822;ivan.orlov0322@gmail.com>
+ 99 others); Wed, 8 Feb 2023 06:29:21 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57192 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230236AbjBHL3T (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 8 Feb 2023 06:29:19 -0500
Received: from out30-97.freemail.mail.aliyun.com
(out30-97.freemail.mail.aliyun.com [115.124.30.97])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B1D93CE33
for <linux-kernel@vger.kernel.org>;
Wed, 8 Feb 2023 03:29:17 -0800 (PST)
X-Alimail-AntiSpam:
AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VbBr6Y5_1675855755;
Received: from localhost(mailfrom:jefflexu@linux.alibaba.com
fp:SMTPD_---0VbBr6Y5_1675855755)
by smtp.aliyun-inc.com;
Wed, 08 Feb 2023 19:29:15 +0800
From: Jingbo Xu <jefflexu@linux.alibaba.com>
To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org,
huyue2@coolpad.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] erofs: update print symbols for various flags in trace
Date: Wed, 8 Feb 2023 19:29:14 +0800
Message-Id: <20230208112915.6543-1-jefflexu@linux.alibaba.com>
X-Mailer: git-send-email 2.19.1.6.gb485710b
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00,
ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,
USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757262771342894758?=
X-GMAIL-MSGID: =?utf-8?q?1757262771342894758?=
|
| Series |
[v2,1/2] erofs: update print symbols for various flags in trace
|
|
Commit Message
Jingbo Xu
Feb. 8, 2023, 11:29 a.m. UTC
As new flags introduced, the corresponding print symbols for trace are
not added accordingly. Add these missing print symbols for these flags.
Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to
be removed soon.
Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
---
v2: remove print symbol for EROFS_GET_BLOCKS_RAW
---
include/trace/events/erofs.h | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
Comments
On 2023/2/8 19:29, Jingbo Xu wrote: > As new flags introduced, the corresponding print symbols for trace are > not added accordingly. Add these missing print symbols for these flags. > > Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to > be removed soon. > > Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> > --- > v2: remove print symbol for EROFS_GET_BLOCKS_RAW > --- > include/trace/events/erofs.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h > index e095d36db939..cf4a0d28b178 100644 > --- a/include/trace/events/erofs.h > +++ b/include/trace/events/erofs.h > @@ -19,12 +19,17 @@ struct erofs_map_blocks; > { 1, "DIR" }) > > #define show_map_flags(flags) __print_flags(flags, "|", \ > - { EROFS_GET_BLOCKS_RAW, "RAW" }) Should we remove this in the next patch? Otherwise it looks good to me. Thanks, Gao XIang > + { EROFS_GET_BLOCKS_FIEMAP, "FIEMAP" }, \ > + { EROFS_GET_BLOCKS_READMORE, "READMORE" }, \ > + { EROFS_GET_BLOCKS_FINDTAIL, "FINDTAIL" }) > > #define show_mflags(flags) __print_flags(flags, "", \ > - { EROFS_MAP_MAPPED, "M" }, \ > - { EROFS_MAP_META, "I" }, \ > - { EROFS_MAP_ENCODED, "E" }) > + { EROFS_MAP_MAPPED, "M" }, \ > + { EROFS_MAP_META, "I" }, \ > + { EROFS_MAP_ENCODED, "E" }, \ > + { EROFS_MAP_FULL_MAPPED, "F" }, \ > + { EROFS_MAP_FRAGMENT, "R" }, \ > + { EROFS_MAP_PARTIAL_REF, "P" }) > > TRACE_EVENT(erofs_lookup, >
On 2/9/23 10:29 AM, Gao Xiang wrote: > > > On 2023/2/8 19:29, Jingbo Xu wrote: >> As new flags introduced, the corresponding print symbols for trace are >> not added accordingly. Add these missing print symbols for these flags. >> >> Also remove the print symbol for EROFS_GET_BLOCKS_RAW as it is going to >> be removed soon. >> >> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com> >> --- >> v2: remove print symbol for EROFS_GET_BLOCKS_RAW >> --- >> include/trace/events/erofs.h | 13 +++++++++---- >> 1 file changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h >> index e095d36db939..cf4a0d28b178 100644 >> --- a/include/trace/events/erofs.h >> +++ b/include/trace/events/erofs.h >> @@ -19,12 +19,17 @@ struct erofs_map_blocks; >> { 1, "DIR" }) >> #define show_map_flags(flags) __print_flags(flags, "|", \ >> - { EROFS_GET_BLOCKS_RAW, "RAW" }) > > Should we remove this in the next patch? > Otherwise it looks good to me. > Okay I will update this in the next version.
diff --git a/include/trace/events/erofs.h b/include/trace/events/erofs.h index e095d36db939..cf4a0d28b178 100644 --- a/include/trace/events/erofs.h +++ b/include/trace/events/erofs.h @@ -19,12 +19,17 @@ struct erofs_map_blocks; { 1, "DIR" }) #define show_map_flags(flags) __print_flags(flags, "|", \ - { EROFS_GET_BLOCKS_RAW, "RAW" }) + { EROFS_GET_BLOCKS_FIEMAP, "FIEMAP" }, \ + { EROFS_GET_BLOCKS_READMORE, "READMORE" }, \ + { EROFS_GET_BLOCKS_FINDTAIL, "FINDTAIL" }) #define show_mflags(flags) __print_flags(flags, "", \ - { EROFS_MAP_MAPPED, "M" }, \ - { EROFS_MAP_META, "I" }, \ - { EROFS_MAP_ENCODED, "E" }) + { EROFS_MAP_MAPPED, "M" }, \ + { EROFS_MAP_META, "I" }, \ + { EROFS_MAP_ENCODED, "E" }, \ + { EROFS_MAP_FULL_MAPPED, "F" }, \ + { EROFS_MAP_FRAGMENT, "R" }, \ + { EROFS_MAP_PARTIAL_REF, "P" }) TRACE_EVENT(erofs_lookup,