From patchwork Wed Feb 8 07:32:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingbo Xu X-Patchwork-Id: 54241 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3314240wrn; Tue, 7 Feb 2023 23:37:40 -0800 (PST) X-Google-Smtp-Source: AK7set+96OfRE365QhWneEXJ5qnHSfCFOZ0M4A2/lIVWawt0yiz3NcEyM3eH0pFkwyKdrQMnrw14 X-Received: by 2002:a17:906:6557:b0:885:d02f:d4ad with SMTP id u23-20020a170906655700b00885d02fd4admr7130659ejn.43.1675841860756; Tue, 07 Feb 2023 23:37:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675841860; cv=none; d=google.com; s=arc-20160816; b=JVFH956iQVZ0l42cWTJP5eNWz/ksFlfnPSHzd26YMPstp74if6QRVPDTGpYUao46Q7 z95b50mms/i1pavU2vCDEZOK2mFhSEELrsvfnL6gie/P9e4zROhOBFOgffmHDJTxLYDZ grsP5OPJqOxu6utfkRqQ1HJl3kzB9AM5gZ5i7gnzfn0bHR0C0IWZNJ/IWQCXZueDaEHs +i0njZVcdbPkrbFWFNqhgTGwj7jg9ZvmahCdB0Pb3UOunvS3JKA17Y9V13q5LrNQTJAg CN+Ya3lTC3hQs+0ED+MDgmX8m2dpIytHZabPlIFVRs66gWjnbNJCXfeg4jUY3rHeEzys ECLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0KQhDyjj8wxpUXGwEhi7HNV/sVPkit/y/4T409bRdy4=; b=k66u8pOBS34GmCHaSO3CW6qjnkm/tTpirdvRGKRydyYh8Gn5eZTXDlhBfB8Pq/fWJH w/pLhbBJokM+Fwm/os+V0p6caMQrbvgvNKp6vHb/wGeLUopbVVnoh6xFAYI3AsqcpKBe 3jTippUBvqgi/PYWT2DTs0TyVMJkdaaBg47wAyAib/MSV1JHdyN+/3AetK+AKEsDUA0C Lw09ZLSCPNkMmDsfcLaNsZrwlcPlTwaD+oYjPojVpKfiWY3Wh+9SBfqgS18L7b0I9sJQ pgR1FljJjR2BE5Tts31gXpFJfM2GxTGu/YlRk8xwt8Ti4KhFGGonjT4Cr0HoNNCsV9/Q guDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fl1-20020a1709072a8100b008879a229025si17501086ejc.333.2023.02.07.23.37.18; Tue, 07 Feb 2023 23:37:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230511AbjBHHcQ (ORCPT + 99 others); Wed, 8 Feb 2023 02:32:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbjBHHcO (ORCPT ); Wed, 8 Feb 2023 02:32:14 -0500 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 058A7301BD for ; Tue, 7 Feb 2023 23:32:10 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R621e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VbB.w4-_1675841526; Received: from localhost(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VbB.w4-_1675841526) by smtp.aliyun-inc.com; Wed, 08 Feb 2023 15:32:07 +0800 From: Jingbo Xu To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, zhujia.zj@bytedance.com Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org Subject: [PATCH] erofs: relinquish volume with mutex held Date: Wed, 8 Feb 2023 15:32:06 +0800 Message-Id: <20230208073206.111814-1-jefflexu@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757247555278399277?= X-GMAIL-MSGID: =?utf-8?q?1757247555278399277?= Relinquish fscache volume with mutex held. Otherwise if a new domain is registered when the old domain with the same name gets removed from the list but not relinquished yet, fscache may complain the collision. Signed-off-by: Jingbo Xu Reviewed-by: Jia Zhu --- fs/erofs/fscache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 8da6e05e9d23..35b2d8b5773e 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -328,8 +328,8 @@ static void erofs_fscache_domain_put(struct erofs_domain *domain) kern_unmount(erofs_pseudo_mnt); erofs_pseudo_mnt = NULL; } - mutex_unlock(&erofs_domain_list_lock); fscache_relinquish_volume(domain->volume, NULL, false); + mutex_unlock(&erofs_domain_list_lock); kfree(domain->domain_id); kfree(domain); return;