From patchwork Wed Feb 8 03:56:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qi Zheng X-Patchwork-Id: 54171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3245632wrn; Tue, 7 Feb 2023 20:22:41 -0800 (PST) X-Google-Smtp-Source: AK7set9FETNTsxUMp1IiXn12hLVPF4Wi12oiolcSWbaKHA8QrupjGlqmIB/HR02qJoNJvr9Geinx X-Received: by 2002:a17:906:4344:b0:7c0:d609:6f9b with SMTP id z4-20020a170906434400b007c0d6096f9bmr5312553ejm.27.1675830161527; Tue, 07 Feb 2023 20:22:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675830161; cv=none; d=google.com; s=arc-20160816; b=myll3KQ4oPyM9FwJTbX68GKevKWxXjrjD6pnL5i9hxNnl8e0Cz3pgwa7eY6+Q3+6d3 IkQ5As9zA+63OnJxZ4V+nbGfAxDeWa9eFGhtLGfxIoXB94JFyPINFaA96ZGW3BIAkFu4 lkMhWBuz3vO+pmWChoYd1nWTYeNI6TekJwt++9S93beaLARg8x7pRlq6UG1xQytKJ6oo OLs9VbzYf0ZFoBC5hERFQqmFNiNKvFjD/8KaG/Mpxpoq875WaCvSZ7x2VrQ68cJz/45I dkOa8y88SMHo8BBHzFw7CRi8+a1Q+RHY898Rw1Xm2uQAI5hIzNmbbamIHP8QxejJ9rJo ex4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gA/N6WjRUkdpSiAt5NvwWZJ+QdB8myl68ieEPOp24Nk=; b=qrSp8SEBlZ0yhiWbf0T5DupxZylGnjCPLIWeOFVjKPnKvicvwelzd1Oe5f0IdJTcb5 zDncUlKJclI35T/4WaMt9aKgypeS+Y3shgU/NGXmr+/95vjM0Vk8nuKywOhxmKNpZh2X cUf34Z28S33KxqerBLYV7OhPQpjLVbV+Hxp4yWwW6jL219YGKsMZJ1UP/WYk1U+6J9Dy v89iDOO4J31ZPbAnotmodbz/f07P5FFQRloxLe2WwddnWwBZUD6f+KK/xqwhBWf20xft 0uSeNpvU9ofrVMYyNa0ZNsThZ8OWDEF/aHBoqPEKtsUVQLuwh/5ZKuvQxTXtOIIX2hzy 22xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=N8W4ieqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 29-20020a170906101d00b00877817a13ddsi21818835ejm.878.2023.02.07.20.22.12; Tue, 07 Feb 2023 20:22:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=N8W4ieqX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbjBHD4p (ORCPT + 99 others); Tue, 7 Feb 2023 22:56:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbjBHD4o (ORCPT ); Tue, 7 Feb 2023 22:56:44 -0500 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40872EC58 for ; Tue, 7 Feb 2023 19:56:43 -0800 (PST) Received: by mail-pg1-x52a.google.com with SMTP id a23so11828468pga.13 for ; Tue, 07 Feb 2023 19:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gA/N6WjRUkdpSiAt5NvwWZJ+QdB8myl68ieEPOp24Nk=; b=N8W4ieqXIpq1Bxz6LZTNxYRv/8L0q7VMwfWdyePheec0D74XI5lftURogx16F44Gpl 9vl0ozqhs8ykd0z58bDbGQDxP/e0lw3IzoomivU0BoFKTlcq9AcVIOPAwqCIuPaZEcDn QMXIZCkflh3EbQPuXvtMQZ38QKhclF1FYOg+ONKps91GWiVzrsZWopXgGHKgjUezbQAV 928VlAIVvH0N3wdI8q24DMDtF5ZLPtOpCGmw8pSMuHVx9X+/8QJ1kvs8E/PMAEOG3P1c AMFPhc7nD9s2bZrm+GT6b0Mg4KVSFO4m6sJmF4QU89nLqiN7GGJqf+18BH6VmM/SbwW/ KEYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gA/N6WjRUkdpSiAt5NvwWZJ+QdB8myl68ieEPOp24Nk=; b=44iDQViSSsz7KuIDBMCWhO0azV1jG7LGzgoqk03aYA0ImMZWk97SC5xsMkVQYt+XbA HI7Z1pphpcOQJM2OSuDCkHGkDTqSZiKw976D+dfbU5pR0BcjpxfOZGF2CcpgRjOV5k9s psNhFiPIPS7JnpVMqOVoNl1cakCBLuCT8iOUzeBEMckgjhcbb7SDaWp+ZWkmM1Cc8+oG VVJT5KcQDbbJUhzunUC9ovPF0b+HaP3WqlcoUggkil/CpQXyFmXuzbim7zWQcpCppwht f3c+yGy2Mz+yqJN8VRDAtVi/jDympXdqWQqVpkLQwYxptd8uGBWHncg2mdDU2kT6p4Z4 SH3g== X-Gm-Message-State: AO0yUKXmJOb/uIuRCB7duf1aI25K2t4Uuoc9AAQLnhNmSt4+6XmujTbi +XWmIaH2sg5Hg9D4koOEya0INaajUneXd9c3 X-Received: by 2002:a62:a118:0:b0:592:5e1d:8d03 with SMTP id b24-20020a62a118000000b005925e1d8d03mr4963370pff.2.1675828602723; Tue, 07 Feb 2023 19:56:42 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.226]) by smtp.gmail.com with ESMTPSA id a1-20020aa780c1000000b00592591d1634sm10214560pfn.97.2023.02.07.19.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 19:56:42 -0800 (PST) From: Qi Zheng To: gregkh@linuxfoundation.org, rafael@kernel.org Cc: linux-kernel@vger.kernel.org, Qi Zheng Subject: [PATCH RESEND] debugfs: update comment of debugfs_rename() Date: Wed, 8 Feb 2023 11:56:34 +0800 Message-Id: <20230208035634.58095-1-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757235287537805329?= X-GMAIL-MSGID: =?utf-8?q?1757235287537805329?= Since commit ff9fb72bc077 ("debugfs: return error values, not NULL") changed return value of debugfs_rename() in error cases from %NULL to %ERR_PTR(-ERROR), the comment of debugfs_rename should also be updated so as not to mislead readers. Signed-off-by: Qi Zheng --- Resend as a separate patch. fs/debugfs/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 2e8e112b1993..58a35afb7c5d 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -802,8 +802,8 @@ EXPORT_SYMBOL_GPL(debugfs_lookup_and_remove); * exist for rename to succeed. * * This function will return a pointer to old_dentry (which is updated to - * reflect renaming) if it succeeds. If an error occurs, %NULL will be - * returned. + * reflect renaming) if it succeeds. If an error occurs, %ERR_PTR(-ERROR) + * will be returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be * returned.