From patchwork Wed Feb 8 01:56:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 54140 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3198267wrn; Tue, 7 Feb 2023 18:03:38 -0800 (PST) X-Google-Smtp-Source: AK7set9MMLa5pq96PtNbZ5XKj1paR1DtwFy9FMvtkrrOp4yvWSYGvcP2KxkedSeoqylVlojXxe7O X-Received: by 2002:a50:a41d:0:b0:48e:c0c3:7974 with SMTP id u29-20020a50a41d000000b0048ec0c37974mr5767180edb.12.1675821818307; Tue, 07 Feb 2023 18:03:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675821818; cv=none; d=google.com; s=arc-20160816; b=Ya+eVkIlYBF+B/c92i8SX8oixK00k/Rj4yt3l/vUNYXWjuO3is6e7T1KO1DQWnvZjf ukf2DwT/ZUAZW9r7PTVaxtNibLe+ZtQwk9N8NkolkamGWcp/b5QjGfK09yVie+um3TYR UliYpxPUHEgsCVVAU+VkHUByzRANBfqlMHi39gb4+OWTTa44EOIA7VyIwsW2XsyZVc4i /+MAA4zrMK/TVvhDwDlcRmfMeQEYN4bx4YuqrNYFKNw2Qs6kEuOH2udderGbidwtk9iw n1GBRvjpe6KtzG8rxF/0oNcUrn+uutiWRKrTuLQA0jPR9bohOj6PtEljcgJ9kOu56d5f cjbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=+LyZ5knzlCy3CwSjJfWQnlmebrDthUqxKUUhuwXLIxQ=; b=NMQAUKJOvCeW0EKrPA+UDaQPVp9KdDI/X84+N4Ocr+JkbeKZ+YiTyqgoFZUOLTBZIj 8XeAfbMZYMvQ+/se9K1xwuj39/P58TU71TQ7SV/9RH+kY2l5x68Aqp5N267N1DTZYNzA d4rCbNIaaPwjxhRbTeUPCXSz/IY91Lht3N0RRAzEEJ2gm4lgHHuDWOqSbO80gd5juXEN Nari99vSyAEqw59fXwxHVSDiLlM6I/kBgH3ZCAEdakZcjSW12R7QO/Om7om85lG7EK2j efEi+9z+t3sIfRidl5tIAWQUcBnZsnkvm59vPsTzm19KJ65JaKxsEBSvTZ++miXROwpB Xrxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id et8-20020a056402378800b004a25229c40asi16453377edb.222.2023.02.07.18.03.15; Tue, 07 Feb 2023 18:03:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230103AbjBHB6I (ORCPT + 99 others); Tue, 7 Feb 2023 20:58:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229831AbjBHB5g (ORCPT ); Tue, 7 Feb 2023 20:57:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FAC93F283 for ; Tue, 7 Feb 2023 17:57:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B47DCB81B9C for ; Wed, 8 Feb 2023 01:57:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DE81C4339E; Wed, 8 Feb 2023 01:57:32 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pPZiF-006dOi-1P; Tue, 07 Feb 2023 20:57:31 -0500 Message-ID: <20230208015731.258171441@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 07 Feb 2023 20:56:38 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Arnd Bergmann , Mark Rutland Subject: [for-next][PATCH 05/11] ftrace: sample: avoid open-coded 64-bit division References: <20230208015633.791198913@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757226538869946101?= X-GMAIL-MSGID: =?utf-8?q?1757226538869946101?= From: Arnd Bergmann Calculating the average period requires a 64-bit division that leads to a link failure on 32-bit architectures: x86_64-linux-ld: samples/ftrace/ftrace-ops.o: in function `ftrace_ops_sample_init': ftrace-ops.c:(.init.text+0x23b): undefined reference to `__udivdi3' Use the div_u64() helper to do this instead. Since this is an init function that is not called frequently, the runtime overhead is going to be acceptable. Link: https://lore.kernel.org/linux-trace-kernel/20230130130246.247537-1-arnd@kernel.org Cc: Masami Hiramatsu Fixes: b56c68f705ca ("ftrace: Add sample with custom ops") Signed-off-by: Arnd Bergmann Acked-by: Mark Rutland Signed-off-by: Steven Rostedt (Google) --- samples/ftrace/ftrace-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/ftrace/ftrace-ops.c b/samples/ftrace/ftrace-ops.c index 24deb51c7261..0c8da87ff5c3 100644 --- a/samples/ftrace/ftrace-ops.c +++ b/samples/ftrace/ftrace-ops.c @@ -223,7 +223,7 @@ static int __init ftrace_ops_sample_init(void) pr_info("Attempted %u calls to %ps in %lluns (%lluns / call)\n", nr_function_calls, tracee_relevant, - period, period / nr_function_calls); + period, div_u64(period, nr_function_calls)); if (persist) return 0;