From patchwork Tue Feb 7 20:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 54072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3073521wrn; Tue, 7 Feb 2023 13:00:57 -0800 (PST) X-Google-Smtp-Source: AK7set+NupxCHw0wV++smF/mpr2FbK08P6myBH20xmMU1vm0dKR/RX9XIJcVmKwIuRb1yydirjNP X-Received: by 2002:a05:6a20:12ce:b0:be:d368:5c63 with SMTP id v14-20020a056a2012ce00b000bed3685c63mr5740381pzg.38.1675803657247; Tue, 07 Feb 2023 13:00:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675803657; cv=none; d=google.com; s=arc-20160816; b=IkK8wTOZUVEKMqbUnaDmzWopcYYjfWyoaP6Coqa9Sir9Ss2WrYRbh0/J/QgCDViqNW qrQ3Ol3o0+OHfbS+IMlUStgQdKBrjyYTwU5EAmZ0zI7JNQzGkkpkg7wwtIYNmeVhsC0M n09guSZQjjjb63q7Cp9FIDdXJggBxR2L5+xoRBDX+/RFeuvnItRMk8KDSu3u4wVAHdCZ Dl4rM8NiU61JgnfSWEBHKriI7C+ndccuDG71JhXIx8bjJT7H82HSOyOv46ahgMOUgYPo qgvN8dbdPe7xkqezlCDjKxKQDhV6IFhfQAfElCbiVCo9CVzp3Fadt8Z8tKZQzbQ4jzHe BDwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=ss0VkBTwj6MMwAj4H2CFqZxsCitMPecAxpP3beza1Ha5L5U921Jw3UFNb6LIyJhmPa UAvlrcqEBAylfQ2k40PbifGa3yki47tzMU90eaV8lha2YKdBR9uuMmJnZdc5i5XA4p1r w4lVr+mhGRROAXk6eAW5ce0/rblqYWStiJmgh1FXjKKZSdVzvkm/q7NXy6vS54iFPN23 n1uAaWiRyKSthqt7FL1XOgVHtvtgOouZLLDYYHymjH6ocu+/r7tPXHssblBUhO6ogEfg c/mP2+oskA0bks6pIeM1F9z5bh4ZOHgraPVQXI50IHLihDiTa98MAzE/kbom3yFNEpjn 3Ucg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqtTAyD+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s27-20020a63925b000000b004a5c9673b66si16441433pgn.323.2023.02.07.13.00.42; Tue, 07 Feb 2023 13:00:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DqtTAyD+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbjBGU6x (ORCPT + 99 others); Tue, 7 Feb 2023 15:58:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjBGU6r (ORCPT ); Tue, 7 Feb 2023 15:58:47 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBE71420A for ; Tue, 7 Feb 2023 12:58:45 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id az4-20020a05600c600400b003dff767a1f1so14864wmb.2 for ; Tue, 07 Feb 2023 12:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=DqtTAyD+/DfVIXIixTTLeibbPWfARnoKPtZ503G/plOAdpSOZov9AsNRpB3pUQJUCv 5FCNQSbkC0AV7x/c4JKBbGIsoJuPYgqyzs2xF/miMtoLpyWrGtikd+RQT0vvCwpOV1c/ LVTXvBnhyoXTiKlSEA51+3WcZhlTyji8x5IDX0Mn2tghG16exPAaIpGzWridsqZMAxkx VxKKiazE0E9AuPVSkwv+0S9b9bro79BmeeJuIJsR8uaXenubEjuo5LA+Zoz2D1YzSnPv MGCiAbPamcfmHPYxaGJLC6H7KwYpZsFvUAOhnYsAIRJaKV7/5/MSyTniqrwxKqarbPsk QrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=hN7V3BZzWtgFT6QM3pdHscN4+RTz7cUpjpTwKjzR8cQ90bUaSKdvAWsZP8KqSptXXN vwgwK5lR7+XhJEghqzx/apKiG9O7WTjR4fTM/DoxnsFwIgWxV0EVtS0hCl4kbNQ3Swbs hvvpQzxT9V77Eh7pbc7esg3KgYZqWMAunkWcYk7kUoX/JQRlPcLOPNTziLDQQhodNo9/ kHrIxGo51vzy9DofWWNwpdhbGQy9CJ39vZxAfMMjTYpZW7dlzSFU8Cm3Jl+xiktF+KLs u0zrTogFGOC43PobTR+pLYLsZ/rT+IFYH/ST0KKhYRl29IWulX43PGoHSXSEGBtgZqY1 rwqw== X-Gm-Message-State: AO0yUKWNF8ZLfg4KH40z7U02bUvSwV3ZFM5TkeMR2lZKcoDfqXFYfjT2 Cgu1twtMdIamqN3ARiBSGBs9Ww== X-Received: by 2002:a05:600c:4383:b0:3dc:57e8:1d1c with SMTP id e3-20020a05600c438300b003dc57e81d1cmr5511078wmn.9.1675803524727; Tue, 07 Feb 2023 12:58:44 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:44 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/4] media: samsung: exynos4-is: do not require pinctrl Date: Tue, 7 Feb 2023 21:58:33 +0100 Message-Id: <20230207205834.673163-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757207496033536306?= X-GMAIL-MSGID: =?utf-8?q?1757207496033536306?= Driver does not handle pin configuration switching and several DTS provide empty pinctrl property, just to satisfy the driver's requirement for it. Drop requirement for pinctrl property as it is really optional. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..22baa429ed5d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1470,10 +1470,8 @@ static int fimc_md_probe(struct platform_device *pdev) goto err_v4l2dev; pinctrl = devm_pinctrl_get(dev); - if (IS_ERR(pinctrl)) { - ret = dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); - goto err_clk; - } + if (IS_ERR(pinctrl)) + dev_dbg(dev, "Failed to get pinctrl: %pe\n", pinctrl); platform_set_drvdata(pdev, fmd);