From patchwork Tue Feb 7 19:36:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 54060 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3043499wrn; Tue, 7 Feb 2023 11:49:26 -0800 (PST) X-Google-Smtp-Source: AK7set8F8CV854ezWuMIMqMdq2j4HYwPjti6isXqHkXURo7/Xpa4qPFWcnNUm3JAVzX+ffRZvJ+c X-Received: by 2002:a17:906:5fcb:b0:88d:ba89:183e with SMTP id k11-20020a1709065fcb00b0088dba89183emr223271ejv.15.1675799366468; Tue, 07 Feb 2023 11:49:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675799366; cv=none; d=google.com; s=arc-20160816; b=yGX1olOIirnsRydOsznXPGThCGx1Guckam6CA66m6NCC8bo5q44NUwREsPJlceprmF pjvSJ4DKG80OD182hqLU8Qm5gtgduX0FPkl55CFp+dTniGoZMHYJGY+iJB+ouE9uBuJ4 A0SWChmos0hAb0eYJTcaFdQJs8S5aGXE/vWNjbwnFVITVmMW2tssNB/ZC3BSvGNwCktV yCzQ/c+jOqO0xSptbh4Jxk92hcYSl+5I0LDzsZMv2xsNE2xzLQxyMtEI7ue8rHM0N8yq WP8FKRp7UIF3XSh0gW3YU+ANNicJeavEUgTz3Yj+6o6WYSc5JA5/qNWHgrEbT2zF/Bh9 nihw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hfXeR45OTlf46WdfcJvbrExsR5q3KTc9eN+T7c6WaJE=; b=W9uf+f3Hp1VZhJVxz1qoYWu3kL6p37gwhhbwcQpnPesyznknjcE8gmFVywdYpftEdi avsH07BV9dHPtp8q4jFyBaMvgQy1fkrMRig1A7VVinhJp70QB1X0d+3BDnUFlPp2/6h0 uOSx/AgL7A05axu562kr4WI/SgCsvalBLzlKWWaFyWKBfS4YrfoAPC6ZzEF7D/v/dl7K 689TS9a+GM1R/Y97owNHdSGCq1KUCskRCksPk1+uA/ZUADxqScrBeKqlY3g0j91qivuH BDuF+faWMpMQKKgq74abYLnxiJDpuuORhmElL5r+UgBZPt7xCfgGV/9en3Zu6kNAjC8D 86pA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a1709062a4800b0087da417217csi18087570eje.472.2023.02.07.11.49.01; Tue, 07 Feb 2023 11:49:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231929AbjBGTgq (ORCPT + 99 others); Tue, 7 Feb 2023 14:36:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbjBGTgo (ORCPT ); Tue, 7 Feb 2023 14:36:44 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53F213B655 for ; Tue, 7 Feb 2023 11:36:43 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPTlh-0002Ed-5t; Tue, 07 Feb 2023 20:36:41 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pPTlf-003Lyz-3z; Tue, 07 Feb 2023 20:36:40 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pPTlf-001f1F-5t; Tue, 07 Feb 2023 20:36:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Daniel Lezcano , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] clocksource: sh_tmu: Mark driver as non-removable Date: Tue, 7 Feb 2023 20:36:14 +0100 Message-Id: <20230207193614.472060-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1600; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=afhwFKHRjhQ+oOEhse1rmYXhTcETjLrPHQTUdsZj0bc=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBj4qgrFqzYI6Osku9IVoAZG+RGoTT/q6ylKX/lqW5T 9aDGHiOJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY+KoKwAKCRDB/BR4rcrsCafcB/ sEVBACqsLCa429wTvBKpOmPWXp8LfXJ4x8aBdrRodxeOahqecDjWAaXqpcgGS7yCty4xmyuBE7/UkL 6qir37XunUl9hf+mRlTS38fQh2aOF0rB0JqTzpCuk2F5VhI4sgLgZjvjYt4caS9mcgLg9xy5xXi0t7 pINVvGNjoaYTKwR9JDT8VvTjpBnvkbzCzWX4cDHEm/vV4QC3TGPaKOE9zNNwBbHNzcc4lVekIuGloO ZjWSQbWdQpDiIKuwa1uFv+zt+U5QMBj1df0rX3EH/AqVgGLLYdfAkIiH8OXIJTxz1Ar13ivqMrE2I+ ABqcAwAEFOBnHzLMxH+3M7ONYbS2lV X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757202996233564496?= X-GMAIL-MSGID: =?utf-8?q?1757202996233564496?= The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a sh_tmu device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König --- drivers/clocksource/sh_tmu.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) base-commit: 05ecb680708a1dbe6554d6fc17e5d9a8a7cb5e6a diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c index b00dec0655cb..932f31a7c5be 100644 --- a/drivers/clocksource/sh_tmu.c +++ b/drivers/clocksource/sh_tmu.c @@ -632,11 +632,6 @@ static int sh_tmu_probe(struct platform_device *pdev) return 0; } -static int sh_tmu_remove(struct platform_device *pdev) -{ - return -EBUSY; /* cannot unregister clockevent and clocksource */ -} - static const struct platform_device_id sh_tmu_id_table[] = { { "sh-tmu", SH_TMU }, { "sh-tmu-sh3", SH_TMU_SH3 }, @@ -652,10 +647,10 @@ MODULE_DEVICE_TABLE(of, sh_tmu_of_table); static struct platform_driver sh_tmu_device_driver = { .probe = sh_tmu_probe, - .remove = sh_tmu_remove, .driver = { .name = "sh_tmu", .of_match_table = of_match_ptr(sh_tmu_of_table), + .suppress_bind_attrs = true, }, .id_table = sh_tmu_id_table, };