From patchwork Tue Feb 7 19:23:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 54053 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3035444wrn; Tue, 7 Feb 2023 11:29:35 -0800 (PST) X-Google-Smtp-Source: AK7set8v7D9857hAkekJORn8Py+la95yU7MXUb6MnPG12DlATWJ92WDX6NRmdGiKe+7uHbt6J3f9 X-Received: by 2002:a50:9ea9:0:b0:4a0:e323:d59c with SMTP id a38-20020a509ea9000000b004a0e323d59cmr4782426edf.20.1675798175619; Tue, 07 Feb 2023 11:29:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675798175; cv=none; d=google.com; s=arc-20160816; b=a+f2kpAPqrSBqS3HOnC2NwEV7ztf7qDW2EYmjpIMAWI/5LVx61y+32MCRqexz/AXtn 0brA/YeenWpzkmADjMfn3qU868q7Z3NrvQi1vadyUyphrTMaoF53ovAMQSj6HX0noDlI hlHbFUOaI8FsO3eRz2CA3kGzUhZDsnLwc9oY92+E5gkw7OpS5SwgV0/qfkm6OgiT6ag8 cFg2EQP3JfM1uAkKuoPGlaJ+kMnPIFgcXGIpA3nkULXrLnTjLFZF62pfUBWJ8DbARARG UN2spd77j95kNsRX14KLyUV+AYC6h18B9cNpcoPH+taRfnESciz+CUMEsfGbMmYdhizq FUmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mjAuHWwOGDcYqGdZB6b3E7+sB2D00ij3hjREAb3ya4g=; b=uj7GlS6w1OjzOTXneS5Vi7HAVU/CuvxY6PNcgjcwqJZkxGulpyVx4v1wUVsPeWFxdt SFgPa62xOWFhS3eA/yosvOemqxFv6f91W9jisrZtQppkyQCyQIgb+dDLeYaNqPYN8f3s U1snXc7VTov8FtR8wVSDvz9eXMefRN1sjLVrIgT5Hw0+hRrL7kbouXju+/x4G1UPenFv yywu5HSjhUtXboIF4NNsmQLp5jacDSxvDRwIlR0FXkAHjy97drtXuY7OkyWrpym0+yZJ qU7UcvXkx6gbYxpJh5eJP5+GmkVw5FmYa2hucmgFZvBTxMQ4wXN+ERpxyMdTciWwHUgQ BZfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a056402255000b004a21d09b14bsi15459532edb.160.2023.02.07.11.29.12; Tue, 07 Feb 2023 11:29:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjBGTYF (ORCPT + 99 others); Tue, 7 Feb 2023 14:24:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjBGTX6 (ORCPT ); Tue, 7 Feb 2023 14:23:58 -0500 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DA8538E97 for ; Tue, 7 Feb 2023 11:23:48 -0800 (PST) Received: from dslb-178-004-202-208.178.004.pools.vodafone-ip.de ([178.4.202.208] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1pPTZ7-0002XK-Dy; Tue, 07 Feb 2023 20:23:41 +0100 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 7/7] staging: r8188eu: bagg_pkt parameter is not used Date: Tue, 7 Feb 2023 20:23:19 +0100 Message-Id: <20230207192319.294203-8-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230207192319.294203-1-martin@kaiser.cx> References: <20230207192319.294203-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757201747613161071?= X-GMAIL-MSGID: =?utf-8?q?1757201747613161071?= The bagg_pkt parameter in function update_txdesc is not used, it can be removed. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c index 5aa33fc4041d..3ffab4953a5c 100644 --- a/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c +++ b/drivers/staging/r8188eu/hal/rtl8188eu_xmit.c @@ -137,7 +137,7 @@ static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) } } -static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz, u8 bagg_pkt) +static s32 update_txdesc(struct xmit_frame *pxmitframe, u8 *pmem, s32 sz) { uint qsel; u8 data_rate, pwr_status, offset; @@ -319,7 +319,7 @@ static s32 rtw_dump_xframe(struct adapter *adapt, struct xmit_frame *pxmitframe) sz = pattrib->last_txcmdsz; } - pull = update_txdesc(pxmitframe, mem_addr, sz, false); + pull = update_txdesc(pxmitframe, mem_addr, sz); if (pull) { mem_addr += PACKET_OFFSET_SZ; /* pull txdesc head */ @@ -489,7 +489,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt) rtw_xmit_complete(adapt, pxmitframe); /* (len - TXDESC_SIZE) == pxmitframe->attrib.last_txcmdsz */ - update_txdesc(pxmitframe, pxmitframe->buf_addr, pxmitframe->attrib.last_txcmdsz, true); + update_txdesc(pxmitframe, pxmitframe->buf_addr, pxmitframe->attrib.last_txcmdsz); /* don't need xmitframe any more */ rtw_free_xmitframe(pxmitpriv, pxmitframe); @@ -529,7 +529,7 @@ bool rtl8188eu_xmitframe_complete(struct adapter *adapt) pfirstframe->pkt_offset--; } - update_txdesc(pfirstframe, pfirstframe->buf_addr, pfirstframe->attrib.last_txcmdsz, true); + update_txdesc(pfirstframe, pfirstframe->buf_addr, pfirstframe->attrib.last_txcmdsz); /* 3 4. write xmit buffer to USB FIFO */ ff_hwaddr = rtw_get_ff_hwaddr(pfirstframe);