[v12,05/10] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing
Message ID | 20230207171305.3716974-6-dhowells@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2970961wrn; Tue, 7 Feb 2023 09:17:20 -0800 (PST) X-Google-Smtp-Source: AK7set8O6zg1eG3t6JzO9r0BtUhNkye/+JEfxkqrm0Ba6Wa8T1iF4D4pYY2kmhSF2bRpB1KKlvf2 X-Received: by 2002:aa7:9a48:0:b0:593:dc7e:9882 with SMTP id x8-20020aa79a48000000b00593dc7e9882mr3791593pfj.27.1675790239782; Tue, 07 Feb 2023 09:17:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675790239; cv=none; d=google.com; s=arc-20160816; b=WBpiyjJnRQzwsFOoOvghHSHseVUk0+VZ0QwTKXlsqzU6/LAHI/d2R1baPGgr+juzXr Fw7SW2GqrUbzDPsjxKg5QYZ2aYXltZlFRu34sfC6P007f/Ow6u6oqjp0I/Aeb/59lzII nuKWFTAIpFvbPJHUMMfA6Gx/mu9p7lwDLsBZzRvOOqvFRvG0wOb7dnZELH0kYkO8HVJ6 eHOYneh/dTBYzxAq6xAWWChGzdXwE0E5ZvXTufMat8VHZBUcsziAxpK3Ft5uTpshQMUN AhnPTy150EWq0KB9xxztP5QeOwD+f41MselYZMzUc88KUMQsydc71FL0uaNkXQPnQb6b +tcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=orl2SBT3ZHtt+17y9AzVDTI6eV/nhROOjIfzt0nJeT+I8SA0YFDFS0I7Mlxql51uPJ 4RDz1TxRJMD5lwmZAhQ7x9cR2nkYRhTUQA4TAy77hUqwZnWfzzSN9BSxURttr0GZySU9 fvyxVaWG9hqXdAQ4efyLH+Khhw+YKBG1Idg0OHbkNUFbz2MV23yw+6Tm+KzzmoG3znYx sky+JPfIAWFo5K5zLgNuxkhQJ8iuWI9mQcLMuwYxeMpr3thnePZ8giVU31J5dzvKMb7h ek+ngYJpbdZpN/qGTV5IORLgCrBuockNMiVnJeVdMSyfdruDeWnxQipfJAK85esDlvwW DGrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hf7isXLE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a625405000000b0058dc4c4e238si14119045pfb.360.2023.02.07.09.17.06; Tue, 07 Feb 2023 09:17:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hf7isXLE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232272AbjBGRPc (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 12:15:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232359AbjBGROw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 12:14:52 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75CA83D092 for <linux-kernel@vger.kernel.org>; Tue, 7 Feb 2023 09:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675790010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AA3SDxqAw6tV+jeEhwhhXCCPQx7iw6NiGu/cAPT0aQk=; b=Hf7isXLED+t/3mmBSKMD+7qQPb6vkP7U0YK2GfLtsOiEkMYgSrEnUUkMI+wbDiZFMFbpES ppx8c5/x+90wsOXU0bvkbqbALoy+kFDWTLXFgn40esgIwcI2ccQs6aq8k2fyOa7CwMR2SQ PzV7t6jYYI7nDU+mfeFp5ojnCavYMM0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-wF4wE6smMp-jExteuoiB4Q-1; Tue, 07 Feb 2023 12:13:26 -0500 X-MC-Unique: wF4wE6smMp-jExteuoiB4Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7ECF4858F0E; Tue, 7 Feb 2023 17:13:25 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id A6C1918EC5; Tue, 7 Feb 2023 17:13:23 +0000 (UTC) From: David Howells <dhowells@redhat.com> To: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@infradead.org> Cc: David Howells <dhowells@redhat.com>, Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@kernel.org>, David Hildenbrand <david@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>, Logan Gunthorpe <logang@deltatee.com>, Hillf Danton <hdanton@sina.com>, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard <jhubbard@nvidia.com> Subject: [PATCH v12 05/10] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Tue, 7 Feb 2023 17:13:00 +0000 Message-Id: <20230207171305.3716974-6-dhowells@redhat.com> In-Reply-To: <20230207171305.3716974-1-dhowells@redhat.com> References: <20230207171305.3716974-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757193426547860606?= X-GMAIL-MSGID: =?utf-8?q?1757193426547860606?= |
Series |
iov_iter: Improve page extraction (pin or just list)
|
|
Commit Message
David Howells
Feb. 7, 2023, 5:13 p.m. UTC
ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: John Hubbard <jhubbard@nvidia.com> cc: Al Viro <viro@zeniv.linux.org.uk> cc: David Hildenbrand <david@redhat.com> cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 9804714b1751..47db4ead1e74 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }