Message ID | 20230207163550.1.I5ff72b7746d5fca8f10ea61351bde4150ed1a7f8@changeid |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3169365wrn; Tue, 7 Feb 2023 16:48:35 -0800 (PST) X-Google-Smtp-Source: AK7set/jgwgU1KFhlKPV1G4MzG76R1580V7Zcj8X2ccr6aBqq9EqnT5hEPjYtViUjtONe468Tnyk X-Received: by 2002:a17:907:7e9f:b0:8aa:c35a:fb23 with SMTP id qb31-20020a1709077e9f00b008aac35afb23mr1477545ejc.47.1675817315810; Tue, 07 Feb 2023 16:48:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675817315; cv=none; d=google.com; s=arc-20160816; b=YrkCPyQ4BpGCFSkRWRQiky3F30lhArkUUz+C4mFmhBXryc0g2bgKqpBp9X3ONvA2nf 2E3KEexRwU7wrjWTHMzSIdiCNo3nYdjOFQGjKAORKzJUXbDT9oT9aBZqVrwUyNnjAxbo izGSOvT068pzpxLGY5FIyO9Su2dd2gowptsPJE4FBDU4DX9mcTGOMKi3xa+eaogp8dRy he11wPfJbbc0LHKxcS0aqG+gPKjnhOF2Qyh4fbytFe321R2fpaWRXmaCmgxOiWckfvKn ljxDG/3lRzJ70ukp9Yk7T2NL7qjvOT4F9BI9kCZDdd0lFzWge9Rz+dCDyE9nDbZpmvQA yreg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3+bGG7y1kbAherXT7mYVUYA30E1TcsSU+mggkUydAXQ=; b=spXVzzd3jV7H/8y1+lBfJJ7XUDX2GY8ezGEt67G1yfaRZmU2SujTBJa9HtGp3CvswL LvadouCg/7OfGX/fQYRH675yeCIeqhe297q3D/96U33xAh2V7Izu3ASW17EWXq2m6JkK IMMzf6WIM88RTnzryecBXYyiENfDPQCANDxIIXRX5mLOGljiosn421aM3hP52JovyAPN LF9GEOtWh0NbBm/8rL6PVOrOEYyS5F/bNQkunrjiD6Sw3qgHFg93DW7qhv9gfN8zRYn7 GD/BJgcF/7qYOlAZfbgPzx1H6hv7nKHpkay2Ozl8tozfDAKCiOrs7SMr20rBcblwXGIl E1Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=W0H+U6Xy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fn18-20020a1709069d1200b008716321a08fsi17791255ejc.708.2023.02.07.16.47.44; Tue, 07 Feb 2023 16:48:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=W0H+U6Xy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbjBHAgn (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 19:36:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbjBHAgl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 19:36:41 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 332723D088 for <linux-kernel@vger.kernel.org>; Tue, 7 Feb 2023 16:36:40 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id w5so7476847plg.8 for <linux-kernel@vger.kernel.org>; Tue, 07 Feb 2023 16:36:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3+bGG7y1kbAherXT7mYVUYA30E1TcsSU+mggkUydAXQ=; b=W0H+U6Xyltr8ry9759aXuP7XI6Cq91ihJz3Ntu5eOQAPIEOYj+efFdkyyKMaz1LHHv tIymg18AO+wSjCICvCicEcYJ0arWdC7ENofw9kDSwrujcPp9mCpjxzf6YOkJvKsZRGBd TcDcgnRB7Ri0pBQ1fUGrnOG7h+mvjjbS5O0ZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3+bGG7y1kbAherXT7mYVUYA30E1TcsSU+mggkUydAXQ=; b=IcdbgE7X+R8H1LpxRUG7w8Nd7ysPFSP366GtxpNItfeH987YVYsmNTKwM1RajxSfiz xODPNrKymiJRDj5AlHnN9x4xEgqDkDMq3TH9vblJ9hYL+hFNQSE0lsVuF7uDFgLA72GH V9KjryqMnflKLxjz5UUF9vfkpxPMtbZxxTLN6j70gG0ZtQ8CEdz4dm6quDId6zVeP2lo +aJ7czjwCtVjp577iLi7rkZ4XAG4wTrt6uKT2zwZrfGKv/7hBmpVmp9k7Zz9TO25kFDY 2OULqv++rWz2585t+8gi7EGPDuFlDz7JlJiEfNRpUGtxUFzOJa2gZzh+hkemiQRNmLz1 K+cw== X-Gm-Message-State: AO0yUKVhO1wfWtIUGXzaf9jFsw2GFECcmzsSS89yLWsRXqtekteXw0xa DHIf+3an/lOaFfWNYa7BHexJmg== X-Received: by 2002:a17:903:1386:b0:198:e63d:9a3d with SMTP id jx6-20020a170903138600b00198e63d9a3dmr470298plb.26.1675816598865; Tue, 07 Feb 2023 16:36:38 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:8f31:e721:5c9:1d71]) by smtp.gmail.com with ESMTPSA id jg21-20020a17090326d500b0019907bfd26fsm5676738plb.178.2023.02.07.16.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 16:36:38 -0800 (PST) From: Douglas Anderson <dianders@chromium.org> To: Bjorn Andersson <andersson@kernel.org> Cc: mka@chromium.org, Douglas Anderson <dianders@chromium.org>, Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: qcom: sc7280: Power herobrine's 3.3 eDP/TS rail more properly Date: Tue, 7 Feb 2023 16:36:10 -0800 Message-Id: <20230207163550.1.I5ff72b7746d5fca8f10ea61351bde4150ed1a7f8@changeid> X-Mailer: git-send-email 2.39.1.519.gcb327c4b5f-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757221817460903487?= X-GMAIL-MSGID: =?utf-8?q?1757221817460903487?= |
Series |
arm64: dts: qcom: sc7280: Power herobrine's 3.3 eDP/TS rail more properly
|
|
Commit Message
Doug Anderson
Feb. 8, 2023, 12:36 a.m. UTC
This is the equivalent of commit f5b4811e8758 ("arm64: dts: qcom:
sc7180: Add trogdor eDP/touchscreen regulator off-on-time") and commit
23ff866987de ("arm64: dts: qcom: sc7180: Start the trogdor
eDP/touchscreen regulator on"), but for herobrine instead of trogdor.
The motivations for herobrine are the same as for trogdor.
NOTES:
* Currently for herobrine all boards are eDP, not MIPI. If/when we
have herobrine derivatives that are MIPI they we can evaluate
whether the same off-on-delay makes sense for them. For trogdor we
didn't add the delay to MIPI panels because the problem was found
late and nobody had complained about it. For herobrine defaulting to
assuming the same 500ms makes sense and if we find we need to
optimize later we can.
* Currently there are no oddball herobrine boards like homestar where
the panel really likes to be power cycled. If we have an oddball
board it will need to split the eDP and touchscreen rail anyway
(like homestar did) and we'll have to delete the "regulator-boot-on"
from that board.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
This patch should be applied atop my recent series adjusting the
herobrine touchscreen rails [1]. If I need to send a v2 of that series
I will add this at the end of it as patch #8.
[1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
Comments
On 8.02.2023 01:36, Douglas Anderson wrote: > This is the equivalent of commit f5b4811e8758 ("arm64: dts: qcom: > sc7180: Add trogdor eDP/touchscreen regulator off-on-time") and commit > 23ff866987de ("arm64: dts: qcom: sc7180: Start the trogdor > eDP/touchscreen regulator on"), but for herobrine instead of trogdor. > > The motivations for herobrine are the same as for trogdor. > > NOTES: > * Currently for herobrine all boards are eDP, not MIPI. If/when we > have herobrine derivatives that are MIPI they we can evaluate > whether the same off-on-delay makes sense for them. For trogdor we > didn't add the delay to MIPI panels because the problem was found > late and nobody had complained about it. For herobrine defaulting to > assuming the same 500ms makes sense and if we find we need to > optimize later we can. > * Currently there are no oddball herobrine boards like homestar where > the panel really likes to be power cycled. If we have an oddball > board it will need to split the eDP and touchscreen rail anyway > (like homestar did) and we'll have to delete the "regulator-boot-on" > from that board. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > This patch should be applied atop my recent series adjusting the > herobrine touchscreen rails [1]. If I need to send a v2 of that series > I will add this at the end of it as patch #8. > > [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index ded36b5d28c7..312cc0e1cbc7 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -110,6 +110,22 @@ pp3300_left_in_mlb: pp3300-left-in-mlb-regulator { > > regulator-enable-ramp-delay = <3000>; > > + /* > + * eDP panel specs nearly always have a spec that says you > + * shouldn't turn them off an on again without waiting 500ms. > + * Add this as a board constraint since this rail is shared > + * between the panel and touchscreen. > + */ > + off-on-delay-us = <500000>; > + > + /* > + * Stat the regulator on. This has the advantage of starting > + * the slow process of powering the panel on as soon as we > + * probe the regulator. It also avoids tripping the > + * off-on-delay immediately on every bootup. > + */ > + regulator-boot-on; > + > vin-supply = <&pp3300_z1>; > }; >
On Tue, Feb 07, 2023 at 04:36:10PM -0800, Douglas Anderson wrote: > This is the equivalent of commit f5b4811e8758 ("arm64: dts: qcom: > sc7180: Add trogdor eDP/touchscreen regulator off-on-time") and commit > 23ff866987de ("arm64: dts: qcom: sc7180: Start the trogdor > eDP/touchscreen regulator on"), but for herobrine instead of trogdor. > > The motivations for herobrine are the same as for trogdor. > > NOTES: > * Currently for herobrine all boards are eDP, not MIPI. If/when we > have herobrine derivatives that are MIPI they we can evaluate > whether the same off-on-delay makes sense for them. For trogdor we > didn't add the delay to MIPI panels because the problem was found > late and nobody had complained about it. For herobrine defaulting to > assuming the same 500ms makes sense and if we find we need to > optimize later we can. > * Currently there are no oddball herobrine boards like homestar where > the panel really likes to be power cycled. If we have an oddball > board it will need to split the eDP and touchscreen rail anyway > (like homestar did) and we'll have to delete the "regulator-boot-on" > from that board. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > This patch should be applied atop my recent series adjusting the > herobrine touchscreen rails [1]. If I need to send a v2 of that series > I will add this at the end of it as patch #8. > > [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index ded36b5d28c7..312cc0e1cbc7 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -110,6 +110,22 @@ pp3300_left_in_mlb: pp3300-left-in-mlb-regulator { > > regulator-enable-ramp-delay = <3000>; > > + /* > + * eDP panel specs nearly always have a spec that says you uber-nit: you could replace the second 'spec' with 'requirement' to avoid the repetition. > + * shouldn't turn them off an on again without waiting 500ms. > + * Add this as a board constraint since this rail is shared > + * between the panel and touchscreen. > + */ > + off-on-delay-us = <500000>; > + > + /* > + * Stat the regulator on. This has the advantage of starting s/Stat/Start/ ? > + * the slow process of powering the panel on as soon as we > + * probe the regulator. It also avoids tripping the > + * off-on-delay immediately on every bootup. > + */ > + regulator-boot-on; > + > vin-supply = <&pp3300_z1>; > }; Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On Tue, 7 Feb 2023 16:36:10 -0800, Douglas Anderson wrote: > This is the equivalent of commit f5b4811e8758 ("arm64: dts: qcom: > sc7180: Add trogdor eDP/touchscreen regulator off-on-time") and commit > 23ff866987de ("arm64: dts: qcom: sc7180: Start the trogdor > eDP/touchscreen regulator on"), but for herobrine instead of trogdor. > > The motivations for herobrine are the same as for trogdor. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sc7280: Power herobrine's 3.3 eDP/TS rail more properly commit: f069ede81ef438d99e76112d8738c4dc3d1766f9 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index ded36b5d28c7..312cc0e1cbc7 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -110,6 +110,22 @@ pp3300_left_in_mlb: pp3300-left-in-mlb-regulator { regulator-enable-ramp-delay = <3000>; + /* + * eDP panel specs nearly always have a spec that says you + * shouldn't turn them off an on again without waiting 500ms. + * Add this as a board constraint since this rail is shared + * between the panel and touchscreen. + */ + off-on-delay-us = <500000>; + + /* + * Stat the regulator on. This has the advantage of starting + * the slow process of powering the panel on as soon as we + * probe the regulator. It also avoids tripping the + * off-on-delay immediately on every bootup. + */ + regulator-boot-on; + vin-supply = <&pp3300_z1>; };