diff mbox series

[next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"

Message ID 20230207091443.143995-1-colin.i.king@gmail.com
State New
Headers
Series [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention" |

Commit Message

Colin Ian King Feb. 7, 2023, 9:14 a.m. UTC 
  There is a spelling mistake in a dev_warn message, make it lower case
and fix the spelling.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/platform/chrome/cros_ec_typec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck Feb. 7, 2023, 5:49 p.m. UTC | #1 
On Tue, Feb 7, 2023 at 1:14 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/platform/chrome/cros_ec_typec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 71f5d7d8e055..a673c3342470 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1020,7 +1020,7 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
>                 cros_typec_handle_vdm_attention(typec, port_num);
>                 ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
>                 if (ret < 0)
> -                       dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
> +                       dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
>                                  port_num);
>         }
>  }
> --
> 2.30.2
>
Tzung-Bi Shih Feb. 8, 2023, 7:33 a.m. UTC | #2 
Hi Prashant,

On Tue, Feb 07, 2023 at 09:14:43AM +0000, Colin Ian King wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

It's about time to cut for the coming merge window.  I guess you would
like this simple patch to be included as a fixup for f54c013e7eef
("platform/chrome: cros_typec_vdm: Add Attention support").  Please apply
the patch if it makes sense.

One minor suggestion for the commit title:
"platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear
to me.

With that:
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Prashant Malani Feb. 8, 2023, 7:52 a.m. UTC | #3 
On Tue, Feb 7, 2023 at 11:33 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> Hi Prashant,
>
> On Tue, Feb 07, 2023 at 09:14:43AM +0000, Colin Ian King wrote:
> > There is a spelling mistake in a dev_warn message, make it lower case
> > and fix the spelling.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> It's about time to cut for the coming merge window.

I thought there would be an rc8...

> I guess you would
> like this simple patch to be included as a fixup for f54c013e7eef
> ("platform/chrome: cros_typec_vdm: Add Attention support").  Please apply
> the patch if it makes sense.

Sure. I'll make the modification you suggest and apply this tomorrow.
Thanks for signal boosting it.

>
> One minor suggestion for the commit title:
> "platform/chrome: cros_ec_typec: Fix spelling mistake" looks more clear
> to me.
>
> With that:
> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
patchwork-bot+chrome-platform@kernel.org Feb. 8, 2023, 6:30 p.m. UTC | #4 
Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Prashant Malani <pmalani@chromium.org>:

On Tue,  7 Feb 2023 09:14:43 +0000 you wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"
    https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org Feb. 8, 2023, 9:40 p.m. UTC | #5 
Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Prashant Malani <pmalani@chromium.org>:

On Tue,  7 Feb 2023 09:14:43 +0000 you wrote:
> There is a spelling mistake in a dev_warn message, make it lower case
> and fix the spelling.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [next] platform/chrome: Fix spelling mistake "Attenetion" -> "attention"
    https://git.kernel.org/chrome-platform/c/b0d8a67715da

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 71f5d7d8e055..a673c3342470 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -1020,7 +1020,7 @@  static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
 		cros_typec_handle_vdm_attention(typec, port_num);
 		ret = cros_typec_send_clear_event(typec, port_num, PD_STATUS_EVENT_VDM_ATTENTION);
 		if (ret < 0)
-			dev_warn(typec->dev, "Failed VDM Attenetion event clear, port: %d\n",
+			dev_warn(typec->dev, "Failed VDM attention event clear, port: %d\n",
 				 port_num);
 	}
 }