From patchwork Tue Feb 7 07:00:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ziyang Zhang X-Patchwork-Id: 53749 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2694491wrn; Mon, 6 Feb 2023 23:09:44 -0800 (PST) X-Google-Smtp-Source: AK7set8VGSjOpxwnz6Jwx4HCtIP1+AHMpPN4JXMcPAQLxQD2IPe9On4bOLaJKKXGGelkAQ0Yx0n7 X-Received: by 2002:a05:6a21:6d8d:b0:c0:c9b8:70 with SMTP id wl13-20020a056a216d8d00b000c0c9b80070mr2865409pzb.27.1675753784568; Mon, 06 Feb 2023 23:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675753784; cv=none; d=google.com; s=arc-20160816; b=hSUMSERwmf5HYtiLIpgdS17/pjSV186TI3S/YsCytssib0sJNIEIGxvO9UsgeO/rs+ r5/8Vrp4yZzJ1y02YcQbvExUJ55obbK2LftaxdBF9h5UObAdePQfksjGF4HaHmAi0Boa K29FElKAKGRUzVPlzaPrYtoZrSjikixbtwo2nRqqiic2XOEZlAAfgZs9wu9aIVvgH05D 5E9DaPUstlSpHGiHQOT4s4idmUWXA7PbZzqes3tAK3zsATeKmSOytp7DGiCJJpXC2+dk b8fSn/ke6KbgtCnN/x/glW9kX6z1Ut7F/DfSywzhdFsgln337K5Z/mA9HFskCb9XhAnQ rMhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=D+rvyYe01sACv3wQdtVeTzm8IX7D9Mwg5Gf0Gb2yTwI=; b=SbeJpwLiJIRH4jIW+c9dnTajepxUwFiHN7qajvI9vGtqWbwapEkJ1+05+htv5QsN74 /fuWM/L+K+F4+oGT2iOlWDHoZs1IWFQXLLMNc9+K4neIRERXZQ62UP5iBAwCD+1xn9yr iCJxvuHeNoPdnSRPdSZpAWMedTg/HF2DPiUFmshMfhf600fMQFPHs441YpWuTK4ZDGmF RwrBLoh8wuo7kr7TSkPDyMuNPPKRrVF3GVBpThQnCIo0juayyd7v3EixtvyZcPEz3qsd ls/vC3Vqu8GBKr4rroRocRt7k6BcZxp4WPFGZHzPCnfM2UTwd3aSAg8u6QjWDobJg5dd WDeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y19-20020a637d13000000b004d0682f947bsi13764688pgc.669.2023.02.06.23.09.32; Mon, 06 Feb 2023 23:09:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbjBGHDc (ORCPT + 99 others); Tue, 7 Feb 2023 02:03:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230399AbjBGHDb (ORCPT ); Tue, 7 Feb 2023 02:03:31 -0500 Received: from out199-14.us.a.mail.aliyun.com (out199-14.us.a.mail.aliyun.com [47.90.199.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F7A613DDD; Mon, 6 Feb 2023 23:02:54 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R321e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=ziyangzhang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vb61Xa5_1675753320; Received: from localhost.localdomain(mailfrom:ZiyangZhang@linux.alibaba.com fp:SMTPD_---0Vb61Xa5_1675753320) by smtp.aliyun-inc.com; Tue, 07 Feb 2023 15:02:04 +0800 From: Ziyang Zhang To: axboe@kernel.dk, ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, Ziyang Zhang Subject: [PATCH 1/3] ublk: remove unnecessary NULL check in ublk_rq_has_data() Date: Tue, 7 Feb 2023 15:00:31 +0800 Message-Id: <20230207070033.367423-2-ZiyangZhang@linux.alibaba.com> X-Mailer: git-send-email 2.18.4 In-Reply-To: <20230207070033.367423-1-ZiyangZhang@linux.alibaba.com> References: <20230207070033.367423-1-ZiyangZhang@linux.alibaba.com> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757155200627706957?= X-GMAIL-MSGID: =?utf-8?q?1757155200627706957?= bio_has_data() allows a NULL bio so the NULL check in ublk_rq_has_data() is unnecessary. Fixes: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Ziyang Zhang --- drivers/block/ublk_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index c932e9ea5a0f..55fccce68a9c 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -322,7 +322,7 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev, static inline bool ublk_rq_has_data(const struct request *rq) { - return rq->bio && bio_has_data(rq->bio); + return bio_has_data(rq->bio); } static inline struct ublksrv_io_desc *ublk_get_iod(struct ublk_queue *ubq,