From patchwork Tue Feb 7 05:26:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 53695 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2661672wrn; Mon, 6 Feb 2023 21:29:50 -0800 (PST) X-Google-Smtp-Source: AK7set/RrO48JN/f5Ag5q8X3TdbQvS/YIrV+tYwGCeYghQdRZy7emfaeCHaKPS1zxFb9U8TeZXHG X-Received: by 2002:a17:90b:3903:b0:22c:7ed4:6bf9 with SMTP id ob3-20020a17090b390300b0022c7ed46bf9mr2563370pjb.28.1675747790327; Mon, 06 Feb 2023 21:29:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675747790; cv=none; d=google.com; s=arc-20160816; b=tlI24hualocR8jLBpJyiboSjXkitPVpRzK5zjqriFBzPs5tvHVc+SrsyP9midKtAzo 5ZOsn5AfdcoCldwNKGhf0XW5+TZAdgWbyA/YbK7PS4QdYyyzNFq95SlbourMJzpwWX4z PNsSHHK6GA4ogPeMJM50tdufmI3eFTeWjnsaMzCTW84ovPV4o0I9kHQzuqWa7lL/f1+G I3l2BsCfYLVPldKau7ZC7hMKzvIzODl3zSmlc+iHL128ixwLhdkH2vW1bc7EFpz0gLip SyCM5Hu2Odoq2n0nuz3bY4hK6aihJ5B05BNiOeLw0XkSmvwS38VRw35ZHQjN6TTe+wEo 3I3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iSDZvHYacjjt2FgDCrkO0RJUayAnRPQsfqp+ecmjYVg=; b=gp2dYd2tWftKbHFRU+6cXhjYq8njBmMvr8pmYHIgskxfa5EueWavf4SsYH5q7Gf2Qk 9Mr+/WisJu+UWX9sdJqCuMDaEdLQAylXltzn5I+6o3mjxzPcAMp15eikZEzKUJqeffW2 ihRj/3C0Bzwm74jGxJfy5j7cxjR5/rvDK8zPFZZy1rAFuiuNUQxBGHSvf1fq48UcGVDu bLl68uAcznOATeiLJg91EIpPq7Qe0+nsnIlo7tAzkC14XJq9/kqE9VqsEC05WZfLSMl/ 7e25c0+oGeR3OJ7DkHtZvV8kFpGNuapVSxKnxSDx9OeT4n4HhuigOr/IXb1LXuwtQHAi OpNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a191-20020a6390c8000000b004f1b4f066f7si13822328pge.861.2023.02.06.21.29.37; Mon, 06 Feb 2023 21:29:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbjBGF0U (ORCPT + 99 others); Tue, 7 Feb 2023 00:26:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbjBGF0S (ORCPT ); Tue, 7 Feb 2023 00:26:18 -0500 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F00923337 for ; Mon, 6 Feb 2023 21:26:17 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Vb5fT1I_1675747568; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Vb5fT1I_1675747568) by smtp.aliyun-inc.com; Tue, 07 Feb 2023 13:26:14 +0800 From: Jiapeng Chong To: vkoul@kernel.org Cc: kishon@kernel.org, heiko@sntech.de, p.zabel@pengutronix.de, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] phy: rockchip-typec: Fix unsigned comparison with less than zero Date: Tue, 7 Feb 2023 13:26:06 +0800 Message-Id: <20230207052606.29506-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757148914761535979?= X-GMAIL-MSGID: =?utf-8?q?1757148914761535979?= The dp is defined as bool type, the return value type of function extcon_get_state should be int, at the same time,if(dp>0) is used as the conditional statement, so the type of dp is modified to int. ./drivers/phy/rockchip/phy-rockchip-typec.c:827:12-14: WARNING: Unsigned expression compared with zero: dp > 0. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3962 Signed-off-by: Jiapeng Chong --- drivers/phy/rockchip/phy-rockchip-typec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index 6aea512e5d4e..85ed7d510cbf 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -808,9 +808,9 @@ static int tcphy_get_mode(struct rockchip_typec_phy *tcphy) struct extcon_dev *edev = tcphy->extcon; union extcon_property_value property; unsigned int id; - bool ufp, dp; + bool ufp; u8 mode; - int ret; + int ret, dp; if (!edev) return MODE_DFP_USB;