From patchwork Mon Feb 6 22:12:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 53529 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2493645wrn; Mon, 6 Feb 2023 14:22:27 -0800 (PST) X-Google-Smtp-Source: AK7set/9yvEbhVmZLLXj4Ttir2Ya4WG5q4bHR3be7cHYytEF4v59EIRMmG6voneIQ6iYQgHSasL7 X-Received: by 2002:a05:6a20:ce1c:b0:bc:e785:5ad5 with SMTP id ic28-20020a056a20ce1c00b000bce7855ad5mr572664pzb.35.1675722147654; Mon, 06 Feb 2023 14:22:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675722147; cv=none; d=google.com; s=arc-20160816; b=PiOfKqWN+b1aD0BfoonFo+upTHQvCDQCqbQI5CZDyLPC3q70LgIo6O5vsJfkjB/lRw b5J7Kx9TO+qnk0Ed0LL2cRbFqA0Jl+IErgH5QehbPyVTW5fawoXX0rQVk1lEicPgACE6 EceRbSMnNXgQc75GzNcpE7fJlN6tlwkcXkcIsGGCOhe7wox77tCuvWjQsp3kKQw8Hs8N GNfdM0nqEwtSemzIIThw8mH/sEyN5xABGBB9+LPaLMLM7FORm74nkQ1StdPXKu/cWV5u eJEKjNmubrppFAtt2O7E0/OrHDnYpHbfnVcAH1M5RCL7YNfG5Lm0SNCx24aVFWsHpcBK qR0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Zj64pYVuLcQyt++cUm2w4jZgCEbpefE6wT/YaTEa1WA=; b=qLU3J5NuUDhSfF5XhRoP/D+bIPiSy+mrprDtW0yQpImLH+daUSXOrM7ZtqBdfFr0Kl S4Pxyw1jHMACqEehb675AyG/s8BG3aAZAMS4WnftfP35OQqGVZ5hrp+jUrkHI0hTBseX JvTSs9ud9/9K4nsgxMmxGjqcs7udc0srXpilrFoji4i0oNfmfSd0jVyIFahfKtvh+92g gVmk5HF60VgKSXycP6Xkm0i4RVIvcIwAATYNn3Pl3FPUsJgd2sINW/NKy77XPp4SQSTc 0JTFZkfxOeNEItRcvXMAqbvMnKtw3dTiiFw74jEKCt1kt2m262YNsO5CJhyPg9cUCZHs 3ODQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s17-20020a639251000000b004d422660ff7si13670366pgn.244.2023.02.06.14.22.13; Mon, 06 Feb 2023 14:22:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbjBFWNG (ORCPT + 99 others); Mon, 6 Feb 2023 17:13:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjBFWNE (ORCPT ); Mon, 6 Feb 2023 17:13:04 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD8C211E8A; Mon, 6 Feb 2023 14:13:02 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id DF99560003; Mon, 6 Feb 2023 22:12:59 +0000 (UTC) From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , =?utf-8?q?Filipe_La?= =?utf-8?q?=C3=ADns?= , Nestor Lopez Casado Subject: [PATCH v2 2/3] HID: logitech-hidpp: Retry commands when device is busy Date: Mon, 6 Feb 2023 23:12:55 +0100 Message-Id: <20230206221256.129198-2-hadess@hadess.net> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230206221256.129198-1-hadess@hadess.net> References: <20230206221256.129198-1-hadess@hadess.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757122026791657783?= X-GMAIL-MSGID: =?utf-8?q?1757122026791657783?= Handle the busy error coming from the device or receiver. The documentation says a busy error can be returned when: " Device (or receiver) cannot answer immediately to this request for any reason i.e: - already processing a request from the same or another SW - pipe full " Signed-off-by: Bastien Nocera --- Same as v1 drivers/hid/hid-logitech-hidpp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 1952d8d3b6b2..9e94026de437 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -295,6 +295,7 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp, */ *response = *message; +retry: ret = __hidpp_send_report(hidpp->hid_dev, message); if (ret) { @@ -321,6 +322,10 @@ static int hidpp_send_message_sync(struct hidpp_device *hidpp, response->report_id == REPORT_ID_HIDPP_VERY_LONG) && response->fap.feature_index == HIDPP20_ERROR) { ret = response->fap.params[1]; + if (ret == HIDPP20_ERROR_BUSY) { + dbg_hid("%s:got busy hidpp 2.0 error %02X, retrying\n", __func__, ret); + goto retry; + } dbg_hid("%s:got hidpp 2.0 error %02X\n", __func__, ret); goto exit; }