From patchwork Mon Feb 6 22:12:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bastien Nocera X-Patchwork-Id: 53531 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2494561wrn; Mon, 6 Feb 2023 14:24:35 -0800 (PST) X-Google-Smtp-Source: AK7set/gyVmS3f5nqV1l5gnS3GaYUY62xb/RN/cE4aQq2Ss17y/NS+xIzxHefHQttS66H/DG4x2P X-Received: by 2002:a50:8adb:0:b0:4aa:a6a9:3730 with SMTP id k27-20020a508adb000000b004aaa6a93730mr1211427edk.19.1675722274954; Mon, 06 Feb 2023 14:24:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675722274; cv=none; d=google.com; s=arc-20160816; b=nXlKz6BJGHZpPkhMTVJnu+g3QhvJsuKCyDmtY3yM0keZJXLiwWHAIPoLkUG+ijFJ2j Pe+43OdSzlGpGAtRP3P4LF7zzjgOkZD3yq9F9ydgdLm0b+JsHrRK/0vhz2NDlplVFQK/ PaQ1hRMh2z7O+9mxUzHpvsKTHkKp8+xYS5Wx9j/PbU5P2Igwks4Lt3lbv/SFmV6Bcyvv fZDTbTa8A5GGsNiD71TuaQ469cy6Lc+ncb9hZevNmTK4d32W8tKiiW8YCivKObuCUi00 k444Wv5XKmBFXiFlKRmrFp+DSFY/TO73StJgL1SuTSjlvZ8QBgcVWS6WxEpxHnZuHnI5 oaWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=u3uoPJw7v4+uofBGmwYXcYe24yJZXChjjN6h7eUEzng=; b=tOwf4/oQnpjik0+BJbk/zL/RQpzA/KmhioJUQHPdCU4q3aYBIOgtbBVhnrhhs85GHX aCI1GDuqwXjSiBkTHy1AxBFV2scWV0ybMINrsU/ui0ZvqyuyFovmr3E2a50wd1+pEzXK jtmhWJF2uZJUB6BK2ARQHDsxFwxxPvBFSInXSbzKXIff+TWnEjxhtU0cQrF8wgyTkr1U GIs2BvP+Rugo66gaFVTcc5IRyvX4J56gXBFRD+ExA5ZuZ91007qL9RP91z3GN+SPH9jq 85svt7H5PJG9q67IYW6KNlQtXiwiFOsnC9idq15JI9l+sT55pX37FTaxet4mkb6a3mKv eZOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a056402079000b004aabc918760si2264481edy.146.2023.02.06.14.24.12; Mon, 06 Feb 2023 14:24:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbjBFWNH (ORCPT + 99 others); Mon, 6 Feb 2023 17:13:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjBFWNE (ORCPT ); Mon, 6 Feb 2023 17:13:04 -0500 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E970D1167E; Mon, 6 Feb 2023 14:13:00 -0800 (PST) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id 8C04560004; Mon, 6 Feb 2023 22:12:57 +0000 (UTC) From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , =?utf-8?q?Filipe_La?= =?utf-8?q?=C3=ADns?= , Nestor Lopez Casado Subject: [PATCH v2 1/3] HID: logitech-hidpp: Add more debug statements Date: Mon, 6 Feb 2023 23:12:54 +0100 Message-Id: <20230206221256.129198-1-hadess@hadess.net> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757122160533727083?= X-GMAIL-MSGID: =?utf-8?q?1757122160533727083?= This should help us figure out some hairy problems with some devices. Signed-off-by: Bastien Nocera --- Fixed kernel test bot warning: drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_send_fap_command_sync': >> drivers/hid/hid-logitech-hidpp.c:343:25: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'unsigned int' [-Wformat=] 343 | "Invalid number of parameters passed to command (%d != %ld)\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-logitech-hidpp.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index f44ba7be3cc5..1952d8d3b6b2 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -338,8 +338,13 @@ static int hidpp_send_fap_command_sync(struct hidpp_device *hidpp, struct hidpp_report *message; int ret; - if (param_count > sizeof(message->fap.params)) + if (param_count > sizeof(message->fap.params)) { + hid_dbg(hidpp->hid_dev, + "Invalid number of parameters passed to command (%d != %llu)\n", + param_count, + (unsigned long long) sizeof(message->fap.params)); return -EINVAL; + } message = kzalloc(sizeof(struct hidpp_report), GFP_KERNEL); if (!message) @@ -3440,11 +3445,17 @@ static int hi_res_scroll_enable(struct hidpp_device *hidpp) ret = hidpp10_enable_scrolling_acceleration(hidpp); multiplier = 8; } - if (ret) + if (ret) { + hid_dbg(hidpp->hid_dev, + "Could not enable hi-res scrolling: %d\n", ret); return ret; + } - if (multiplier == 0) + if (multiplier == 0) { + hid_dbg(hidpp->hid_dev, + "Invalid multiplier 0 from device, setting it to 1\n"); multiplier = 1; + } hidpp->vertical_wheel_counter.wheel_multiplier = multiplier; hid_dbg(hidpp->hid_dev, "wheel multiplier = %d\n", multiplier);