From patchwork Mon Feb 6 19:37:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 53477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2426533wrn; Mon, 6 Feb 2023 11:47:23 -0800 (PST) X-Google-Smtp-Source: AK7set+OwfaS/naE7Gu2fkY0YHdxf1oMYUSgaNjB1tR7yUmUzorF7mIhTJhClOb0Jd39Tsu2X1Om X-Received: by 2002:a17:906:46d5:b0:88c:780c:770e with SMTP id k21-20020a17090646d500b0088c780c770emr520506ejs.32.1675712843613; Mon, 06 Feb 2023 11:47:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675712843; cv=none; d=google.com; s=arc-20160816; b=LoMbYfKHhnVKpITYwWU79GwYKWsBfYSuj++uju+WG6kaP4GMtcjjzpNUs1nd6rXUwP jXFKZzSBnxJFIFUKRSMkvMl2D7R5bhmILPr0fKPTKo8IUHhqR3IJEum1B1j5I9rf5pKX 38H7hgM519flr+a7Rlo7UwghKB6X157RmE+2XplC+8/WLaRiyKklubZiwGQibf9JlQZ4 cBsZzgnXfKRff7X+kMdR/pUypxDLu2QAY1rRwrBLVB2ffeCF+1NlhHgezr9To/FHDE8v wkl3VgobdArteZJRvAGo96r6MdiOHj3BvrfpkmjMDtOH0LR8UtF36k8g/DkvsehG4hW8 2Fpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WYWH9h1hPi7gAb+77Nq/iKPHWZeKZ50E2Uh2kDRgY5k=; b=w/tpJt/e+1g4kmOheiev5I7MYgiJtAuXTGLRhPBqTotcW1QRy9eBXnyCM8xOO/skO6 Daa2OqoSOOj0D2SX2PjyXsV/eyg96trHH6M/+u2QRm+az8xHvIsrWfsN0U59ls+HP8xv kxY8onOWyXXIosXZBB3OMXkY1+QlifJDktpwQneIussyEqXBFGUrWFfmGkOECW/BYykT 405loDGFB+2JY9ihBpf2BGjWREfoIOkxTyMqHQdqTcfSqRm3n1Psv2ACcHIk82hEl2jq YYQVkSAlIB3GRRU3ms76FZvEPpjT+lLuAwKZDTQXQfrJ+Wn35OAHlz2Xd8wbI5isZ5a/ x0hw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FYMLuiiX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ck17-20020a170906c45100b0087052df6f02si14361388ejb.901.2023.02.06.11.47.00; Mon, 06 Feb 2023 11:47:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FYMLuiiX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbjBFTiL (ORCPT + 99 others); Mon, 6 Feb 2023 14:38:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjBFTiK (ORCPT ); Mon, 6 Feb 2023 14:38:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B11D913D69; Mon, 6 Feb 2023 11:38:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4EAB060FFD; Mon, 6 Feb 2023 19:38:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB14C433D2; Mon, 6 Feb 2023 19:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675712288; bh=bG9YLGEhBjFz6zXj4NzQ4x+3+ALPum4dN/AWK0u8uEg=; h=From:To:Cc:Subject:Date:From; b=FYMLuiiXykEsb6hGNWJG9d5xTC+yMuyR45nOkmcZ/Hib+HGgsTHqrhMPDSYKnjg0f osNS8re5r97xLusDW5Rhu6Ri95Gti5Av+ba2JQ+bR4qt4EjAg1GOF+L7CjqZ8lnnkf cjleuAKlvdGXWP/sUk3TFnfbze7mKEMczoWI9cl7BH1oEa+v5eKWpHizHDFGfgA56X nwwHmPwoUtIPdceMrS5EzNkBF4kaDtJS6dPcRneJIOkcyuttAT6Jn6iDzIpts0/T/L 5Vy0IHurU6VdArKoFoAoJ3MblCIcZGItnT+xGL1Ax4QsuNDh5+mrZODiBae4z61BN0 yit3H4d2MCq5Q== From: Arnd Bergmann To: Andy Gross , Bjorn Andersson , Neil Armstrong Cc: Arnd Bergmann , Konrad Dybcio , Krzysztof Kozlowski , Manivannan Sadhasivam , AngeloGioacchino Del Regno , Souradeep Chowdhury , YueHaibing , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: pmic_glink: add CONFIG_NET/CONFIG_OF dependencies Date: Mon, 6 Feb 2023 20:37:58 +0100 Message-Id: <20230206193804.191343-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757112270715971287?= X-GMAIL-MSGID: =?utf-8?q?1757112270715971287?= From: Arnd Bergmann QMI is a network protocol, so anything using requires CONFIG_NET to be enabled as well: WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS Depends on [n]: NET [=n] Selected by [m]: - QCOM_PDR_HELPERS [=m] arm-linux-gnueabi-ld: drivers/soc/qcom/qmi_interface.o: in function `qmi_send_new_lookup': qmi_interface.c:(.text+0xf0): undefined reference to `kernel_sendmsg' Add the dependency to both QCOM_PDR_HELPERS and QCOM_PMIC_GLINK to make it clearly what the dependency is when another PDR user is added. pmic_glink also needs CONFIG_OF: drivers/soc/qcom/pmic_glink_altmode.c: In function 'pmic_glink_altmode_probe': drivers/soc/qcom/pmic_glink_altmode.c:418:33: error: 'struct drm_bridge' has no member named 'of_node' Fixes: 58ef4ece1e41 ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Signed-off-by: Arnd Bergmann Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index 348fde2a8aae..a8f283086a21 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -91,12 +91,15 @@ config QCOM_OCMEM config QCOM_PDR_HELPERS tristate select QCOM_QMI_HELPERS + depends on NET config QCOM_PMIC_GLINK tristate "Qualcomm PMIC GLINK driver" depends on RPMSG depends on TYPEC depends on DRM + depends on NET + depends on OF select AUXILIARY_BUS select QCOM_PDR_HELPERS help