From patchwork Mon Feb 6 16:13:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 53410 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2321040wrn; Mon, 6 Feb 2023 08:14:32 -0800 (PST) X-Google-Smtp-Source: AK7set9VXomaJA46T0se57CGFnx8qT6eNSyYwQH8eb8tTxVF4R86uu+e9oUoFHzJWVE2cYHLeB59 X-Received: by 2002:a17:90b:1650:b0:22b:ecbc:8113 with SMTP id il16-20020a17090b165000b0022becbc8113mr260674pjb.12.1675700072257; Mon, 06 Feb 2023 08:14:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675700072; cv=none; d=google.com; s=arc-20160816; b=hkRANBgzHs19MOMJ0cyElU5zIZYn5MNMVfdyBZcjR2mqoKotKTkTSCBmGVORiCW8X4 BuFm2rzTZ1tCpcmLVRkOe3rziATh/9tQUQFwQtdLZQH/XfLkL6LWV8WcgGhhyyuGhQXz dwGEQVxrMp8GUwcsRfiufiDjEG9lLXz2eRvLCvaI2uoBKttMtPywBodd4p2k+1onf3RT gwvUszVhrhgEOtKSCeKQNO76RrTKKWLDJFXHr0xvxt2CrEt5naxWVifi+qGQV+ZNilsd xO5cCkzFz8mDkNx4gaCC8Kn3x1biaZkfK/FK6sLxUlqP1FO72CNMsblwAyrua9Bi/ta6 UHgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=wNX1XP070bX3g2wpDZcViXWTCIq6wYMiqEg8PiBWmPg=; b=n3KEZU5vP4jLOpSxbDnBXfkEfOnokarPrcsdY8PexznWgbh4JsXMWNUOFrgMG/wMZu 3ur1Y5WIbNJD90fDqvPPnnDZyG19k+2Sq7XYolVM4GeDFxxNlkRTc55kqtb6BQqfojWs VBmP0DBpXWLI1JZBCo4Qr93yt2PFVMMwU1u6y3ymh/W/SvwsgiGEapnf6FUSms13Rwwl 7mtOw+NhEaa4s/gdr4kMAq7MdRoPN7b16sF7yres/hZQBmAuT8IRb52mbChVV8howz+/ cpKcXtdbePa/jOIf0SvLSzPyqI7Y8U+Sz8CvtfOw9w56v+taAe0uhA5HFY6gaFpexXRL ipvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=R9Ki1ksp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a637a47000000b004d08be9517fsi12247389pgn.478.2023.02.06.08.14.19; Mon, 06 Feb 2023 08:14:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=R9Ki1ksp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbjBFQNr (ORCPT + 99 others); Mon, 6 Feb 2023 11:13:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231785AbjBFQNa (ORCPT ); Mon, 6 Feb 2023 11:13:30 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EBD32196E; Mon, 6 Feb 2023 08:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675699994; x=1707235994; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nqrQtqd1T9xl/j9igH6LicfTqt28OCju6w046xOfGT8=; b=R9Ki1kspX3VfeFMu/fKN1mHTYox6ZinvaNu+9w6n0WuRTSB4Qb50aAa2 JLDKEd1wLl5l+KqX0QkTTXaLaCn/AVWHE3ccoGU/NwPPl0iXMjmmFDvjS AgWdoXVaCNG/UI9c520NT3489C93fzh3V9KU5O4XpzqyG/SuyY5ku9vG6 EH2n4+e5+ab4gdE7JQvi/K0zy2c5GMgHjYFVDvOwAB66wxcPhm8Z1CSwk EoTp6r+wp2lehBOfOwfcQC3jT8sYgngf9x/5ZXKzJZjKbutePE0LIN20z 5WsqKa0lZ6AQd8zzMFlPo6C33dMkX9LNmu1Ie1IrYvQHhicA33lNrVBLA w==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="308888751" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="308888751" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 08:12:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="698884370" X-IronPort-AV: E=Sophos;i="5.97,276,1669104000"; d="scan'208";a="698884370" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 06 Feb 2023 08:12:37 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D6DDB1EA; Mon, 6 Feb 2023 18:13:15 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Jakub Kicinski , Xin Long , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dev@openvswitch.org, tipc-discussion@lists.sourceforge.net Cc: Andy Shevchenko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Pravin B Shelar , Jon Maloy , Ying Xue , Simon Horman Subject: [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header Date: Mon, 6 Feb 2023 18:13:12 +0200 Message-Id: <20230206161314.15667-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757098879135631062?= X-GMAIL-MSGID: =?utf-8?q?1757098879135631062?= Move string_is_valid() to the header for wider use. Signed-off-by: Andy Shevchenko Reviewed-by: Simon Horman --- v2: added tag and updated subject (Simon) include/linux/string_helpers.h | 5 +++++ net/tipc/netlink_compat.c | 6 +----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h index 88fb8e1d0421..01c9a432865a 100644 --- a/include/linux/string_helpers.h +++ b/include/linux/string_helpers.h @@ -12,6 +12,11 @@ struct device; struct file; struct task_struct; +static inline bool string_is_valid(const char *s, int len) +{ + return memchr(s, '\0', len) ? true : false; +} + /* Descriptions of the types of units to * print in */ enum string_size_units { diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index dfea27a906f2..75186cd551a0 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -39,6 +39,7 @@ #include "node.h" #include "net.h" #include +#include #include /* The legacy API had an artificial message length limit called @@ -173,11 +174,6 @@ static struct sk_buff *tipc_get_err_tlv(char *str) return buf; } -static inline bool string_is_valid(char *s, int len) -{ - return memchr(s, '\0', len) ? true : false; -} - static int __tipc_nl_compat_dumpit(struct tipc_nl_compat_cmd_dump *cmd, struct tipc_nl_compat_msg *msg, struct sk_buff *arg)